Re: [jose] Alissa Cooper's No Objection on draft-ietf-jose-json-web-algorithms-33: (with COMMENT)

Mike Jones <Michael.Jones@microsoft.com> Mon, 29 September 2014 22:43 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F5131ACD72; Mon, 29 Sep 2014 15:43:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cZn3YROcobs7; Mon, 29 Sep 2014 15:43:08 -0700 (PDT)
Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0112.outbound.protection.outlook.com [207.46.100.112]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E86EE1ACD70; Mon, 29 Sep 2014 15:43:08 -0700 (PDT)
Received: from BY2PR03CA079.namprd03.prod.outlook.com (10.141.249.52) by BY1PR0301MB1207.namprd03.prod.outlook.com (25.161.203.156) with Microsoft SMTP Server (TLS) id 15.0.1039.15; Mon, 29 Sep 2014 22:43:07 +0000
Received: from BY2FFO11FD033.protection.gbl (2a01:111:f400:7c0c::134) by BY2PR03CA079.outlook.office365.com (2a01:111:e400:2c5d::52) with Microsoft SMTP Server (TLS) id 15.0.1039.15 via Frontend Transport; Mon, 29 Sep 2014 22:43:01 +0000
Received: from mail.microsoft.com (131.107.125.37) by BY2FFO11FD033.mail.protection.outlook.com (10.1.14.218) with Microsoft SMTP Server (TLS) id 15.0.1029.15 via Frontend Transport; Mon, 29 Sep 2014 22:43:00 +0000
Received: from TK5EX14MBXC288.redmond.corp.microsoft.com ([169.254.3.218]) by TK5EX14HUBC103.redmond.corp.microsoft.com ([157.54.86.9]) with mapi id 14.03.0195.002; Mon, 29 Sep 2014 22:42:07 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Alissa Cooper <alissa@cooperw.in>, The IESG <iesg@ietf.org>
Thread-Topic: Alissa Cooper's No Objection on draft-ietf-jose-json-web-algorithms-33: (with COMMENT)
Thread-Index: AQHP22Nh/Ooxbo9Z6kW9ar3u5z04qZwYtUuw
Date: Mon, 29 Sep 2014 22:42:06 +0000
Message-ID: <4E1F6AAD24975D4BA5B16804296739439BAA14D8@TK5EX14MBXC288.redmond.corp.microsoft.com>
References: <20140928212955.32419.90607.idtracker@ietfa.amsl.com>
In-Reply-To: <20140928212955.32419.90607.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [157.54.51.32]
Content-Type: multipart/alternative; boundary="_000_4E1F6AAD24975D4BA5B16804296739439BAA14D8TK5EX14MBXC288r_"
MIME-Version: 1.0
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:131.107.125.37; CTRY:US; IPV:CAL; IPV:NLI; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(438002)(52044002)(189002)(13464003)(377454003)(199003)(84326002)(15975445006)(68736004)(33656002)(19625215002)(77096002)(81156004)(106466001)(46102003)(97736003)(120916001)(230783001)(106116001)(99396003)(10300001)(85306004)(80022003)(85852003)(21056001)(95666004)(31966008)(92566001)(16236675004)(66066001)(6806004)(54356999)(92726001)(19580395003)(84676001)(44976005)(19580405001)(71186001)(512874002)(4396001)(86362001)(86612001)(76482002)(19300405004)(76176999)(107046002)(64706001)(2656002)(50986999)(104016003)(15202345003)(26826002)(20776003)(69596002)(55846006)(87936001)(19617315012); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0301MB1207; H:mail.microsoft.com; FPR:; MLV:ovrnspm; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en;
X-Microsoft-Antispam: UriScan:;
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1207;
X-O365ENT-EOP-Header: Message processed by - O365_ENT: Allow from ranges (Engineering ONLY)
X-Forefront-PRVS: 034902F5BC
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates 131.107.125.37 as permitted sender) receiver=protection.outlook.com; client-ip=131.107.125.37; helo=mail.microsoft.com;
Authentication-Results: spf=pass (sender IP is 131.107.125.37) smtp.mailfrom=Michael.Jones@microsoft.com;
X-OriginatorOrg: microsoft.onmicrosoft.com
Archived-At: http://mailarchive.ietf.org/arch/msg/jose/1uxX0d_6N8agGsB82yYNbfYKObg
Cc: "jose-chairs@tools.ietf.org" <jose-chairs@tools.ietf.org>, "jose@ietf.org" <jose@ietf.org>, "draft-ietf-jose-json-web-algorithms@tools.ietf.org" <draft-ietf-jose-json-web-algorithms@tools.ietf.org>
Subject: Re: [jose] Alissa Cooper's No Objection on draft-ietf-jose-json-web-algorithms-33: (with COMMENT)
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Sep 2014 22:43:11 -0000

Thanks for your review, Alissa.  I’ve added the working group to this thread so they're aware of your comments.  Replies are inline below…



-----Original Message-----
From: Alissa Cooper [mailto:alissa@cooperw.in]
Sent: Sunday, September 28, 2014 2:30 PM
To: The IESG
Cc: jose-chairs@tools.ietf.org; draft-ietf-jose-json-web-algorithms@tools.ietf.org
Subject: Alissa Cooper's No Objection on draft-ietf-jose-json-web-algorithms-33: (with COMMENT)



Alissa Cooper has entered the following ballot position for

draft-ietf-jose-json-web-algorithms-33: No Objection



When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)





Please refer to http://www.ietf.org/iesg/statement/discuss-criteria.html

for more information about IESG DISCUSS and COMMENT positions.





The document, along with other ballot positions, can be found here:

http://datatracker.ietf.org/doc/draft-ietf-jose-json-web-algorithms/







----------------------------------------------------------------------

COMMENT:

----------------------------------------------------------------------



== Section 3.4 ==

"Signing and validation with the ECDSA P-384 SHA-384 and ECDSA P-521

  SHA-512 algorithms is performed identically to the procedure for

  ECDSA P-256 SHA-256 -- just using the corresponding hash algorithms

  with correspondingly larger result values.  For ECDSA P-384 SHA-384,

  R and S will be 384 bits each, resulting in a 96 octet sequence.  For

  ECDSA P-521 SHA-512, R and S will be 521 bits each, resulting in a

  132 octet sequence."



For the ECDSA P-521 SHA-512 case, how does the result amount to 132 octets? Is there padding inserted into R and S?



The P-521 curve uses 521-bit R and S values.  It takes 66 octets to represent 521 bits.  There are two 66-octet values, hence 132 octets.



== Section 7 ==



Do we use iesg@iesg.org<mailto:iesg@iesg.org>? I usually use iesg@ietf.org<mailto:iesg@ietf.org>.



== Section 8.4 ==

"An Initialization Vector value MUST never be used multiple times with

   the same AES GCM key."



I think what was intended here was s/MUST never/MUST NOT/



Agreed.  To keep the same level of emphasis, I propose to change “MUST never” to “MUST NOT ever”.



                                                            -- Mike