Re: [jose] WGLC comments from Mike Jones on draft-ietf-jose-cfrg-curves-02

Ilari Liusvaara <ilariliusvaara@welho.com> Wed, 15 June 2016 10:09 UTC

Return-Path: <ilariliusvaara@welho.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DBE8C12D0AC for <jose@ietfa.amsl.com>; Wed, 15 Jun 2016 03:09:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.326
X-Spam-Level:
X-Spam-Status: No, score=-3.326 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-1.426] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pLSpOfy0q1e8 for <jose@ietfa.amsl.com>; Wed, 15 Jun 2016 03:09:58 -0700 (PDT)
Received: from welho-filter4.welho.com (welho-filter4.welho.com [83.102.41.26]) by ietfa.amsl.com (Postfix) with ESMTP id 01C8412B039 for <jose@ietf.org>; Wed, 15 Jun 2016 03:09:57 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by welho-filter4.welho.com (Postfix) with ESMTP id 0A07A3F97; Wed, 15 Jun 2016 13:09:56 +0300 (EEST)
X-Virus-Scanned: Debian amavisd-new at pp.htv.fi
Received: from welho-smtp2.welho.com ([IPv6:::ffff:83.102.41.85]) by localhost (welho-filter4.welho.com [::ffff:83.102.41.26]) (amavisd-new, port 10024) with ESMTP id bx4AczOcYe7z; Wed, 15 Jun 2016 13:09:55 +0300 (EEST)
Received: from LK-Perkele-V2 (87-100-224-2.bb.dnainternet.fi [87.100.224.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by welho-smtp2.welho.com (Postfix) with ESMTPSA id C69CD21C; Wed, 15 Jun 2016 13:09:55 +0300 (EEST)
Date: Wed, 15 Jun 2016 13:09:53 +0300
From: Ilari Liusvaara <ilariliusvaara@welho.com>
To: Mike Jones <Michael.Jones@microsoft.com>
Message-ID: <20160615100953.GA10343@LK-Perkele-V2.elisa-laajakaista.fi>
References: <SN1PR0301MB1645CB221341960B88E732B8F5550@SN1PR0301MB1645.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <SN1PR0301MB1645CB221341960B88E732B8F5550@SN1PR0301MB1645.namprd03.prod.outlook.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: ilariliusvaara@welho.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/jose/56L4QhI3PaSZbnsAvYdDyZqJNNU>
Cc: "jose@ietf.org" <jose@ietf.org>
Subject: Re: [jose] WGLC comments from Mike Jones on draft-ietf-jose-cfrg-curves-02
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2016 10:10:00 -0000

On Wed, Jun 15, 2016 at 03:28:38AM +0000, Mike Jones wrote:
> This is a straightforward document that presents its subject clearly.
>  All but two of my comments propose corrections to editorial nits. 

> The one normative change suggested is as follows.  Section 3.2.1
> "Performing the ECDH Operation" currently says "The output is the
> value for "x" parameter of "epk" field".  This should be changed
> instead to "The base64url encoding of the output is the value for
> the "x" parameter of the "epk" field".
> 
> In Appendix A.3 "JWK Thumbprint Canonicalization", I also propose
> supplying a base64url encoded version of the JWK Thumbprint value.
>  I added this to the edited draft attached.

Thanks, appiled to Editor's Copy.


-Ilari