Re: [jose] Pete Resnick's Discuss on draft-ietf-jose-json-web-algorithms-33: (with DISCUSS and COMMENT)

"Jim Schaad" <ietf@augustcellars.com> Mon, 06 October 2014 00:26 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E70F1A017A; Sun, 5 Oct 2014 17:26:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.1
X-Spam-Level:
X-Spam-Status: No, score=0.1 tagged_above=-999 required=5 tests=[BAYES_50=0.8, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BG-a1FbsAXtF; Sun, 5 Oct 2014 17:25:59 -0700 (PDT)
Received: from smtp3.pacifier.net (smtp3.pacifier.net [64.255.237.177]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 195631A016A; Sun, 5 Oct 2014 17:25:59 -0700 (PDT)
Received: from Philemon (unknown [50.38.74.159]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jimsch@nwlink.com) by smtp3.pacifier.net (Postfix) with ESMTPSA id 1C2EC38F02; Sun, 5 Oct 2014 17:25:53 -0700 (PDT)
From: "Jim Schaad" <ietf@augustcellars.com>
To: "'Mike Jones'" <Michael.Jones@microsoft.com>, "'Pete Resnick'" <presnick@qti.qualcomm.com>, "'The IESG'" <iesg@ietf.org>
References: <20141002030353.19877.20944.idtracker@ietfa.amsl.com> <4E1F6AAD24975D4BA5B16804296739439BAE9BDA@TK5EX14MBXC286.redmond.corp.microsoft.com>
In-Reply-To: <4E1F6AAD24975D4BA5B16804296739439BAE9BDA@TK5EX14MBXC286.redmond.corp.microsoft.com>
Date: Sun, 5 Oct 2014 17:23:17 -0700
Message-ID: <007901cfe0fb$bf274a30$3d75de90$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQKaqRMOcJ2G/n4SsvqwHOa7TvEquwGXUVMemn/M1FA=
Content-Language: en-us
Archived-At: http://mailarchive.ietf.org/arch/msg/jose/H2taW1gTVi3J3BTUmK9rUovHVBE
Cc: jose-chairs@tools.ietf.org, draft-ietf-jose-json-web-algorithms@tools.ietf.org, jose@ietf.org
Subject: Re: [jose] Pete Resnick's Discuss on draft-ietf-jose-json-web-algorithms-33: (with DISCUSS and COMMENT)
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2014 00:26:01 -0000


> -----Original Message-----
> From: jose [mailto:jose-bounces@ietf.org] On Behalf Of Mike Jones
> Sent: Saturday, October 04, 2014 6:07 PM
> To: Pete Resnick; The IESG
> Cc: jose-chairs@tools.ietf.org; jose@ietf.org; draft-ietf-jose-json-web-
> algorithms@tools.ietf.org
> Subject: Re: [jose] Pete Resnick's Discuss on draft-ietf-jose-json-web-
> algorithms-33: (with DISCUSS and COMMENT)
> 
> Thanks for your review, Pete.  I'm adding the working group so they re aware
> of these comments.  At Stephen Farrell's request, I'm responding with "> "
> line prefixes on previous thread content.  I'm also repeating (and in some
> cases, augmenting) my previous responses to the DISCUSS comments in this
> consolidated response.
> 
> > -----Original Message-----
> > From: Pete Resnick [mailto:presnick@qti.qualcomm.com]
> > Sent: Wednesday, October 01, 2014 8:04 PM
> > To: The IESG
> > Cc: jose-chairs@tools.ietf.org; draft-ietf-jose-json-web-
> > algorithms@tools.ietf.org
> > Subject: Pete Resnick's Discuss on
> > draft-ietf-jose-json-web-algorithms-33: (with DISCUSS and COMMENT)
> >
> > Pete Resnick has entered the following ballot position for
> > draft-ietf-jose-json-web-algorithms-33: Discuss
> >
> > When responding, please keep the subject line intact and reply to all
> > email addresses included in the To and CC lines. (Feel free to cut
> > this introductory paragraph, however.)
> >
> >
> > Please refer to
> > http://www.ietf.org/iesg/statement/discuss-criteria.html
> > for more information about IESG DISCUSS and COMMENT positions.
> >
> >
> > The document, along with other ballot positions, can be found here:
> > http://datatracker.ietf.org/doc/draft-ietf-jose-json-web-algorithms/
> >
> >
> >
> > ----------------------------------------------------------------------
> > DISCUSS:
> > ----------------------------------------------------------------------
> 
> > 4.6.2: AlgorithmID. UTF-8 has me worried here. It has me more worried
> > in 4.8, but we'll talk about that later. Here, aren't all "enc" and "alg"
> > values US-ASCII anyway? Saying US-ASCII here would solve the problem,
> > so unless you think you're going to have the M tleyCr e algorithm,
> > perhaps we can avoid any concerns for this case. (My concern is that you
> can have "interesting"
> > UTF-8 strings with ZERO-WIDTH JOINERs and other nonsense that you
> > probably don't mean to address.
> 
> Even if people used pathological Unicode characters, the exact-match string
> comparison rules would handle this OK.  In practice, what I think we should
> do is provide guidance in the IANA registry instructions that only reasonable,
> displayable Unicode character sequences be registered.  I m reluctant to tell
> people using non-US character sets that they can t use printable glyphs from
> their own languages.  Do people have a suggestion what language this
> guidance should contain?

I agree with Mike that we should move away from the ASCII centric world.  I think this falls under the case of really obvious things that designated experts should be checking for.  I am not sure that I believe that any changes are required for this.

> 
> > 4.8:
> >
> >    The PBES2 password input is an
> >    octet sequence; if the password to be used is represented as a text
> >    string rather than an octet sequence, the UTF-8 encoding of the text
> >    string MUST be used as the octet sequence.
> >
> > This one worries me a lot. It's one thing to say that the password is
> > an octet sequence and the application above is responsible for
> > collecting it from the user and passing it in the correct form. But to
> > say down here in the guts that it MUST be UTF-8 brings up all sorts of
> > ugly questions regarding normalization. I don't think you want to
> > touch this with a 10-foot-pole. I certainly thing you want to stay away from
> that MUST.
> 
> To achieve interoperation, some encoding has to be specified, and UTF-8
> seems like the best choice.  Restricting human-visible passwords to ASCII isn t
> reasonable for most cultures.
> 

I think that your issues with this could in some degree be addressed by having a highlighting pointer to section 9, or to just include the section 9 text at this location.  People generally think of password as being strings, which I admit is only partly true, and at least in JavaScript this is going to be more enforced as there is no real way to distinguish between text strings and octet strings.  I was curious and looked at the precis on passwords and note that it assumes that the strings are UNICODE strings and therefore some type of method of going from UNICODE strings to octet sequences.  I would probably be more inclined to agree with you if I did not expect this to be so heavily used in JavaScript.


> > ----------------------------------------------------------------------
> > COMMENT:
> > ----------------------------------------------------------------------
> >
> > 3.2:
> >
> >    A key of the same size as the hash output (for instance, 256 bits for
> >    "HS256") or larger MUST be used with this algorithm.
> >
> > Is this specific to JOSE, or is this a general requirement for use of
> > SHA-2? If the latter, a reference would be better than a MUST in here.
> 
> This is an additional requirement imposed by the JOSE use of this algorithm.
> (I believe this requirement was proposed by ekr.)

The specificity of this requirement is not a SHA-2 requirement.  The actual reference that would be used would be NIST SP 800-107-rev 1 section 5.3.4.  I am will versed in reading such specifications and how hash algorithms function.  It still took me about 4 readings through this section to figure out what was actually being said.   Having this simple statement in the document seems to be much easier to understand.

The document says - security = min(key length, hash internal barrel size * 2)

> 
> > [There are many things in the document that look like algorithm
> > requirements and not JOSE requirements. I've noted a few more below,
> > but these should be looked for generally. If something is part of the
> > definition of the algorithm and documented elsewhere, no need to have
> > requirements language, let alone a description of how to run the
> > algorithm, in this document; that should be an external reference.]
> 
> Another example is that we require 2048 bit keys or larger for RSA signatures.
> This is informed by the NIST algorithm usage requirements.  Per ekr's input
> during the BoF that led to JOSE, there's no point in allowing the use of
> deprecated algorithms or key sizes in a new cryptographic format.

I could go either way on saying that these types of restrictions and recommendations are in this document or not.  They are not part of CMS so that they need to be specified by any document such as S/MIME that uses CMS.  Having them here means that initially documents such as JWT do not need to specify them.   I think this is part of the mandatory to implement so that an application has a minimum set of algorithms that it knows it can use for all libraries.

> 
> > In the 5th paragraph (the one right after the table), strike
> > everything after the first sentence. Decoding and encoding are things
> > that are JWS specific and should not be in this document.
> 
> In numerous cases, this document is intentionally about how JOSE uses these
> algorithms and not purely about abstract algorithms.  The particular text you
> cite is there to help developers get the validation right, and explains two
> ways that it can be correctly coded.  Another example of where the JWA
> document is intentionally JOSE specific is that the PBES2 algorithms define
> Header Parameter values.
> 
> > 3.3/3.5/4/2/4.3:
> >
> >    A key of size 2048 bits or larger MUST be used with this algorithm.
> >
> > Is this specific to JOSE, or is this a general requirement for use of RSA?
> 
> This is informed by NIST's current guidance on how to use RSA.
> 
> > 3.6: This section seems to be for the JWS document, not this one. If
> > you want to define the "None" algorithm, go ahead and do that, but
> > describing its use in JWS doesn't belong here.
> 
> This section defines the algorithm identifier "none" and its meaning.  An early
> working group decision was that all algorithm identifiers would reside in the
> JWA document and not the JWA, JWE, or JWK specifications.
> 
> > 4.6:
> >
> >    A new ephemeral public key value MUST be generated for each key
> >    agreement operation.
> >
> > Again, specific to JOSE, or requirement of ECDH-ES?
> 
> I believe that this is a JOSE requirement which may be more conservative
> than strictly required, but was included to err on the side of both security and
> simplicity.  Without this simple requirement, developers would be likely to
> use ECDH-ES insecurely.
> 

This is a frequently stated requirement for ES algorithms.  You get some interesting arguments such as the one that raged for a while in the CFRG mailing list that was saying - we can use an ephemeral key for a "short" amount of time.  Explicitly stating this requirement seems to be a good idea.

> 
> 				Thanks again,
> 				-- Mike
> 
> _______________________________________________
> jose mailing list
> jose@ietf.org
> https://www.ietf.org/mailman/listinfo/jose