Re: [jose] Shepherd comments

Mike Jones <Michael.Jones@microsoft.com> Wed, 11 November 2015 15:37 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 81A5A1B2A4D for <jose@ietfa.amsl.com>; Wed, 11 Nov 2015 07:37:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e2p-mMiLAnpE for <jose@ietfa.amsl.com>; Wed, 11 Nov 2015 07:37:08 -0800 (PST)
Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0138.outbound.protection.outlook.com [207.46.100.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 044391B2A4B for <jose@ietf.org>; Wed, 11 Nov 2015 07:37:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w1Yc2E+WYUwUpwSShCLuMxvAJjzoJFz3YAynofMZMzo=; b=B0J7qyZ9rloUhBvPd3m5ym8sQOmPfY/asQnsUL+aEIhqu3gzPTEoG1BfSy9//npj43cNWcMAwqNMMkZTkA5tMhvFPzkyW8wTuR4+1qTv/Z1DbAak7n3FNy7sYl3mXxoeEsHAA4kY7xd+1FInmg5/Xr/E2t5Pd+NM0JHjtjiF8Go=
Received: from BY2PR03MB442.namprd03.prod.outlook.com (10.141.141.145) by BY2PR03MB444.namprd03.prod.outlook.com (10.141.141.154) with Microsoft SMTP Server (TLS) id 15.1.318.15; Wed, 11 Nov 2015 15:37:06 +0000
Received: from BY2PR03MB442.namprd03.prod.outlook.com ([10.141.141.145]) by BY2PR03MB442.namprd03.prod.outlook.com ([10.141.141.145]) with mapi id 15.01.0325.003; Wed, 11 Nov 2015 15:37:06 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Jim Schaad <ietf@augustcellars.com>
Thread-Topic: [jose] Shepherd comments
Thread-Index: AdEOG2Q5ohlxj0VrRk20eIOXP14a1AOafLzg
Date: Wed, 11 Nov 2015 15:37:05 +0000
Message-ID: <BY2PR03MB4420A2030484FE8CA78491DF5130@BY2PR03MB442.namprd03.prod.outlook.com>
References: <0adf01d10e1b$7a445720$6ecd0560$@augustcellars.com>
In-Reply-To: <0adf01d10e1b$7a445720$6ecd0560$@augustcellars.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Michael.Jones@microsoft.com;
x-originating-ip: [12.130.119.129]
x-microsoft-exchange-diagnostics: 1; BY2PR03MB444; 5:xyk4O7yly7Iorqzh0n68m+WHHBi+48vSymPH1fsaGWv7cYUx+5daT6jpV9Ga0ws/YP7TkN5owrq2/TvRTe8Zi+bH7YnlPrZjCCEHAGSsnkopqJgs+FwcNkDsZkErGB8oZ4nsdcJqp5hEqgcuOabeiQ==; 24:cvRiw2aOjmzeD4CQVfyiYkCCwakl0Iu608upNxdPZvBR0nFkCu3drxRriJDKmtVTWCOsiyEkk2TZwiIjns8n1QwjncyF6jgjgkiHoMkn95s=; 20:MjG9Gnpi9X0qjDYNWAMLh+X1sZNT/4mZbhJsB+klSjvCcPpo1e26dZZzqUKVNGHsBg8OyQf0zvvrO2E7BJ1pkQ==
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB444;
x-microsoft-antispam-prvs: <BY2PR03MB444BC8CBCD122C65283D0D6F5130@BY2PR03MB444.namprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425024)(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046)(61426024)(61427024); SRVR:BY2PR03MB444; BCL:0; PCL:0; RULEID:; SRVR:BY2PR03MB444;
x-forefront-prvs: 0757EEBDCA
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(43784003)(164054003)(377454003)(51444003)(199003)(189002)(13464003)(99286002)(10400500002)(54356999)(122556002)(5005710100001)(76176999)(10290500002)(2950100001)(10090500001)(106356001)(101416001)(110136002)(105586002)(76576001)(189998001)(5001960100002)(19580405001)(50986999)(81156007)(5003600100002)(77096005)(97736004)(19580395003)(92566002)(74316001)(11100500001)(102836002)(8990500004)(86362001)(66066001)(2900100001)(86612001)(87936001)(40100003)(5004730100002)(33656002)(5007970100001)(5002640100001)(5008740100001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR03MB444; H:BY2PR03MB442.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2015 15:37:05.9116 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB444
Archived-At: <http://mailarchive.ietf.org/arch/msg/jose/YZTdbjXkn_R2tuhg_MXr9KdqNQI>
Cc: "jose@ietf.org" <jose@ietf.org>
Subject: Re: [jose] Shepherd comments
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2015 15:37:09 -0000

Thanks again for your comments, Jim.  These are addressed in draft -04.  Replies follow inline...

-----Original Message-----
From: jose [mailto:jose-bounces@ietf.org] On Behalf Of Jim Schaad
Sent: Saturday, October 24, 2015 2:19 PM
To: draft-ietf-jose-jws-signing-input-options@tools.ietf.org
Cc: jose@ietf.org
Subject: [jose] Shepherd comments

> I needed to review the document with a fine tooth comb for the shepherd report and came up with the following issues.

> 1. If you are going to define ASCII and UT8 in section 1.1, you should probably define BASE64URL since you are using them in the same manner.

Done

> 2.  Is it possible to use a UTF-16 string in section 3 for b64=false?  This does not seem to be explicitly rule out.  It would not be an issue for b64 encoded versions of the payload.

The UTF-8 encoding is specified in Section 5.3.

> 2.  Should have a flattened version of the structure in section 4.1 as well for comparison purposes.

Done

> 3.  In section 5.3 I find the sentence about performing escape processing slightly confusing.  It is not clear what operations are being applied in which direction.   Additionally, there appears to be a requirement that UTF-8 encoding be applied which is not reflected in Section 3.

The section now specifies that the escape processing is JSON string escape processing.

The JSON Serialization uses UTF-8, per Section 5.3.  The Compact Serialization, being restricted to ASCII characters, uses the ASCII encoding (which is equivalent to UTF-8 for these inputs), per Section 5.2.

> 4.  Please remove the double-quote marker for JWS JSON Serialization in section 7.  This is not and never has been a problem (as noted by the fact that there is no restriction about double-quotes in this document).  The first delimiter is a problem and should be note.  Leaving in the whitespace issues is reasonable as it could get messed up, although it should not, for the JSON encoding.

Base64url encoding the double-quote character when it appears in JWS JSON Serialization payloads does prevent it from being confused with the double-quote string delimiter.  That's the point of the remark.

> 5.  You still need to respond to the last pair of emails from myself and James about the 'crit' parameter  usage.  I think that some text will be require for this.  I note that he and I both described the same situation where this makes a difference.  This may be a requirement on crit or just a security consideration that needs to be discussed.

I replied to these earlier and added text to the security considerations about this.

> 6.  Curiosity.  If an application sends some messages detached an some in a URL safe form, would you consider that to be a case where an application could use b64 based on context for some messages but not others?

Yes.  The draft now talks about "it being consistently applied in each application context".

> Jim

				Thanks,
				-- Mike