IETF Logo Mail Archive

Re: [Json] ABNF nits

"Joe Hildebrand (jhildebr)" <jhildebr@cisco.com> Fri, 07 June 2013 02:39 UTC

Return-Path: <jhildebr@cisco.com>
X-Original-To: json@ietfa.amsl.com
Delivered-To: json@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6C6AA21F91B1 for <json@ietfa.amsl.com>; Thu, 6 Jun 2013 19:39:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fZssLThNQ92z for <json@ietfa.amsl.com>; Thu, 6 Jun 2013 19:39:25 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by ietfa.amsl.com (Postfix) with ESMTP id CCAEF21F9121 for <json@ietf.org>; Thu, 6 Jun 2013 19:39:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=987; q=dns/txt; s=iport; t=1370572765; x=1371782365; h=from:to:subject:date:message-id:in-reply-to:content-id: content-transfer-encoding:mime-version; bh=LhiIQUa5+1l+EZYg5+gv++iXkZbMPPUlGmm7IQfkCcw=; b=iqV44Pi9k1eqZT8VOFhfXdB9P0FXvRfLmRBXBxJn8DTH1lP2WXp/h4jD irfbq7PN1vl8KFK/bKmrQJAuW5hW4sTnk6y+955ZyTR+vO+woJWm0GS9n SgcAWyr4qwHS2RokLF0aqvjWqZBrnJY9p6OZqJgt7hd2k4PWqufr9KuQA Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AiQFAGdHsVGtJV2a/2dsb2JhbABZgwmDJbt8fBZ0giMBAQEDATpRAQgiFEIlAgQBEgiHcwMJBrMAHYhCjwE4gnphA6h/gw+CJw
X-IronPort-AV: E=Sophos;i="4.87,818,1363132800"; d="scan'208";a="219935555"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-4.cisco.com with ESMTP; 07 Jun 2013 02:39:25 +0000
Received: from xhc-rcd-x14.cisco.com (xhc-rcd-x14.cisco.com [173.37.183.88]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id r572dPZK005101 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 7 Jun 2013 02:39:25 GMT
Received: from xmb-rcd-x10.cisco.com ([169.254.15.56]) by xhc-rcd-x14.cisco.com ([173.37.183.88]) with mapi id 14.02.0318.004; Thu, 6 Jun 2013 21:39:24 -0500
From: "Joe Hildebrand (jhildebr)" <jhildebr@cisco.com>
To: "Manger, James H" <James.H.Manger@team.telstra.com>, "json@ietf.org" <json@ietf.org>
Thread-Topic: ABNF nits
Thread-Index: AQHOYxhuLNPlu69CpUeh/eSpf1GKTZkpg97A///1nAA=
Date: Fri, 07 Jun 2013 02:39:24 +0000
Message-ID: <A723FC6ECC552A4D8C8249D9E07425A70FC326C8@xmb-rcd-x10.cisco.com>
In-Reply-To: <255B9BB34FB7D647A506DC292726F6E1151B21F79E@WSMSG3153V.srv.dir.telstra.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.3.4.130416
x-originating-ip: [10.21.88.234]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <48B4847B79ECC540A3F7678EC1DA8045@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Json] ABNF nits
X-BeenThere: json@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "JavaScript Object Notation \(JSON\) WG mailing list" <json.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/json>, <mailto:json-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/json>
List-Post: <mailto:json@ietf.org>
List-Help: <mailto:json-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/json>, <mailto:json-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jun 2013 02:39:31 -0000

On 6/6/13 8:24 PM, "Manger, James H" <James.H.Manger@team.telstra.com>
wrote:

>> Some things I found futzing with the ABNF:
>> 
>> - normalize the indentation (makes it easier to pull out)
>> - Hex literals need to be uppercase.  The false and null rules are
>> wrong.
>
>Lowercase is allowed in hex literals.
>It links back to HEXDIG in RFC5234 (or RFC 4234).
>You have to remember the sneaky ABNF rule that quoted strings (eg "A")
>are case insensitive. "A" is equivalent to %x41 / %x61.

Crap.  I didn't see that because it's in a "Note:" in section 2.3.
Regardless, we should change  both of those rules for consistency with the
rest of the doc.

>> - DIGIT and HEXDIG are neither defined nor imported, as far as I can
>> tell.
>>  I suggest:
>> 
>> DIGIT = %x30-39                        ; 0-9
>> HEXDIG = %x30-39 / %x41-46 / %x61-66   ; 0-9, A-F, or a-f

I still recommend being explicit about this, like the rule for e.

-- 
Joe Hildebrand

v2.23.0 | Report a Bug | By Email