Re: [kitten] Opsdir last call review of draft-ietf-kitten-pkinit-alg-agility-04

Scott Bradner <sobradner@gmail.com> Wed, 27 February 2019 11:17 UTC

Return-Path: <sobradner@gmail.com>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79C5B129741; Wed, 27 Feb 2019 03:17:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iyqzDxDECr6Y; Wed, 27 Feb 2019 03:17:51 -0800 (PST)
Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB7BF128CF3; Wed, 27 Feb 2019 03:17:51 -0800 (PST)
Received: by mail-qt1-x82f.google.com with SMTP id d18so18619688qtg.12; Wed, 27 Feb 2019 03:17:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IY4fTH58iZ3dWOvIB1sHzrFFbqqK7/8xlMl1AiZfXZc=; b=lC9MyCqCWI8GLSyW1sAjp7rZHwXQsFOQ9I3f7HEc/Pm4Rnv+aaRkhPdggSCHHfocn/ MPATJtTxPfiAufnuzrh6H2M9O6WQDqanbik/6XENahy3vjZ3nOKXpaSJhDdkaPu91FUR lIkfvr0sfR66uevNAuHsxzw5RafhcPin+DxpSTYAjRb+icA4bWrsvQSKQ4QMO707SqrX 4SDpYjfFUaGArW22yRkDEecpcl/pPug4gSpTlSQyGe+83xJDVs7ISPmjUrIwSefPZORi I/UpyESqGNug7nEuz2OHeOjiAS99DPC7ihUfbaeoA9l18fVv7lSveoth9ivmKXXTA1y/ cH+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IY4fTH58iZ3dWOvIB1sHzrFFbqqK7/8xlMl1AiZfXZc=; b=TQLaAoWyphdwUKPXrjVj56XWh4CeUYLpTOxuSXB0vV9YWytqZRY+p428tMaEE+p4kB 2hp1GEWdtIRHCAhkkFwFe5UBxjITwmrMhGNtVIX8wJbZsEAG5zZILewEJ0UV0LWbdort GPVfLTsSSWLezH5ZNndTTB3hFdI4UFFD+oof7BShUEZlrlnMkr0z+eltLzHiUkDRN/dJ pNjtD+A9sS9TpiaFswkRkwG0D4Z3c+/UZvf+XGn7HxfEelhinE/xnego22a0opG4NcQa sbq75v9pERaOMubzis9FCUnRm6zn9+BbIxrYUrfoHStEcdwGTuvfyyu3LIpoddPiKwOQ VjbA==
X-Gm-Message-State: APjAAAVVUybzT3h4Rms0FhYxVaj8q7Pho0Hl9cBs8vY+mQNjTWn6B1uk 6efN/8K0fdc+y3WA+NYQfpQ=
X-Google-Smtp-Source: APXvYqx9Mete6FbQ8sv+VaupiW4IhxU92yYlZ2nFVAubo8Bxc6rAJZ++BGVGVgWLIRQEczbL1COhoA==
X-Received: by 2002:a0c:8b63:: with SMTP id d35mr1395893qvc.148.1551266270891; Wed, 27 Feb 2019 03:17:50 -0800 (PST)
Received: from golem.sobco.com (golem.sobco.com. [136.248.127.162]) by smtp.gmail.com with ESMTPSA id c2sm15082613qtc.41.2019.02.27.03.17.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 03:17:50 -0800 (PST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Scott Bradner <sobradner@gmail.com>
In-Reply-To: <20190226214349.GA53396@kduck.mit.edu>
Date: Wed, 27 Feb 2019 06:17:47 -0500
Cc: ops-dir@ietf.org, kitten@ietf.org, ietf@ietf.org, draft-ietf-kitten-pkinit-alg-agility.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <3CABCE27-FD27-4AFE-B7C8-73F315ED8092@gmail.com>
References: <155043488911.4083.7977373920397028733@ietfa.amsl.com> <20190226214349.GA53396@kduck.mit.edu>
To: Benjamin Kaduk <kaduk@mit.edu>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/kitten/gnCy4P36flPia1FkHFBZD6Bt--c>
Subject: Re: [kitten] Opsdir last call review of draft-ietf-kitten-pkinit-alg-agility-04
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Feb 2019 11:17:54 -0000

looks good to me

thanks

Scott

> On Feb 26, 2019, at 4:43 PM, Benjamin Kaduk <kaduk@mit.edu> wrote:
> 
> Hi Scott,
> 
> On Sun, Feb 17, 2019 at 12:21:29PM -0800, Scott Bradner wrote:
>> Reviewer: Scott Bradner
>> Review result: Has Nits
>> 
>> This is an OPS-DIR review of PKINIT Algorithm Agility
>> (draft-ietf-kitten-pkinit-alg-agility).  This ID updates PKINIT following the
>> guidelines in BCP 201 to make it algorithm agile and to expose acceptable
>> algorithms.
>> 
>> This is a very well written clear document.  I do not find any operational
>> issues with the document except that the document could use a section on
>> interoperability (old server-new client, new server-old client).
>> 
>> There are a few words about the topic deep in section 6 about the supportedKDFs
>> field but I do not see a general discussion or a discussion about the kdf
>> field. The text about the supportedKDFs field could be moved to a new section
>> and each of the old/new combinations could be addressed.  I see this as an
>> operational issue because compatibility issues are a frequent source of
>> operational headaches.
> 
> Thanks for the review.  The authors have posted an -05 that appears to
> address your concerns.
> 
> Thanks to the authors for the updates!
> 
> -Ben