[L2tpext] draft-ieft-l2tpext-tdm-02.txt review
Ignacio Goyret <igoyret@lucent.com> Thu, 08 December 2005 04:08 UTC
Received: from localhost.cnri.reston.va.us ([127.0.0.1] helo=megatron.ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1EkD54-0002Fb-L5; Wed, 07 Dec 2005 23:08:30 -0500
Received: from odin.ietf.org ([132.151.1.176] helo=ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1EkD52-0002FV-IT for l2tpext@megatron.ietf.org; Wed, 07 Dec 2005 23:08:28 -0500
Received: from ietf-mx.ietf.org (ietf-mx [132.151.6.1]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id XAA19541 for <l2tpext@ietf.org>; Wed, 7 Dec 2005 23:07:35 -0500 (EST)
Received: from hoemail1.lucent.com ([192.11.226.161]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1EkDQr-00081I-Iy for l2tpext@ietf.org; Wed, 07 Dec 2005 23:31:01 -0500
Received: from horh1.emsr.lucent.com (h135-112-138-211.lucent.com [135.112.138.211]) by hoemail1.lucent.com (8.12.11/8.12.11) with ESMTP id jB848Jav024198; Wed, 7 Dec 2005 22:08:20 -0600 (CST)
Received: from new-wopr.eng.ascend.com (new-wopr.eng.ascend.com [135.140.53.19]) by horh1.emsr.lucent.com (8.12.11/8.12.11) with ESMTP id jB848IPh018690; Wed, 7 Dec 2005 22:08:18 -0600 (CST)
Received: from cliff.eng.ascend.com (cliff.eng.ascend.com [135.140.53.169]) by new-wopr.eng.ascend.com (8.11.6+Sun/8.10.2) with ESMTP id jB848It07604; Wed, 7 Dec 2005 20:08:18 -0800 (PST)
Received: from igoyret-t23 (dhcp-135-140-27-179 [135.140.27.179]) by cliff.eng.ascend.com (8.13.1/8.13.1) with SMTP id jB848D2h017969; Wed, 7 Dec 2005 20:08:17 -0800
Message-Id: <200512080408.jB848D2h017969@cliff.eng.ascend.com>
X-Mailer: QUALCOMM Windows Eudora Pro Version 4.0.2
Date: Wed, 07 Dec 2005 20:04:52 -0800
To: l2tpext@ietf.org
From: Ignacio Goyret <igoyret@lucent.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
X-Spam-Score: 1.9 (+)
X-Scan-Signature: 6cca30437e2d04f45110f2ff8dc1b1d5
Cc: sharon@axerra.com
Subject: [L2tpext] draft-ieft-l2tpext-tdm-02.txt review
X-BeenThere: l2tpext@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Layer Two Tunneling Protocol Extensions <l2tpext.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/l2tpext>, <mailto:l2tpext-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/l2tpext>
List-Post: <mailto:l2tpext@ietf.org>
List-Help: <mailto:l2tpext-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/l2tpext>, <mailto:l2tpext-request@ietf.org?subject=subscribe>
Sender: l2tpext-bounces@ietf.org
Errors-To: l2tpext-bounces@ietf.org
Hi, Just a few minor details: 1) In section 2.1, in regards to the "Bit Rate" field, it reads: "Bit Rate is defined in [PWE3-IANA]. Its usage for all types of TDM PWs assumes the following semantics: 1. This interface parameter MAY be omitted, if the attachment circuit bit-rate is unambiguously derived from the PW Type." Does this mean that the "Bit Rate" field can be omitted from the AVP? If so, how can you tell that this field is omitted but "Payload Bytes" is not? If that's not the case, the phrase needs to be rewritten to avoid confusions. May be a simple solution is to replace these paragraphs with something like this: "Bit Rate is defined in [PWE3-IANA]. Typically, it is expressed as the number of DS0 channels in the corresponding attachment circuit." Or even better: "Bit Rate is defined in [PWE3-IANA]." 2) There are similar issues on the definition of "Payload Bytes". For example, the term "payload type" is used in semantic #1. semantic number 2b probably needs to be rephrased to make it easier to parse and understand. 3) Why do you need the R bit in the TDM PW AVP? Why is the presence of the RTP AVP not sufficient to indicate presence of an RTP header? 4) If the T bit is not used, remove the description and indicate that the bit in the AVP is reserved. No need to carry leftovers :-) 5) Can you rephrase the description of the F bit? It is very confusing with the double negatives. 6) On the RTP AVP, the description of the D-bit is a bit confusing and leaves a few cases to be discussed. When can differential mode be used? Only if both sides send RTP AVPs with the D-bit set? What happens if one side sends an RTP AVP with the D-bit set and the other side sends an RTP AVP but with the D-bit cleared? BTW, you will need a better description of what does it mean "differential mode" or a reference to another document that describes it. 7) On section 2.2 (RTP AVP), am I correct in assuming that the C-bit refers to how the data is presented in the data channel? If so, may I suggest a small rewrite like this (between <add> and </add>)? "The C bit indicates the ordering of the RTP header and the control word <add>on the data channel</add>:" I haven't verified this, but is the order of the headers defined in detail in the drafts mentioned? If not, you would do a great service by adding a couple of drawings showing the sequence of headers. 8) To help IANA and the rfc-editor, you may want to consider replacing all "TBD" and "TBA" with unique strings as the ones you used in the IANA considerations section. 9) Section 3 reads: "...If the peer agrees with the CESoPSN AVP it will send an appropriate ICRP..." What is the "CESoPSN" AVP? It is not defined on this draft and there is no external reference. Can you clarify? BTW, idnits reports a minor detail: Checking nits according to http://www.ietf.org/ietf/1id-guidelines.txt: - It seems as if not all pages are separated by form feeds - found 0 form feeds but 8 pages Cheers, -Ignacio Goyret _______________________________________________ L2tpext mailing list L2tpext@ietf.org https://www1.ietf.org/mailman/listinfo/l2tpext
- [L2tpext] draft-ieft-l2tpext-tdm-02.txt review Ignacio Goyret