[L2tpext] l2tpext-sbfd-discriminator comments
Ignacio Goyret <i.goyret@alcatel-lucent.com> Tue, 08 December 2015 13:53 UTC
Return-Path: <i.goyret@alcatel-lucent.com>
X-Original-To: l2tpext@ietfa.amsl.com
Delivered-To: l2tpext@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 433B81B2E1D for <l2tpext@ietfa.amsl.com>; Tue, 8 Dec 2015 05:53:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.211
X-Spam-Level:
X-Spam-Status: No, score=-4.211 tagged_above=-999 required=5 tests=[BAYES_50=0.8, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h2WLKl9cOomE for <l2tpext@ietfa.amsl.com>; Tue, 8 Dec 2015 05:53:40 -0800 (PST)
Received: from smtp-fr.alcatel-lucent.com (fr-hpida-esg-02.alcatel-lucent.com [135.245.210.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3589C1B2E1B for <l2tpext@ietf.org>; Tue, 8 Dec 2015 05:53:39 -0800 (PST)
Received: from us70uusmtp3.zam.alcatel-lucent.com (unknown [135.5.2.65]) by Websense Email Security Gateway with ESMTPS id 85AC72C58EAB9 for <l2tpext@ietf.org>; Tue, 8 Dec 2015 13:53:34 +0000 (GMT)
Received: from cliff.eng.ascend.com (cliff.eng.ascend.com [192.207.23.55]) by us70uusmtp3.zam.alcatel-lucent.com (GMO) with ESMTP id tB8DrZYb000718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <l2tpext@ietf.org>; Tue, 8 Dec 2015 13:53:36 GMT
Received: from igoyret-c1.alcatel-lucent.com (vpn-26-93.vpn.alcatel-lucent.com [135.224.26.93]) by cliff.eng.ascend.com (8.13.1/8.13.1) with ESMTP id tB8DrTes027168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 8 Dec 2015 05:53:32 -0800
Message-Id: <201512081353.tB8DrTes027168@cliff.eng.ascend.com>
X-Mailer: QUALCOMM Windows Eudora Version 7.1.0.9
Date: Tue, 08 Dec 2015 05:52:01 -0800
To: l2tpext@ietf.org
From: Ignacio Goyret <i.goyret@alcatel-lucent.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Archived-At: <http://mailarchive.ietf.org/arch/msg/l2tpext/7oWxvgtWZRcrhbzsM3TtpfoVzVM>
Subject: [L2tpext] l2tpext-sbfd-discriminator comments
X-BeenThere: l2tpext@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Layer Two Tunneling Protocol Extensions <l2tpext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2tpext>, <mailto:l2tpext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l2tpext/>
List-Post: <mailto:l2tpext@ietf.org>
List-Help: <mailto:l2tpext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2tpext>, <mailto:l2tpext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 13:53:42 -0000
Hi authors, Minor details, mostly for clarity or grammar: 1) Page 3, "Encoding format" a) BEFORE: The S-BFD Target Discriminator ID AVP, Attribute Type TBD, is an ^^^^^ identifier used to advertise the S-BFD target discriminators ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ supported by an LCCE for S-BFD Reflector operation. AFTER: The S-BFD Target Discriminator ID AVP, Attribute Type TBD, advertises the S-BFD target discriminators ^^^^^^^^^^ supported by an LCCE for S-BFD Reflector operation. OR: s/advertises/identifies/ a) I believe it should be made more clear that each discriminator is 4 octets long. May be the drawing should be modified to show something like this: +------+------+------+------+ | Discriminator Value 1 | +------+------+------+------+ ..... +------+------+------+------+ The text description should also include a more formal declaration of the AVP value, something like this: "The Attribute Value field of this AVP is a sequence of one or more S-BFD Discriminator values, each 4 octets long." b) BEFORE: ...discard this AVP without affecting the rest of session negotiation. AFTER: ...discard this AVP without affecting the rest of the session negotiation. ^^^ c) BEFORE: the AVP encoding allows specification an arbitrary number of discrminators for extensibility. ^^^^ AFTER: the AVP encoding allows specification of an ^^^^ arbitrary number of discriminators for extensibility. ^ 2) "Acknowledgements" BEFORE: performing thorough reviews and providing number of comments. AFTER: performing thorough reviews and providing a number of comments. ^^^ OR: performing thorough reviews and providing numerous comments. ^^^^^^^^ -Ignacio
- [L2tpext] l2tpext-sbfd-discriminator comments Ignacio Goyret