Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt

"Jan Lindblad (jlindbla)" <jlindbla@cisco.com> Tue, 12 September 2017 06:54 UTC

Return-Path: <jlindbla@cisco.com>
X-Original-To: l3sm@ietfa.amsl.com
Delivered-To: l3sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9AE88132D18 for <l3sm@ietfa.amsl.com>; Mon, 11 Sep 2017 23:54:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IQsuBq4mKEfF for <l3sm@ietfa.amsl.com>; Mon, 11 Sep 2017 23:54:35 -0700 (PDT)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 266761321E6 for <l3sm@ietf.org>; Mon, 11 Sep 2017 23:54:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5664; q=dns/txt; s=iport; t=1505199275; x=1506408875; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=ungxhFSg6aU0LszvvP94kVqJGIqrIcLvVhUuJEGqPb4=; b=NUhf/bs36l+v3I1jE8HdMgbE8UAJybOHs4dnB2fq6b1aY2mo3L6jmspJ BM3y38RmRtywp/VzzVM+imOrPDP/8ZOVGa7wnzIQL/4KJhsFvGr9Opwnj DMYoxDIQQ4nI1cOvYGEltzNoWN7q1HuL3CH5hdBMC7BLAAMIfOeJbs5ny 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CGBABcg7dZ/4oNJK1cGQEBAQEBAQEBAQEBBwEBAQEBgnBrgVIug3CaQ5JehU2CBAqFPgIahA5XAQIBAQEBAQJrKIUZBg4VQhICEAIBCAQKNAICAjAlAgQOiVJkqiGCJ4sxAQEBAQEBAQEBAQEBAQEBAQEBAQEBHYMrggKBUIIOC4JyhF+DKzCCMQWgdQKUUJJylQACERkBgTgBV4ENdxVcAYcIiXSBDwEBAQ
X-IronPort-AV: E=Sophos;i="5.42,382,1500940800"; d="scan'208,217";a="2190973"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Sep 2017 06:54:34 +0000
Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id v8C6sYns001605 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 12 Sep 2017 06:54:34 GMT
Received: from xch-aln-004.cisco.com (173.36.7.14) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 12 Sep 2017 01:54:33 -0500
Received: from xch-aln-004.cisco.com ([173.36.7.14]) by XCH-ALN-004.cisco.com ([173.36.7.14]) with mapi id 15.00.1263.000; Tue, 12 Sep 2017 01:54:33 -0500
From: "Jan Lindblad (jlindbla)" <jlindbla@cisco.com>
To: Qin Wu <bill.wu@huawei.com>
CC: "David Ball -X (daviball - ENSOFT LIMITED at Cisco)" <daviball@cisco.com>, l3sm <l3sm@ietf.org>, "Benoit Claise (bclaise)" <bclaise@cisco.com>, adrian <adrian@olddog.co.uk>
Thread-Topic: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
Thread-Index: AQHTJvl1LUN8x/LDjUWvHXDkwgSGUKKnpP4ggAfVTYCAAR3wEIAAlZcA
Date: Tue, 12 Sep 2017 06:54:33 +0000
Message-ID: <B5B3032C-A0CB-4BD0-9497-191F2554F723@cisco.com>
References: <B8F9A780D330094D99AF023C5877DABA9AAFC86C@nkgeml513-mbx.china.huawei.com> <b85886fa-7f8f-3e56-a8cb-7d72c4828fba@cisco.com> <B8F9A780D330094D99AF023C5877DABA9AB0DDDD@nkgeml513-mbx.china.huawei.com>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABA9AB0DDDD@nkgeml513-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.61.106.102]
Content-Type: multipart/alternative; boundary="_000_B5B3032CA0CB4BD09497191F2554F723ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/l3sm/bxueBPaPqI-U01MZL64NkNTTS4k>
Subject: Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
X-BeenThere: l3sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: L3VPN Service YANG Model discussion group <l3sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l3sm>, <mailto:l3sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l3sm/>
List-Post: <mailto:l3sm@ietf.org>
List-Help: <mailto:l3sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l3sm>, <mailto:l3sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Sep 2017 06:54:36 -0000

Qin, team,


  *
For the address-allocation-type leaves, I saw you removed the default (as agreed) but also added 'mandatory true' (which was not discussed).  Making these leaves mandatory does not address the problem - if anything, it makes it worse.  (Issue 15 from draft-02)

[Qin]: Fine to me, it looks we need to seek balance between making all parameters mandatory and making all parameters optional. I hope Jan will be happy with these changes.

Sometimes mandatory true is needed to make a sane model, but mandatory elements also tend to make a model clunky, examples large etc. So I generally like optional elements. The problem with optional elements is people tend to forget that it may not be obvious what a system is supposed to do when there is no value specified. Adding a default or text in the description is therefore important. At the end of the day, we're writing a contract. For interoperability to happen, there must be no holes in the contract that are open to (differing) interpretation.

So sure, you can have optional elements (this should even be the normal case), and they don't need to have a default statement. But if so, *describe* what it means; what the system is supposed to do. No value is also a value.

Best,
/jan