Re: [Last-Call] [Bier] Genart last call review of draft-ietf-bier-tether-04
"Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net> Fri, 16 February 2024 04:05 UTC
Return-Path: <zzhang@juniper.net>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98184C14CE42; Thu, 15 Feb 2024 20:05:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b="L6tk9A1P"; dkim=pass (1024-bit key) header.d=juniper.net header.b="kfpj2o2c"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 66KV8T5U2LOh; Thu, 15 Feb 2024 20:04:59 -0800 (PST)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A558C151540; Thu, 15 Feb 2024 20:04:50 -0800 (PST)
Received: from pps.filterd (m0108162.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41G43WRb014620; Thu, 15 Feb 2024 20:04:50 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=PPS1017; bh=1wDoNct/VT7UgMDl5wYNXSgGWQ7+RSUChknML13/EOA=; b=L6tk9A1PnpiY vudxAAouS4kqAfim+yuAx2vL01h6A1g8EjqfTJnAE/NkOTCQ0atzVbdz9AMcdG1y 7ceDBvyYGqw6ag1V+jVSfTXuuLBBV5mtAP8i/1axOoSzG7zrwrXUU8Yl0JaSO+qt inANHWX97aZ4LjbGdD+JDtB6RltuNKRnxdbuRsTzljiRDLJ8/uy/oEe62olJaGDq +ldyN8Y8gFz7qqr3uQyJ2qRj6+djHMOptYy89TDKXzHVMeJOlZN8FZBZfCFCdHhg xqYuHdSK/CCWom4Bj87LR52YNiy/gD/YVLR1XOmjBMUgc6TvHC4lrK+xkC1qHI7u WzffPH4UYw==
Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazlp17010000.outbound.protection.outlook.com [40.93.20.0]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3w68999hte-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 20:04:49 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxUAj7T20QLZUNB35Tqf1OgKJDm65Ibk0bxy5acJnNErOPCE3jG0iVkj3ajrgnXK8TPBzJfBS697DrIdXOtsiLHzFDY17S78kErsYS/iLxnuHlJonYoSMfsCbX3lJ0uXwR8cRGBTbGZzA9B9WglTC8g+bXKpN1A2SuJuO50tDRa6gcTv6tcYVF9/ZXSKowVwDJFPuFXCvZ6C7dluCVbpWRtFZ7PAe1JbnYsepqzFKiG1yAl5hrlpn2Nc3smn6vFjgSwdvMaBJDCLm0UTCzcHuFEDOjKU4Eh016NuIpdvJ+daagJfsucOkiA9mGVDrtG1/hh9GpXztl0xa5USr/k9Pw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1wDoNct/VT7UgMDl5wYNXSgGWQ7+RSUChknML13/EOA=; b=dvEBylUhtZdvmPx44fGrL1lyTp2yO4XuFU4DcR/QbNEZxtfDs+JkbMWyo/aMzWE3JQCv5ivz5VFux0amV1lADgJ593XjS/xqf/xFfiEU6muA/PopEF8Tl+7BkeppMVsSQk0w3WtoDurtZA2xSBngzShSyD9usw48ZQvbk56+lEB0BHadAizAKiw5txnw5IFxm5tkewo+WL9b2i9l0X+XV1Bke0fAseKLnwrOGt/xRX08e6utMkYVxIaKUr0nqV+5sJSqQxH8D/XPOQ8UQbhsvZjyv2UNhmvC6LIVTllgbaLlpSV2fUv0bK13OrFpI9LC7TbSVn+34ZT0xSteUaKWfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1wDoNct/VT7UgMDl5wYNXSgGWQ7+RSUChknML13/EOA=; b=kfpj2o2cnPhnoX8tJvHn0lOxFRNWWEndZcrhbKumKKgncArckoPCvDhPbOKTX15REDaYSGNYROZwkhdGgLR3cKB6GFV7pXoBGp01tlIYU7BxuFIb3kMCwK2cLsSDXlx5IcLXgFzi4O9bu7TwoR4HFoO31YmWPtKt3SCRFvu/zfU=
Received: from IA1PR05MB9550.namprd05.prod.outlook.com (2603:10b6:208:426::16) by LV3PR05MB10381.namprd05.prod.outlook.com (2603:10b6:408:195::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.31; Fri, 16 Feb 2024 04:04:47 +0000
Received: from IA1PR05MB9550.namprd05.prod.outlook.com ([fe80::4c5d:def9:3e54:e076]) by IA1PR05MB9550.namprd05.prod.outlook.com ([fe80::4c5d:def9:3e54:e076%4]) with mapi id 15.20.7292.029; Fri, 16 Feb 2024 04:04:47 +0000
From: "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>
To: Joel Halpern <jmh@joelhalpern.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "bier@ietf.org" <bier@ietf.org>, "draft-ietf-bier-tether.all@ietf.org" <draft-ietf-bier-tether.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: [Bier] Genart last call review of draft-ietf-bier-tether-04
Thread-Index: AQHaYGQXEW4L/Ff9CE+x87KXTzYG37EMSFmw
Date: Fri, 16 Feb 2024 04:04:47 +0000
Message-ID: <IA1PR05MB95501395C3828241A18776F1D44C2@IA1PR05MB9550.namprd05.prod.outlook.com>
References: <170803858520.33924.988542142430727148@ietfa.amsl.com>
In-Reply-To: <170803858520.33924.988542142430727148@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=89002ccc-7586-48f2-8d31-9867e9939a9a; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=0633b888-ae0d-4341-a75f-06e04137d755; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2024-02-16T03:02:24Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: IA1PR05MB9550:EE_|LV3PR05MB10381:EE_
x-ms-office365-filtering-correlation-id: 833b3938-d268-4068-ad33-08dc2ea46a5e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8q1cs7ytEqOxmujFxM6ckdZIng5xAYFXgefhJwuokV4oHNkL1sQ7eBnimppaTeFjQLefYrkObsGOwBOVqFq5+so1FeUqeHT9aVgOxNsTfUiRaajKFUj+BSqjBYgdz/YNIKkZPJovYDpas0znO3c0GH4QwTZB3jf2N4HIn/yJAX8KB8SM5ll1uTy9RpTOepndVcD6CfoYvXI5tHke+KQqcW0zzOG/67znt+K4Ixoo36IWqrnQTXXslneNhRAcSvhxxHuCoLTMrgLrz+mcGQApt2nwXtkKeNTeSJcdipYLB7ic9f6qXYfY9GpuzRM7ANIgItyjTtPnEDHkgHqhlZ/d7FLfuNOPw3nQtLA8NMojQEsDF7yGR09ANDciCWjPqdR1lYrR01A7QfqsgIBWxXL0PgkeS4VCM2bLsPovBLQA+KF4orl8e0morhEkQXHAQX9QaPXFvBFaQ8/fpua5iRVBziyerzgiCMLe/aF9UtogW/LWyE2aINeSP+5xqxxIQjNGE82fS25P0B1OYge6jYnoSu92EqGdGXZPTU+jdGFrvEiDgMHL6+QhUEr2Gs71/m3eOHu8jJO66d75TfCqOWML3TFVkIKw7kWmWM2IQd/jZI0=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR05MB9550.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(346002)(136003)(39860400002)(376002)(230922051799003)(230273577357003)(1800799012)(64100799003)(186009)(451199024)(52536014)(76116006)(5660300002)(66946007)(66446008)(66556008)(4326008)(8676002)(8936002)(66476007)(64756008)(55016003)(2906002)(41300700001)(316002)(33656002)(66574015)(38070700009)(110136005)(54906003)(966005)(478600001)(71200400001)(53546011)(26005)(9686003)(86362001)(38100700002)(122000001)(83380400001)(6506007)(7696005); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: i+ZsASOkzm+ZiuL26ZgK+eXQpq/bxZDdwS9Dgr7SWP60N3wzBLEmjVf9ojnj2ZfLeds8d1H/HE/a1I43AlykxZncPFYAnG0Rq5lKVdCIdcf3acPWIHW255EgET9PcsvpzPS8LarbM1nRe9FtuhW3GmQO9yYfeZP3XpLAT5ENALdOAZloxAgAfyfv/hrapQbvIBJEHiQ/+3+pSNGcYoZtLGUYqXNGRQHkV4D3miWrvlUeM1nVunkei/JS34AFBX0U94pWaZTjsuQ3pD7o3XTCiTM3+nq5v0dfbfYcA7IUWmTppko2Am06CqsEz/oCk2YrkCz9VVOhgi6dily/jKBQXxXx9rlBAmdbQ3o/jAaXMu1mnqXb5bFHlB6NOy80MYUvUGYaBYQdX4MRqMBvglweIsLWlPc516othXnrVlI3Zqw57AULCC5kA4aJlrdxyOMegElLRe458rD6ZTXAsNGlBhIKZKYecZr2l5+rx5pnZGp+ITdt14JP9awUKyYVIBKmK7C7G0dAOWaS9Xmnopq2079fC6rTG/rppSu2FGEng95vzGTmLPtYWq7bhhaZFBvadblfOV+rz/Zi02iGgc6h6JdZx18LlsPQIOXkAZxSYQAVC4WisDUXxo3wm1akmrvjb9lUuGk0V1XjoGlAJRhHpUkW6HJ1bzVU77Ce29qGK3Ao0laqbMXEt7plgi32DIs8/ORHlvjY32EeASU6gePKU25jMyu5TA20jcQlo2+xDP7lkjXBGtEuanIE1pvHE2F1GtfJv5DamyuNYGscC+INZIHtLJis2cHM9vReelUn3ExHUtGdvY4P6DNy/FuF8r/bF1i+irLO82uvDYy6rEP1JQay5HXHHAE8pCmJKPf2ow7z8tDNSz2/yeW7k5+5/zC5RL/+N+I+w2Ym/XzIDfqsBPVgzNSQwDeOa8vJPzkChJbwpDEAXg3vw8/AJF2ZRTcKU9BsXzhj/VpyRUHNy+xzqGux2i4+cb4xbBeKlXNu2IOpBfdDRNlLUkliejUArQvNepRp6jfwPqf+Qlzwu8C9GeMalejoBTFN08LKn3VEW5xo1s+uxJbZDom8Ycng6L3jQ28cbZ9eRYD/6a0t0JiAE04pwY7sjMCGdERasT+3DPhAX394dhVcxPqnR6LjFzEw1Tg9SJgbmCC18laAxR5KLCSOO8BGMeHPxlh1GoR5wqIRbVhFnq0g2CqGD5BFBndmhSN6CBP5O2wme9RAA34wK8iEfXFtuelDyOVkmetQZjCnNCwHLH5OZQYeuI0DNTulyac9lPaqAmFRRP9E+NDTEmNJXoyqLxMVXsvMTeQkrhOpcuCVeWf1xzJsOiUaV15cbd21PrCHxcafEFoE5HQYqsmdbWq27wIV0KccuGvXdFRu2J6tFevIwThKiFBWZWxQqr4ejeb5Cigi2ENZCWSKCRHCpoOV3AftnITJcTP1FF2Lc/YAGDMUa8MnX1Kq39qCnjJtkS+YOWgaK/rZ47ERwGxT2SDgd08NC9G1ew+dB02EkGJ1IX8vESnLujfW3SJCUUUoUrLzGSqu3s6anzQ/afGHg//93T5noftD3q4fXlU8XWN8nUAtwOoxqvP7KRqJ
Content-Type: text/plain; charset="utf-7"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR05MB9550.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 833b3938-d268-4068-ad33-08dc2ea46a5e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2024 04:04:47.3377 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ozIYHWxaggA6mxKutD/WI64oXOTno8I8WDufdGM8akSwSapFNPxLqwyN+CJ+9Adxbb8BTHTQ2L3JRm+C4DJTJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR05MB10381
X-Proofpoint-GUID: CHIl4iHfkQBmDonwbZ6Upae1sx6qLtgT
X-Proofpoint-ORIG-GUID: CHIl4iHfkQBmDonwbZ6Upae1sx6qLtgT
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-16_03,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 clxscore=1011 spamscore=0 malwarescore=0 bulkscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402160031
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/-TVBrXfQsDSH8ujYyCXazwIWF4o>
Subject: Re: [Last-Call] [Bier] Genart last call review of draft-ietf-bier-tether-04
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Feb 2024 04:05:04 -0000
Hi Joel, Thanks for your review and comments. Please see zzh> below. Juniper Business Use Only -----Original Message----- From: BIER <bier-bounces@ietf.org> On Behalf Of Joel Halpern via Datatracker Sent: Thursday, February 15, 2024 6:10 PM To: gen-art@ietf.org Cc: bier@ietf.org; draft-ietf-bier-tether.all@ietf.org; last-call@ietf.org Subject: [Bier] Genart last call review of draft-ietf-bier-tether-04 [External Email. Be cautious of content] Reviewer: Joel Halpern Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://urldefense.com/v3/__https://wiki.ietf.org/en/group/gen/GenArtFAQ__;!!NEt6yMaO-gk!HnoMr9CvW2ImbH6LVeQkh-4CIMEuSojS_TOKsafTWXlzUP7cmGEeUOIn5afkDw9ceS4tFN9KrmjCnaQ$ >. Document: draft-ietf-bier-tether-04 Reviewer: Joel Halpern Review Date: 2024-02-15 IETF LC End Date: 2024-02-29 IESG Telechat date: Not scheduled for a telechat Summary: This document is almost ready for publication as a proposed standard Major issues: Section 3.1 on IGP Signaling states "The helper node (BFRx) MUST advertise one or more BIER Helped Node sub-sub-TLVs". However, I only find a vague outline of this sub-sub TLV. The code point for it is requested in the IANA considerations section, but the description is a single sentence easily misread and lacking the conventional diagrams and precision that is used to define routing TLVs (and sub or sub-sub TLVs.) zzh> Point taken. How about the following? Suppose that the BIER domain uses BIER signaling extensions to ISIS [RFC8401] or OSPF [RFC8444]. The helper node (BFRx) MUST advertise one or more BIER Helped Node sub-sub-TLVs in the BIER Info sub-TLV in the case of ISIS or BIER Helped Node sub-TLVs in the BIER sub-TLV in the case of OSPF, one for each helped node: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Type | Length | Priority | Reserved | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Address of the Helped Node | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ The Type is TBD1 (in the case of ISIS) or TBD2 (in the case of OSPF). The Value field starts with a one-octet Priority field, followed by a one-octet Reserved field, and then the Address of the Helped Node (X). The Length is 6 for IPv4 and 18 for IPv6 respectively. Minor issues: In the paragraph about multiple helpers helping a single non-supporting router, I think I missed how one case works properly. (Section 2, additional considerations, paragraph 6). The text says that the sending BFR (BFR1 can choose to use multiple helpers if they are available. Assuming that BFR1 chooses to use BFR2 and BFR 3 to reach BFRs 4 .. BFR N, the text is clear that this results in BFR2 and BFR 3 both sending copies of the packet to Router X. That is fine. It is load, but it is a tradeoff. However, it appears that both BFR2 and BFR 3 would send packets to BFR4, and to all the other BFR children of X. This results in duplicate packets in the rest of the tree. Is there some assumption I missed that prevents this? Zzh> The BIER forwarding algorithm ensures that the two copies of the same packet that a BFR sends out never have overlapping bits in the BitString. Therefore, no duplication will happen. Zzh> Thanks! Zzh> Jeffrey Nits/editorial comments: _______________________________________________ BIER mailing list BIER@ietf.org https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/bier__;!!NEt6yMaO-gk!HnoMr9CvW2ImbH6LVeQkh-4CIMEuSojS_TOKsafTWXlzUP7cmGEeUOIn5afkDw9ceS4tFN9KMmQkevA$
- [Last-Call] Genart last call review of draft-ietf… Joel Halpern via Datatracker
- Re: [Last-Call] [Bier] Genart last call review of… Jeffrey (Zhaohui) Zhang
- Re: [Last-Call] [Bier] Genart last call review of… Joel Halpern
- Re: [Last-Call] [Bier] Genart last call review of… Jeffrey (Zhaohui) Zhang
- Re: [Last-Call] [Bier] Genart last call review of… Joel Halpern