IETF Logo Mail Archive

Re: [Last-Call] Intdir telechat review of draft-ietf-sframe-enc-07

Richard Barnes <rlb@ipv.sx> Wed, 03 April 2024 12:41 UTC

Return-Path: <rlb@ipv.sx>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0D80C14F684 for <last-call@ietfa.amsl.com>; Wed, 3 Apr 2024 05:41:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.896
X-Spam-Level:
X-Spam-Status: No, score=-6.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ipv-sx.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Wi4uwrN6j50 for <last-call@ietfa.amsl.com>; Wed, 3 Apr 2024 05:41:42 -0700 (PDT)
Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C6259C14F71E for <last-call@ietf.org>; Wed, 3 Apr 2024 05:41:42 -0700 (PDT)
Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-369f986176fso327435ab.1 for <last-call@ietf.org>; Wed, 03 Apr 2024 05:41:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipv-sx.20230601.gappssmtp.com; s=20230601; t=1712148101; x=1712752901; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1m6oHKya8ZmAVeqYMFGF+NZhL7FPsK+bHKruMm2Vd2M=; b=wqyhvywAJbxoUrvDeEUtTicyydMLFUA8fQCogi6Z7OowkBKiPN5AlA7yzuerNxM0Jr X66JKbYbT36C0Yv/Hx49i/UI+P62msu+iZESkaVp8+doIZA9WIVn81P89Vu8Hm+DVwBP tieBwEN3aL2fY7kXTAEcVzTHgv9OYXwlO5Kly8SKbxMjBVGly72icGHIapwehK3x2T4x XWMMWzS68u5GQanJLO1DtAsJaPrzK724aPo8Te57qsw9VJJ/sTxilePZxuDWn+eQ9WvZ upTa82wHZcSFB6UzIb3ZDcqqqSaSZvm1sa3KiOohENQO1f5/OGPcD9l5S1uTtOVWH3B7 QLJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712148101; x=1712752901; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1m6oHKya8ZmAVeqYMFGF+NZhL7FPsK+bHKruMm2Vd2M=; b=BVBeuHArpKENImdZLHKv7HVjOwxitZLblgOA6gGQ1BZySNSD+pANnq4f2Lw7D+ET8q xDHZjo8CeHJuSQd6baEMXVljzNs0qoqaVGd5Vnxd7vMfbTSPbdz8QA3pu+O1h1OolkHo 5hdcnuEQSsDTVONSqwK0MaruEuINjSidRQVmzILekYSG2Fx/10ZCv6W3Pn8h1f+hjUw+ 6EZsEg5Swub6SUk6PvBMf4lE+CaeUaHY5j5fHPj9MILnwJI8rRbVeRLoR7KU8FpzOTzk JaXUDQ6ZzMrI+ibucXZIA+GA/2b0BoYhwbRnnOTaqtbB+On1dQZ+0GWiao/hu1ESJ2p5 luXA==
X-Forwarded-Encrypted: i=1; AJvYcCWdpONfHyrsmwVDYNGCFkIaxY4aYfQ6hH/vKF6PzVNBIN8Hn0CHy3CozwuOeDH1dCkwcjwi/tvLUVHYSkRpXR+oWmk=
X-Gm-Message-State: AOJu0YwOpcx9niHKfjYxSTpto+k0TsFvcNjr1WlyFlKBlb8gZBjyCozu 9YMZ0MO2oLdDRzWJlby/qKJKSMDCwKnlTcW2umCawlbQ8E9EDT5Tn/JtLpKiny4MgNdl+jjfk1z QmXcqAKQBkvLFqo+1K0w5ZbvHyIOlTVJG8IhdxQ==
X-Google-Smtp-Source: AGHT+IELdPlK8vOLOs3/lpQEV3UBYGZxr1/aWrBXvj5qLIWn8KGUm96nmsssPQQO1n/sU9+qCOWG5/tcho+9Rx9MtL0=
X-Received: by 2002:a05:6e02:17cb:b0:366:b889:4a90 with SMTP id z11-20020a056e0217cb00b00366b8894a90mr20261819ilu.4.1712148101640; Wed, 03 Apr 2024 05:41:41 -0700 (PDT)
MIME-Version: 1.0
References: <171172625624.49272.18301693085107891676@ietfa.amsl.com>
In-Reply-To: <171172625624.49272.18301693085107891676@ietfa.amsl.com>
From: Richard Barnes <rlb@ipv.sx>
Date: Wed, 03 Apr 2024 08:41:30 -0400
Message-ID: <CAL02cgS6OibVg+dB=pznERprwpJcPfLuwF_FU9obkkqXZGH+Fg@mail.gmail.com>
To: Suresh Krishnan <sureshk@cisco.com>
Cc: int-dir@ietf.org, draft-ietf-sframe-enc.all@ietf.org, last-call@ietf.org, sframe@ietf.org
Content-Type: multipart/alternative; boundary="00000000000066d1b60615308b37"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/071lGxy-UC46tP0JqD1hFZPjRsI>
Subject: Re: [Last-Call] Intdir telechat review of draft-ietf-sframe-enc-07
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2024 12:41:43 -0000

Hi Suresh,

Thanks for the review.  I filed a PR:
https://github.com/sframe-wg/sframe/pull/195

--Richard

On Fri, Mar 29, 2024 at 11:30 AM Suresh Krishnan via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Suresh Krishnan
> Review result: Ready with Nits
>
> I found the document well written and easy to understand. I did have two
> minor
> comments to bring up:
>
> * The draft seems to have a few (looks like Python) code blocks embedded
> in it.
> Consider enclosing them within <CODE BEGINS> and <CODE ENDS> markers to
> identify them as code components for licensing purposes.
>
> * The draft seems to refer to an obsoleted version of the SDP spec RFC4566
> which was obsoleted by RFC8866. Unless there is something specific in the
> old
> SDP needed for this draft, it probably makes sense to refer to the newer
> RFC.
>
>
>

v2.23.0 | Report a Bug | By Email