Re: [Last-Call] RtgDir Last Call Review: draft-ietf-idr-bgp-ls-flex-algo-09

Ketan Talaulikar <ketant.ietf@gmail.com> Thu, 18 August 2022 05:32 UTC

Return-Path: <ketant.ietf@gmail.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CC39C152588; Wed, 17 Aug 2022 22:32:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.104
X-Spam-Level:
X-Spam-Status: No, score=-1.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GGxGLqDVBZYP; Wed, 17 Aug 2022 22:32:43 -0700 (PDT)
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC446C14F74F; Wed, 17 Aug 2022 22:32:43 -0700 (PDT)
Received: by mail-ed1-x536.google.com with SMTP id z20so529401edb.9; Wed, 17 Aug 2022 22:32:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=wLlHhSNbFA+LxSVVSbU68BAX8jSxkyUsdfDVeFteIKg=; b=M0g8RD+4DBYm63HIbh53dmqBZGzB0opPX2N8XbjqYpHx/M0uLDViF4qatZC6uLq8QE si6k2+lXtuVL2sovb41VKdmqtLVbvO98TRBsD+N8Y6KzY5Cu9iMAD5GLzJlx7FdBdXfQ iJo8U0iWwVOwjXy7//6QnB0mtQfsFQ9Qh1+GN91PjkAxDZXPsi3laPVzqavrubVcFm3r yz9puBMh8965SinyZ7fLgUumWDezKv6TgeZeY1hbXG5wHqBB+McKKPhUttKF4RqYDquw uBLAxNxmb96NxTzyu+kfQ+Do/9hc/VXWaPzBW8ukT9YcMWt/xFLVFs95vA8wOMDd7Itb Pzyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=wLlHhSNbFA+LxSVVSbU68BAX8jSxkyUsdfDVeFteIKg=; b=sHsLyHXnqMFMO8Ayko1l0d+YKuweyh0mOtjO5zGG8WIe0WaL68/iwwvANqgs4AGAAS 0VdF7D4/nwZ4VAX2xlvh2mYufGa0HC5DcuvX1h9W7NojqQZDNXM6N96evxIuEV2CAyOm byIP2c1Ekmc+hAx2ktrJl/ijqYSyFXnAX/X025LFZvWM/gCIC36etHhWNIj4SGzaX/Vl KiV8gRHIXY37doVoReDj8fjOHHX3j88MWrZjLWVYhuUvZY0CImTqR+08veI4/drjEDkO OHtevp32LtXrKpnB0kNy9tmyyFhduNHzH9hIQgruj6F8/7p/l2tUT6b+7ayxPjHz553R EBYw==
X-Gm-Message-State: ACgBeo1FxtlwgSsktoXxcxpzxzi9Vi7+8YWIjE+stP4mNQM+UYjJ7Luj GyPaDL6A5jqwUB3GvwxaIhpIK8TX+A/iXor7gYe99KgmaLE=
X-Google-Smtp-Source: AA6agR5r5kcCk6ZIrh5AaaUCzvRameAWzvJOrud775ZCjj9h7pbWcqn9EFQ/nziFT8bOYY0VUTce+wFSmvc/3aQeeus=
X-Received: by 2002:a05:6402:1f8c:b0:43e:8fab:76c with SMTP id c12-20020a0564021f8c00b0043e8fab076cmr984710edc.126.1660800762191; Wed, 17 Aug 2022 22:32:42 -0700 (PDT)
MIME-Version: 1.0
References: <CAF4+nEGk0EDcNEQJ3p4YeZG9QCu91na18GJ2G96cKv=fhcto3A@mail.gmail.com>
In-Reply-To: <CAF4+nEGk0EDcNEQJ3p4YeZG9QCu91na18GJ2G96cKv=fhcto3A@mail.gmail.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Thu, 18 Aug 2022 11:02:30 +0530
Message-ID: <CAH6gdPxNwBAuNMzC7+x4c_CsN67iEHTCDmK70vwQZGdmpSiABQ@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
Cc: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>, rtg-dir@ietf.org, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, "idr@ietf. org" <idr@ietf.org>, Last Call <last-call@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000079249305e67d4f6c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/1QJfxdTBDNZnB1gszTYJV2aDKEo>
Subject: Re: [Last-Call] RtgDir Last Call Review: draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Aug 2022 05:32:46 -0000

Hi Donald,

Thanks for your review and agree with all your suggested edits for the nits.

These changes will reflect in the upcoming update of the draft.

Thanks,
Ketan


On Thu, Aug 18, 2022 at 12:40 AM Donald Eastlake <d3e3e3@gmail.com> wrote:

> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft.
> The Routing Directorate seeks to review all routing or routing-related
> drafts as they pass through IETF last call and IESG review, and sometimes
> on special request. The purpose of the review is to provide assistance to
> the Routing ADs. For more information about the Routing Directorate, please
> see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it
> would be helpful if you could consider them along with any other IETF Last
> Call comments that you receive, and strive to resolve them through
> discussion or by updating the draft.
>
> Document: draft-ietf-idr-bgp-ls-flex-algo-09
> Reviewer: Donald E. Eastlake III
> Review Date: 2022-08-16
> IETF LC End Date: 2022-08-17
> Intended Status: Proposed Standard
>
> *Summary:*
>
> This document is basically ready for publication but has nits that should
> be considered prior to publication.
>
> *Comments:*
>
> This is a straightforward and relatively easy to read document. The
> inclusion of the Flexible Algorithm Unknown sub-TLV is an interesting and
> useful detail. I found a number of nits.
>
> *Major Issues:*
>
> No major issues found.
>
> *Minor Issues:*
>
> No minor issues found.
>
> *Nits:*
>
> In Flexible Algorithm D/definition, the capitalization of "definition"
> should be consistent. I suggest it be capitalized.
>
> In abstract, suggest "propagated (viz. OSPF and IS-IS flooding) through
> the network" -> "propagated through the network by OSPF and IS-IS
> flooding"
>
> Section 1, top of page 3: "Flexible Algorithm is called so as" ->
> "Flexible Algorithm is so called because"
>
> Maybe it's just me but "leverage" seems to be an overly complicated word
> with a faint whiff of marketing about it. Suggest, in Section 1,
> "leverated" -> "used", "leveraging" -> "using"
>
> Section 2: Expand SRLG on first use.
>
> Reference to draft-ietf-spring-segment-routing-policy should be to RFC
> 9256.
>
> Global: "e.g. " -> "e.g.," (replace space after "e.g." with a comma) In
> some cases it might read better to replace "e.g. " with "for example,"
>
> Global: "ISIS" -> "IS-IS"
>
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
>  d3e3e3@gmail.com
>