Re: [Last-Call] Rtgdir last call review of draft-ietf-bier-evpn-08

"Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net> Fri, 14 July 2023 18:59 UTC

Return-Path: <zzhang@juniper.net>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7DF38C14CE27; Fri, 14 Jul 2023 11:59:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.798
X-Spam-Level:
X-Spam-Status: No, score=-2.798 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b="MWKciw9S"; dkim=pass (1024-bit key) header.d=juniper.net header.b="N5xGcx3Q"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKU64IGWQVdL; Fri, 14 Jul 2023 11:59:55 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D17D3C14CE2C; Fri, 14 Jul 2023 11:59:51 -0700 (PDT)
Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36EHDRWr028767; Fri, 14 Jul 2023 11:59:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=PPS1017; bh=EIYKOrGzA6wo2bj9PBE6KfJ1qdSLNS4JqpMgL2sblOc=; b=MWKciw9S/Yt9+qk9MeQ+2a6kdxoFvn2wgeG1b4BqU0nExxB36Tc045l5h1dqB9oiVfsU l6v5kK2O+O6/wmQJZYnBZWgW9/cYRAaVybLqx11JIHLZ8n4gBnx6GTdce92gv6ZCd08G 4RYt9lpc0Qmh5RXzryspMnxTMM7xmIrLwmTQs4pT0QvXnROOUaf0ZbiH3PfyNvHdiaLy OeelP7w2BB73ZCsiHciTgOYCiHuJ4yzAqlodhWU2VW0UreaPGZWtxYLAesO5KjE8bcLm ekhpyrBKDeuwNQm/3d90LVMJvhGRRdpyUT8I7RuGXDOb64+rgMHiN6Z3CVhIMz1J2FDg pA==
Received: from dm4pr02cu001.outbound.protection.outlook.com (mail-centralusazlp17012020.outbound.protection.outlook.com [40.93.13.20]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3ru7k08s0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Jul 2023 11:59:50 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NRcxcauhzsWd7l4xlLAPIQRjrWhEzrfqbhuU/5m+PHCFjqVHw0VeiKaYK9ZReXbGH2VlS6e112qvqfHFBUWkEggi2RY0Vz9h7Fuf7rfdpGnY9JG1PYohsGlPJG6kjvoadK58N2w4g/yFqMFhNyA7UxiWAoiz6KltEkZ21Gez8/GYGEiqfFo6HjQWCKhP3fZvCtZBZY6YZlB5yi+RkVPg7FeLbaV/8mAYDwXka7/YB0va99DgCX37GEOBQtAIJrcjoN9rMPrsJyxo5T/G8CBK6Kwpa6Wp5BR1XuXHOhN4OeaEgzwmi7AbLMtPhfBkWPRde+n8OvrsJurGEWPFwY9GVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EIYKOrGzA6wo2bj9PBE6KfJ1qdSLNS4JqpMgL2sblOc=; b=S6zzIfWZ6fLARWLa6wmFMKVtNTYHUC0XdHrhA/cBda5VjV0qoqfBeXDxcigr/PWGjrAWV3xUe0XiiBp0eSqjWXNMjT1Acanf5ZolHMpCrB084CAP8hNqIKQYpqgoC3Hgv19SfM4TKL6/AMDgJlK+vNWRKKrtmVrFD4eft4gbALzfSfgyANpXFEHBcO+5NuPHpERoEEY80L/rtliW+CC4nFbcglrl+X5CKSXZk8DRQRXPQ7h4BPFXBfgamJQq2Z2t7SaUcUPnLkWq794DJXzMpTrhm6DCfUSe/JgkR/srQoyiEDviKLcFHvTZsYaaKBijUDUPgzsD38Ui+kTNEO+cXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EIYKOrGzA6wo2bj9PBE6KfJ1qdSLNS4JqpMgL2sblOc=; b=N5xGcx3Q3H9ezvCZUHqkKJ1DtelgBuRZH4Yf8Jrwz9uIyCHlky4+QvHvlLLp3gt17mYwJx+NAJw94vVg6RWspc6D/E5QMRbxdGzRpTOUsuWBhQTNFINxUlWbcVts7+hFQ4IhjCOVUq13TofzxtIBNEkYqqEAtI1C2WJqaweWQ2w=
Received: from BL0PR05MB5652.namprd05.prod.outlook.com (2603:10b6:208:6a::19) by SA1PR05MB8094.namprd05.prod.outlook.com (2603:10b6:806:1a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27; Fri, 14 Jul 2023 18:59:48 +0000
Received: from BL0PR05MB5652.namprd05.prod.outlook.com ([fe80::6837:9e49:69f9:85cd]) by BL0PR05MB5652.namprd05.prod.outlook.com ([fe80::6837:9e49:69f9:85cd%4]) with mapi id 15.20.6588.027; Fri, 14 Jul 2023 18:59:48 +0000
From: "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>
To: Ron Bonica <rbonica@juniper.net>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "bier@ietf.org" <bier@ietf.org>, "draft-ietf-bier-evpn.all@ietf.org" <draft-ietf-bier-evpn.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Rtgdir last call review of draft-ietf-bier-evpn-08
Thread-Index: AQHZs2hOR0Y++vi52kW1RyOm8JRrNa+5Xd1Q
Date: Fri, 14 Jul 2023 18:59:48 +0000
Message-ID: <BL0PR05MB5652818CCF4C305D96BB3827D434A@BL0PR05MB5652.namprd05.prod.outlook.com>
References: <168901884801.22767.6000474985411586522@ietfa.amsl.com>
In-Reply-To: <168901884801.22767.6000474985411586522@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=86d07324-27ee-4369-b005-7c517668800c; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=0633b888-ae0d-4341-a75f-06e04137d755; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2023-07-14T14:49:07Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BL0PR05MB5652:EE_|SA1PR05MB8094:EE_
x-ms-office365-filtering-correlation-id: 2010e00b-314a-4c9b-6c0e-08db849c7f0d
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: eE0L4Os4XNIuXrr1GtB4KTyE/7CRDukrU503M2Jp36gxGxEd+a3XqYh6VLSnmcG0I4vUPXg8+M7w1O5keFx1pmZFn+N5OAMz8EiSIG9ruF1tTSthEz0sx9rM81loDKqYo9xb5IRT0scjgu5rbDb2vy00HLkrL5gBai2N9RQS7txheITPRcYvxqh9vOaB+tu27D/yWtJYSGRHUTETbqsiZ8F5B7O+YVHUMdbViOVXCx2W1aKRqzlM5Ow9O2+W8m98NEJDxT9gGTLQatQ7CcBSKmxplFBnGi9qZXV5bfY8GfMuN1cjvTJbXaQBd6GPWAu9B+FCZwMPP7nBuM/mokMQHa/FALGppd5+tU9XhiMXIbprUKDmzozUQh4gX72LjfntJW+f+aIa8MsNzLOtWQcZJMuxfCRJuRkTGNA3ye7+ZPKO+s/HwsVczMwGTkN3ECN2PV0iRws1AkLd12I3CfqfJ25ehElkUh25+TQF42Kgcs+aRoo/Hxw4HH/lp9cNBf6+eWJhzokoCvTK0IMMfpxKqk4EQyzCCKk1vuNxWJ7eoUnA3JBm4iZ5O1TATWhjU519Mbl4iwhSeAiPuLb14BTCXeHj+/IPcnJHMnTMZVWYEhxbiCBpFqa3P7ie7rHcKg5Mv7To+dyiGWh3p3lKQAbl4kWQW2bRZZ5ijgRj+ZAL8Oo=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR05MB5652.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199021)(450100002)(316002)(66446008)(64756008)(66476007)(66946007)(66556008)(76116006)(186003)(54906003)(478600001)(41300700001)(110136005)(4326008)(71200400001)(7696005)(9686003)(8676002)(8936002)(53546011)(6506007)(86362001)(55016003)(52536014)(5660300002)(26005)(33656002)(2906002)(83380400001)(122000001)(38070700005)(38100700002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: SB+sNAw/diYptEJHV3FyBpLp6ePpPNMKdB/1ZoFfPReF/U57wx2NYcg1TZ0QhZUPOxpQ81p0EKdhaHGctA3LEHP5/TbR3/gAritFQNBXVbHwxKE6CmHtl5maxEHbrm5MLPyGJWufpRJEcrvRc764UfbcIw4nvE4lTCtKI7gkjNJ8Uy53aCuIunDQderqGo1kwISek0qq+IuDVLLObay9cZs2GKbIn36KbGEd3Ac+Ux+qQrdNNDn0xiTrAzAtRZj8dZ9qgSCRRaqUckEN8R/HYm48iI5btdc7e2DaiA1uQnK2+HVJS+H2asUkGx4TrQKkIeExnOFXvZov6Y/SsWpjSeNczyOYudDhoeYhNcyMBvztXF98Y5+GIe5aAQq8HWfDIvEOWXfn+YDO2teZMRQYju2+vg9YOsHeMDoFi3fCMjfdwdEG1GVmAl0ok+ZHNmFxHudSGx2lTCvXPyJVXJ7zcCkTXy19guBXXhiaQeMB6S09OhPDVGhEItPEu2Ta+wvg/x8TUGR609erRcCWBoD/JOS5E5R8Z1SNotniKY2SO5Cap71uq3cHi5ue9K8WAdFQ3DobK+S/UMOnwhX6mfbXgcu5fKYT5gt6bYmGBmV5+Kjk6+oVL1pMb2ABDS+chMzxq2QvAfgI2z1uUACtHupulUsyVzJ/dLP1xCyDTg5ajw9RyC2+MFI4fq5k6Ki659NjQeZZ7tHH4PQvqBbGhiefmC8J9gmag0P86AKCwQNeP+4InLXj2gNWpaXFXhPzQGjpr57TyPhqSQ3boZNovdFZDdPJtIDU43krD6OaU5Nwxg5uhJVjaYJ3QMk+b9Z5BVysj+xa+5CN2A940K08K97YiG4nEKnq0xE1CNvF/14yY10nz8BjMDqTUAxt9lNJo3qyN4umxUscltFsT8Ps4xZ/GQkgRMQuFF2T1BTzIpjUpgNZvuocBBHJdjJplmBSs5SCECxiQW6GUfCe0Fr6G8xvmuFzpE0auy+TI6H5sTFNYCa/SAuXvszk2Dwy2/n8JBay6x5URuJIm5zchzVbUN8r3dWOJi6Mz/iKcQBEqg/PdicY1V1Fm3OrX1T/Im3V7Hx3Lzrok2JVARK7BAERMR0531BXr+CbB06D3Df9N8BEmV1uiY3mp4OUF0wdJ74bi3PvhdgI4STbjaUnYiI8+IbyAaVMGd9EbvmIj1o+Qt8BMAfsJNeFMV5FIZjGYMJCOnSncEjTHZd7qo1cCOaiR4NwfA29VlcHreMY5DxI2X4CK8mS+p19qPZqu5dTfDKHvg1qcXTx/LvYhXGbFixOJ0qM2xrx30NQkOGsFeiiOaXuVbUH7409LAHREUOvS5scikhXfU1CE+oBYux7aaMuhlh6zrAIgwTI0XR0tY7IlBrdSd9WRfzzGoTH7FteVGn3/7d6zqG3xKpHU1papc5UzcZZBAZmd/zfqXl4w5g40TP+bcE4FvVNXj5y6Jl0MTVsGEmHJnX9JG1r0Lqm6y27GHHhhefQBGAJNV4P1tq/CkUbU+jtYCw0KusQq89hEp4R9Nsn4VqlReo1cAKEr/byo6u7qfIEmK2do0DmyPfM8lMP7XEfw/SplWDWPcS1hI5qbre+
Content-Type: text/plain; charset="utf-7"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5652.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2010e00b-314a-4c9b-6c0e-08db849c7f0d
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2023 18:59:48.4367 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UNXHeBihgCp4VBxVOoePWEFXEiFn9xjJ+dPWc5e3OeMO72T6V3hXTt3NohAZYMUHiiK5G5rIFc+4SxCk86Iieg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR05MB8094
X-Proofpoint-ORIG-GUID: qNwwl1DoPtOM0maS6C_iGuZyOjRV-DMS
X-Proofpoint-GUID: qNwwl1DoPtOM0maS6C_iGuZyOjRV-DMS
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-14_10,2023-07-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1011 priorityscore=1501 mlxscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307140174
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/538OwLKv_IBO8Zdz8ZIO6LdY2JE>
Subject: Re: [Last-Call] Rtgdir last call review of draft-ietf-bier-evpn-08
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jul 2023 18:59:59 -0000

Hi Ron,

Thanks for your review and comments.
Please see zzh> below.


Juniper Business Use Only
-----Original Message-----
From: Ron Bonica via Datatracker <noreply@ietf.org>
Sent: Monday, July 10, 2023 3:54 PM
To: rtg-dir@ietf.org
Cc: bier@ietf.org; draft-ietf-bier-evpn.all@ietf.org; last-call@ietf.org
Subject: Rtgdir last call review of draft-ietf-bier-evpn-08

[External Email. Be cautious of content]


Reviewer: Ron Bonica
Review result: Has Nits

This draft is ready for publication, but has a few NITS:

The draft includes more than a few grammatical errors. I will not call out each. Please run a grammar checker over it.

Zzh> I pasted the text into Word and it flagged a few and I fixed them.
Zzh> What tool do you normally use? I want to make sure I fixed all (especially the grammar ones besides the typos).

Section 2:
 "Tunnel Type".  The same codepoint 0x0B that IANA has assigned for [RFC8556]  for the new tunnel type "BIER" is used for EVPN as well."

  This sentence needs to be reworked (e.g., for [RFC8556] for)

Zzh> Would the following work?

   *  "Tunnel Type".  The same codepoint 0x0B that IANA has assigned for
      BIER for MVPN [RFC8556] is used for EVPN as well.

""Tunnel Identifier".  When the "tunnel type" field is "BIER", this
      field contains two subfields.  The text below is exactly as in
      [RFC8556]."

   When is the tunnel type not "BIER"?

Zzh> The tunnel type could be others like P2MP, PIM, etc.. But this document is for BIER - I changed the text to the following:

   *  "Tunnel Identifier".  This field contains three subfields for
      BIER.  The text below is exactly as in [RFC8556].

   Two subfields or three?

Zzh> Three 😊

6. Security Considerations

How do you know that this protocol does not introduce new security consideration. If you don't tell me how, I will just have to take your word for it. One or two sentences explaining how you came to this conclusion might help.

Zzh> How about the following?

   This document is about using BIER as provider tunnel for EVPN, and it
   is very similar to using BIER as MVPN provider tunnel.  Therefore, it
   does not introduce additional security implications beyond what have
   been discussed in EVPN base protocol specification [RFC7432] and MVPN
   using BIER [RFC8556].

Thanks!
Jeffrey