Re: [Last-Call] Opsdir last call review of draft-ietf-dots-signal-filter-control-04

Benjamin Kaduk <kaduk@mit.edu> Tue, 16 June 2020 15:06 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1B823A0DE1; Tue, 16 Jun 2020 08:06:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BMHsRQnRJdRs; Tue, 16 Jun 2020 08:06:54 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 729B63A0DDE; Tue, 16 Jun 2020 08:06:54 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 05GF6n9S024771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2020 11:06:51 -0400
Date: Tue, 16 Jun 2020 08:06:48 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: Tim Chown <Tim.Chown@jisc.ac.uk>
Cc: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>, "draft-ietf-dots-signal-filter-control.all@ietf.org" <draft-ietf-dots-signal-filter-control.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "dots@ietf.org" <dots@ietf.org>
Message-ID: <20200616150648.GT11992@kduck.mit.edu>
References: <159223370986.12685.10672338283953567887@ietfa.amsl.com> <11378_1592286685_5EE85DDD_11378_313_1_787AE7BB302AE849A7480A190F8B9330314DEC67@OPEXCAUBMA2.corporate.adroot.infra.ftgroup> <0006AA12-CF04-49CC-AEED-35D2B5EA6BD0@jisc.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0006AA12-CF04-49CC-AEED-35D2B5EA6BD0@jisc.ac.uk>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/AxqvOhhjK2YdIkdO3yfvrzTwbfU>
Subject: Re: [Last-Call] Opsdir last call review of draft-ietf-dots-signal-filter-control-04
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2020 15:06:56 -0000

On Tue, Jun 16, 2020 at 02:57:18PM +0000, Tim Chown wrote:
> Hi,
> 
> Some comments on your comments in line….
> 
> > On 16 Jun 2020, at 06:51, mohamed.boucadair@orange.com wrote:
> > 
> > Hi Tim,
> > 
> > Thank you for the review. Much appreciated. 
> > 
> > A candidate version that takes into account your review is available at: 
> > 
> > https://github.com/boucadair/filter-control/blob/master/draft-ietf-dots-signal-filter-control-05.txt 
> 
> [TC] what would be great is a diff to the version I reviewed.

Try
https://www.ietf.org/rfcdiff?url1=draft-ietf-dots-signal-filter-control-04&url2=https://raw.githubusercontent.com/boucadair/filter-control/master/draft-ietf-dots-signal-filter-control-05.txt

-Ben