[Last-Call] Opsdir last call review of draft-ietf-lamps-ocsp-nonce-update-05
Susan Hares via Datatracker <noreply@ietf.org> Tue, 09 April 2024 19:15 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: last-call@ietf.org
Delivered-To: last-call@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 36615C14CE4B; Tue, 9 Apr 2024 12:15:15 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Susan Hares via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-lamps-ocsp-nonce-update.all@ietf.org, last-call@ietf.org, spasm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.9.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171269011520.2420.5933358132842531673@ietfa.amsl.com>
Reply-To: Susan Hares <shares@ndzh.com>
Date: Tue, 09 Apr 2024 12:15:15 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/C-DTwVPYcpAbJkIU6qXT3yRf0vw>
Subject: [Last-Call] Opsdir last call review of draft-ietf-lamps-ocsp-nonce-update-05
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2024 19:15:15 -0000
Reviewer: Susan Hares Review result: Has Nits Status: Ready with NITs General Statement: Excellent writing and clearly understood by a novice. I enjoyed reading the clear ASN.1 syntax in the appendices. operational summary: The key point is that Clients switching from [RFC8954] to [draft-ietf-lamps-ocsp-nonce-update-06] will want to use a nonce of length 32, and accept an OCSP of 16 octets. 4 NITS: Main Text (1) Appendix A.1 (1), and Appendix A.2 (2). Note that NITS are editorial suggestions. 1 NITS in Main Text: The example in section 2 starts with 30 2f 06 09 2b 06 01 05 05 07 30 01 02 [hex] Sequence (30) length (2f) { OBJECT Identifier (06) length (09) oscpNonce (1 3 6 1 5 5 7 48 1 2 ) It might be good to explain that (1 3) is the 2b. ------ #2 NITS in ASN.1 in Section It would help the ASN.1 reader to explain in a comment associated with the first usage of "generalizedTime" the format of the generalized time. It is a well-defined ASN.1 concept, but the reader is assumed to be an IETF reader with less experience in ASN.1. ------ #NIT 3, use of ATTRIBUTE as an import. In my review of the ASN.1 in Appendix A.2, I cannot find a usage of ATTRIBUTE. If it is not used, why is it included? ----- #NIT 4, use of @amp; ResponseBytes ::= SEQUENCE { responseType RESPONSE. &id ({ResponseSet}), response OCTET STRING (CONTAINING RESPONSE. &Type({ResponseSet}{@responseType}))} AcceptableResponses ::= SEQUENCE OF RESPONSE.&id({ResponseSet}) I am not familiar with "&id" or "&Type" or @response. Please add a comment with the ISO reference for this syntax. If you wish to be helpful to the reader, it would be to explain what this syntax means.
- [Last-Call] Opsdir last call review of draft-ietf… Susan Hares via Datatracker
- Re: [Last-Call] [EXTERNAL] Opsdir last call revie… Himanshu Sharma
- Re: [Last-Call] [EXTERNAL] Opsdir last call revie… Susan Hares
- Re: [Last-Call] [EXTERNAL] Opsdir last call revie… Himanshu Sharma