Re: [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06

[tom petch <[e-mail]>]

Paul

Some admin comments on -07; I think that you need to:

- change the title in YANG revision reference

- add to the I-D references
RFC959
RFC8632

- shorten lines. There is a limit to line length in RFC as per the Style 
Guide.  This is exceeded in the YANG where some of the path statements 
take it over 80 while some of the examples are over 100.

- add a reference for the import of
ietf-i2nsf-policy-rule-for-nsf

HTH

Tom Petcb

On 01/04/2021 03:09, Mr. Jaehoon Paul Jeong wrote:
> Hi Andy, Linda, and Yoav,
> Patrick and I have addressed all the comments from Andy.
> Here is the revised draft -07:
> https://tools.ietf.org/html/draft-ietf-i2nsf-nsf-monitoring-data-model-07
>
> I attach a revision letter to explain how we addressed the comments.
>
> There are the major updates in this revision as follows:
> ---
>     o  This version is revised according to the comments of Andy Bierman
>        who is a YANG doctor.
>
>     o  This version updates its title as "I2NSF NSF Monitoring Interface
>        YANG Data Model".  It clarifies the NSF Monitoring Interface to
>        deliver NSF monitoring data to an NSF data collector (e.g.,
>        Security Controller and NSF data analyzer).
>
>     o  This version adds an attack destination IP address for DDoS-attack
>        event to provide an NSF data collector with more information about the
>        destination of DDoS-attack packets.
>
>     o  This version supports a notification for monitoring traffic flows
>       to detect the source and destination (as a victim) of security attacks
>       such as DDoS attack.
> ---
> If you have questions and comments, please let me know.
>
> Thanks.
>
> Best Regards,
> Paul
>
>
> On Wed, Mar 24, 2021 at 3:34 AM Andy Bierman via Datatracker <
> [e-mail]> wrote: