Re: [Last-Call] Genart last call review of draft-ietf-stir-passport-divert-07

"Peterson, Jon" <jon.peterson@team.neustar> Mon, 13 July 2020 14:37 UTC

Return-Path: <prvs=8463aa7b49=jon.peterson@team.neustar>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7732A3A125E; Mon, 13 Jul 2020 07:37:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=team.neustar header.b=ehJ7ZZ2B; dkim=pass (1024-bit key) header.d=neustar.onmicrosoft.com header.b=rdWPYMjs
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6YCHL_P1pp25; Mon, 13 Jul 2020 07:37:20 -0700 (PDT)
Received: from mx0b-0018ba01.pphosted.com (mx0a-0018ba01.pphosted.com [67.231.149.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 092133A1265; Mon, 13 Jul 2020 07:37:16 -0700 (PDT)
Received: from pps.filterd (m0078664.ppops.net [127.0.0.1]) by mx0a-0018ba01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06DEZjPd026007; Mon, 13 Jul 2020 10:37:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=team.neustar; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=team-neustar; bh=Re3cJWpnrNTjYzEj2yrTN6FqeMlfIEOhxKFqV7noxxA=; b=ehJ7ZZ2BI9pteqZ3Y0LypljneN7LUnkDCWMscV1jYIY85MBJpULsKxmkxQkwkqw4fU3Q 2t+r1wCwxSZ1VKgHIlTMPCbz1XDxOebEihxuCT3ArHBaZVKthUlRyIjFGnNF7kRY75/n KR6WU+I9tjO3tKVqDfYVXQOudXFufw2i3cAmM/ly+/Fq8FyU1403bGR7c/rcN3pertxQ Ak1dAroOcoMg2n5PmM9fRLrBJ5MNPQS6Tw1YjTglEZn+N/967KixAM8smRwHklrkAoqv tVqtPKutKTDu3rdKpWNiCubprM6TOR2SLNcWlsa13nbi8ICmNEwzvJQzfUcSMK3WqW3j bw==
Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by mx0a-0018ba01.pphosted.com with ESMTP id 32782y077b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jul 2020 10:37:06 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XFBhdkQqPLfPTJK+U3asXINm2ayg/ykm/elLCydiL2xWntL/PGVeeI0YtL9FF3/jw8GkbecKA6N2oQTpyiqASEwhUVUxDl+IcISoKW9pM0eAytq0/mgFNLA9hZOwr6A8UgUgLzMZDDpdKUdN0qB+EQim0WKEgGh0s6oqMw/urWREw5oBNup6/TerjjPpGVI0KX14SSPQ55KmBSOuw9vkyyYeB72mpRfHyjz4Br8G/yZWWiXJ2EWL3LgmKkBj5z8EGJ3IWKrdwgXq2gxTGL12DcAJm6FL/64rpgHeTJQVi94YuncBHK2X4Rx2w9XdymaxBciAZlByCdvEOm+9fwUgIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Re3cJWpnrNTjYzEj2yrTN6FqeMlfIEOhxKFqV7noxxA=; b=aouAy3538ms5YvfKkBhC2lbpttAhNrYlOohhrJpg2qsPFRNJPux//FSrW/rPPRm70tu9z5XpNfT4xstAcBQTpW9a92PE6urTd/Iu2Ouf4CgyuRZaDaZAqeo1uGRFhEnEveezZRSNwCRjYTsCRrnvPDgpalx1ulAKYrJEXnB7nCC79yArYeGGwszfOWHOm4X+tku/Ii32VMd8BG6+7q0Il4mmXUaO8jz7C6bA+3+zCd7tfmupBdyZkCu2N37u73joDZqJHKIL7BDT8h0xxWK0anZDtkzHd2YW7uZ7FwCz/2BWAu66STJlSPywhGqdIci6Q8aVRaD6f4yFKzCfKlvuhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=team.neustar; dmarc=pass action=none header.from=team.neustar; dkim=pass header.d=team.neustar; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neustar.onmicrosoft.com; s=selector1-neustar-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Re3cJWpnrNTjYzEj2yrTN6FqeMlfIEOhxKFqV7noxxA=; b=rdWPYMjsD7gepo4Fl6lNgUU8FXoJkNOQHEOy2OpJMDO2paSIccleNS5oO/QeMs0hU0aUTiHMFg5dcCHKIPpFPTqAcAj/aYhMpfRMWn0QxCGGaEeBLmv+zQXZSOnJBxeq6862YK9NTiuzfZl0Xi286FVL/GqLh29b6adUBk7G6t0=
Received: from BY5PR17MB3569.namprd17.prod.outlook.com (2603:10b6:a03:1b9::20) by BY5PR17MB3729.namprd17.prod.outlook.com (2603:10b6:a03:238::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Mon, 13 Jul 2020 14:37:01 +0000
Received: from BY5PR17MB3569.namprd17.prod.outlook.com ([fe80::503b:2ce0:8d8b:6b15]) by BY5PR17MB3569.namprd17.prod.outlook.com ([fe80::503b:2ce0:8d8b:6b15%5]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 14:36:59 +0000
From: "Peterson, Jon" <jon.peterson@team.neustar>
To: Pete Resnick <resnick@episteme.net>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-stir-passport-divert.all@ietf.org" <draft-ietf-stir-passport-divert.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "stir@ietf.org" <stir@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-stir-passport-divert-07
Thread-Index: AQHVx3m0mcGRmKiQJEu0tGGHmpn9vKkGQdMA
Date: Mon, 13 Jul 2020 14:36:59 +0000
Message-ID: <A9875C0D-30E4-4B30-9EC8-CAF68E576359@team.neustar>
References: <157863541224.17236.16527868532167283650@ietfa.amsl.com>
In-Reply-To: <157863541224.17236.16527868532167283650@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.17.200615
authentication-results: episteme.net; dkim=none (message not signed) header.d=none;episteme.net; dmarc=none action=none header.from=team.neustar;
x-originating-ip: [2600:1700:2ec0:8108::a]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 228fa5f5-4472-4e18-ea59-08d8273a3355
x-ms-traffictypediagnostic: BY5PR17MB3729:
x-microsoft-antispam-prvs: <BY5PR17MB3729BAE137BC7A6D356A1688E2600@BY5PR17MB3729.namprd17.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: frH91FJmXg/d2zKGP7Jw0T9/hfRDZmMjuw94heq5waNteQKqfjuirENU2vjv5Craykt61/NOPFQ5ri4jmf0D6nml5Npl/bRcTva6mXrbUK35d1omM/prPqOtSNlBUj2l7Rd/jLwT5JWEK9UA8DkKV7QZUZagrCiZMa//CrKe8kyIVHN/P/IUDj4AY6RbBmBEh6uEhg+1DuGlCkIhpOGRsC2qwahIpOhGe7P5GMW2eLiisbYSCebFXF+6QgzpKdL2E8mjxIXO/uprgS+0IL50CCIpigQfIl3KbE7kuT1WvbZO8DZ1vKIqdeBB3FaxGDKOjOmM4RnsG/MVp5Af9XYVPwFzmFKLIWN56yjocziRLv/Wu9nNpM/Zfng0xubyvSas
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR17MB3569.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(4326008)(8936002)(66946007)(64756008)(66446008)(66476007)(66556008)(110136005)(86362001)(5660300002)(54906003)(2906002)(2616005)(33656002)(71200400001)(6506007)(186003)(316002)(6486002)(6512007)(8676002)(76116006)(478600001)(46492007); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: a7JX8cA7nww9CZPfkfvrFXgG4UUPF2qwiWY92bulnIN28ACBqrm4dKlagt1scho7dgYm/gDVwaIgGNfJMBJdCnIeAHJYohiFExJ2cM6yLPfrMZiVIcbu/5Il2fRcB1HFMtLxc+S1iktHst0D6fwjryBfR2epIN2w1kg9gH2a5WT+GUDDBQ2ntwTvz0DnrCCsG+yeVHiisZyz1Cs5AMjb49G2JUM70MLUVEwD+hUvNvqYo44kqxeqeAIcjX8Mzu/HBdPG7l5lF5do/PVw/8caIfZTrtCVgzyrIo+A7y+uOra4qJTF0CCqjvAYXPGgtlQm3U8nSEnJHdIT+znMzl43TIw9mnTRsAfSrvOFeVlDGrkcJYVJ7tCB6eJdSwmIQSho16ysZ6V12Z9gdiJNaV8rE0TesRTtb1Zd3LyA9wiJfFDd9zGRmShxcwUklhHa61EK+S3M+gQhjhExMnxUmhzNiyn41QtERFj/cJgnulO7vOjzWTh5yz3rrsoF+l/tj+8fzXugHAqRK2lTV5vk4HeaWw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <6A460503ECFC9E48AEB76A65FFA9EF23@namprd17.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: team.neustar
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR17MB3569.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 228fa5f5-4472-4e18-ea59-08d8273a3355
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 14:36:59.4580 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 73a2bbc1-f307-47c4-8f94-5f379c68bc30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GrKjqURWAv+v6h/YkrvY1XYSrJV1Yj2T7pCgxTr0VWqT+9MkqAWWpIvQoEFvh1dyDEycDKD9bT67oF1/hBcfADkeNe/k3Kp73hjOpmt10bk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR17MB3729
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-13_14:2020-07-13, 2020-07-13 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1011 mlxlogscore=999 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007130110
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/MP1ok2v5hzgLUlA1eOgs7MJ_N7U>
Subject: Re: [Last-Call] Genart last call review of draft-ietf-stir-passport-divert-07
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 14:37:21 -0000

Thanks for these notes, Pete. I incorporated these fixes into the -08 (but apparently neglected to write and say so at the time).

Jon Peterson
Neustar, Inc.

    Document: draft-ietf-stir-passport-divert-07
    Reviewer: Pete Resnick
    Review Date: 2020-01-09
    IETF LC End Date: 2019-12-02
    IESG Telechat date: Not scheduled for a telechat
    
    Summary: Ready with Nits
    
    While I found the document (and particularly section 4) very technically dense,
    I think the detail will help implementers tremendously. Nothing other than a
    few editorial issues.
    
    Major issues: None
    
    Minor issues: None
    
    Nits/editorial comments:
    
    Section 3, paragraph 1:
    
                                                                   Note that
       a new PASSporT is only necessary when the canonical form of the
       "dest" identifier (per the canonicalization procedures in [RFC8224]
       Section 8) changes due to this retargeting.  If the canonical form of
       the "dest" identifiier is not changed during retargeting, then a new
       PASSporT with a "div" claim MUST NOT be produced.
    
    Seems to me that these two sentences should be in their own paragraph. It took
    me a second to figure out that the following sentence was not related to these.
    
    Section 4:
    
       ...Other using protocols of PASSporT
    
    Don't you mean "Other protocols using PASSporT"?
    
    Section 4.2, paragraph 2:
    
    I think you mean "necessarily", not "necessary"