Re: [Last-Call] Opsdir last call review of draft-ietf-core-echo-request-tag-11

Carsten Bormann <cabo@tzi.org> Tue, 01 December 2020 00:22 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2AF633A12AC; Mon, 30 Nov 2020 16:22:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.92
X-Spam-Level:
X-Spam-Status: No, score=-1.92 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D7j_i9kb-GeE; Mon, 30 Nov 2020 16:22:48 -0800 (PST)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B6F03A12AB; Mon, 30 Nov 2020 16:22:47 -0800 (PST)
Received: from [192.168.217.118] (p548dca87.dip0.t-ipconnect.de [84.141.202.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4ClN9022HkzyTl; Tue, 1 Dec 2020 01:22:44 +0100 (CET)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <160677720227.31587.6421946105112933351@ietfa.amsl.com>
Date: Tue, 01 Dec 2020 01:22:45 +0100
Cc: ops-dir@ietf.org, last-call@ietf.org, core@ietf.org, draft-ietf-core-echo-request-tag.all@ietf.org
X-Mao-Original-Outgoing-Id: 628474965.345865-55a8d920fb97e13c311db34f5516b5ba
Content-Transfer-Encoding: quoted-printable
Message-Id: <03FA6734-BD39-4B6A-AD3A-2910325548D8@tzi.org>
References: <160677720227.31587.6421946105112933351@ietfa.amsl.com>
To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/SqsZYmJbOn-oc8-J2eKO08v5CkI>
Subject: Re: [Last-Call] Opsdir last call review of draft-ietf-core-echo-request-tag-11
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2020 00:22:52 -0000

Hi Juergen,

thank you for this review.  I was intrigued by one of your nits:

> - The number of 152 bytes mentioned in section 2.4:

I think you are discussing this paragraph:

       *  Amplification mitigation should be used when the response
          would be more than three times the size of the request,
          considering the complete frame on the wire as it is typically
          sent across the Internet.  In practice, this allows UDP data
          of at least 152 Bytes without further checks.

I think this is trying to say that responses of 152 bytes are not requiring amplification mitigation under this rule, so there seems to be an assumption that the request would have been about 152/3 ~ 51 bytes, which is close to, but smaller than an 40-byte IP, an 8-byte UDP, and a minimal 4-byte CoAP header, which is 52 bytes, but then there are Ethernet headers and trailers, making the request 70 bytes (or 50 bytes for IPv4, which then becomes the minimum Ethernet frame of 64 bytes).  The maximum response would then be 3*70=210 bytes on the wire, minus 18+48 bytes Ethernet/IP/UDP, leading to 154 bytes “UDP Data”.  I don’t know.

>  3*152 would be 456 octets, I am not sure why this is the "typical
>  size of a frame on the wire sent across the Internet”.

Typical size of the frame (or packet?) of the request, not of any packet on the Internet.

I’m sure this could be phrased in a way that is a bit easier to follow.

The number to be explained is not so much the 152 (the exact value of which I don’t really understand), but the three.

> Either
>  explain how you obtained this number of consider removing it in case
>  it does depend on assumptions that are not guaranteed to be always
>  true. One option could also be to simply drop this sentence.

Indeed.

> - The difference between Figure 2 and Figure 3 is rather subtle.

Very subtle.  “Cthulhu!” vs. “Comic Sans” (and t vs. e).

Grüße, Carsten