Re: [Last-Call] Genart last call review of draft-faltstrom-unicode12-03

Patrik Fältström <paf@netnod.se> Sun, 28 November 2021 14:07 UTC

Return-Path: <paf@netnod.se>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 283243A08B6 for <last-call@ietfa.amsl.com>; Sun, 28 Nov 2021 06:07:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=netnod-se.20210112.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LHMnxFZIkV7M for <last-call@ietfa.amsl.com>; Sun, 28 Nov 2021 06:07:14 -0800 (PST)
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8312D3A08B8 for <last-call@ietf.org>; Sun, 28 Nov 2021 06:07:14 -0800 (PST)
Received: by mail-lf1-x130.google.com with SMTP id u3so37485717lfl.2 for <last-call@ietf.org>; Sun, 28 Nov 2021 06:07:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netnod-se.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=8A9DMUKA3MVtRd70ORrmf+PdG0c5VA3fo9vq05m7V1A=; b=vX7Vp9l3GJ9s83QDZIR8VdLQ5piIRRrH5sV7WpCLjp26qZaHoS8nWmAEQdAH2dQrgJ Xp501rNCEj6B4FTMyAKI9WwqccAaWvwPeanl+ousG9Ko1XW+nj8v9bSsRLJuGYE837rX QEMVMD5rjwgaqwol91yfah5af20Bew7pPWslu0G2Jve1ZAwOH6Fvqo1bv8jDcwoDLlQq treJL7UmzJz2y3O1jtWHsWkV4vluAHR+nkZEd5nwUZrPt2YdCbSvaSVvOpWscnkgVVUW BxP1tpj03oeF+oM+PBTiUnl36OTqINiL4fD4tB+vtYpt8rtUBym234mOdlCcGH9SI9S7 1ylQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=8A9DMUKA3MVtRd70ORrmf+PdG0c5VA3fo9vq05m7V1A=; b=KoT77WBkF2ntUV7wc6eI0LVOeYLgYTOV3IDEJB1M4vtG/IdSbdTfB4hSoocMV001+i PU35l4FmmxwUMjcOjc8We4+EWKW+dL6U1LhBBP+FWvMX8FXnYS/at1WieY9fOB5tIPgo EEpRWGPaRlTyVkGIJcLXPA7nNtbgyeBETBWUrdKVvTGgxZ/KOPGq7QQujt8KlfLC90bc n8K4NFzPBUuejoUqGLlE2Pa8Sc7FEXXvQjfN1utmizALq0yyJppTQeFD1Ew7Zty/3xKr hcv21dQzoSKG40TEWi91yhIDVMz1kb0IKkX1ejkuiDNLzuszoLBMzfUz+pyNLnwk7jH3 EpUw==
X-Gm-Message-State: AOAM5318zI8nftXsY+zdyK2/WsY8QgkJcwNFe9/D315sGl7oHJ9mV5X0 aGMUnI+UV/2WiY346c5EVPfZmA==
X-Google-Smtp-Source: ABdhPJxCFmExGIlyMpiumgii9jOhupXaQSzfXDqVxxprS11OybiWswGZPJ84CyP+F8limtGb7ZMIlw==
X-Received: by 2002:a05:6512:238d:: with SMTP id c13mr42303314lfv.350.1638108426959; Sun, 28 Nov 2021 06:07:06 -0800 (PST)
Received: from [192.165.72.223] ([2a02:80:3ffc::22]) by smtp.gmail.com with ESMTPSA id r3sm1003563lfc.169.2021.11.28.06.07.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Nov 2021 06:07:05 -0800 (PST)
From: Patrik Fältström <paf@netnod.se>
To: Russ Housley <housley@vigilsec.com>
Cc: gen-art@ietf.org, draft-faltstrom-unicode12.all@ietf.org, last-call@ietf.org
Date: Sun, 28 Nov 2021 15:07:03 +0100
X-Mailer: MailMate (1.14r5845)
Message-ID: <C60F8E71-43CC-4467-8A8B-9A600D65CBA4@netnod.se>
In-Reply-To: <163424380422.30664.6295894825173486352@ietfa.amsl.com>
References: <163424380422.30664.6295894825173486352@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=_MailMate_A4F89CF2-44AD-4F49-92DE-EBAE42B81342_="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/UP_YWHTf7u4QWeeW7A8z9Ys1tgI>
Subject: Re: [Last-Call] Genart last call review of draft-faltstrom-unicode12-03
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Nov 2021 14:07:20 -0000

On 14 Oct 2021, at 22:36, Russ Housley via Datatracker wrote:

> Reviewer: Russ Housley
> Review result: Almost Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft.
>
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> .
>
> Document: draft-faltstrom-unicode12-03
> Reviewer: Russ Housley
> Review Date: 2021-10-14
> IETF LC End Date: 2021-11-16
> IESG Telechat date: unknown
>
> Summary: Almost Ready

Updates done based on this review.

> Major Concerns:
>
> Section 4 says:
>
>    ...  As including an exception would require
>    implementation changes in deployed implementations of IDNA20008, the
>    editor proposes that such a BackwardCompatible rule NOT to be added
>    to IDNA2008.  This also ensures all sandhi marks being treated in an
>    equal way.
>
>    The IETF has decided to NOT add a BackwardCompatible rule to IDNA2008
>    (i.e.  Section 2.7 of RFC 5892 [RFC5892]) for this code point.
>
> This document is implementing the recommendations (assuming that the IETF Last Call confirms there is consensus).  So, this sentence should reflect that as a way forward, not a recommendation.  I suggest:
>
>    ...  As including an exception would require
>    implementation changes in deployed implementations of IDNA20008, the
>    IETF has decided to not add a BackwardCompatible rule to IDNA2008
>    (i.e.  Section 2.7 of RFC 5892 [RFC5892]) for this code point.  This
>    also ensures all sandhi marks being treated in an equal way.

Taken care of

> Section 5:
>
>    s/conclusion of this document is to not add/conclusion is to not add/
>
> It is not the conclusion of the document, it is the consensus of the IETF (assuming that the IETF Last Call confirms that position).

Taken care of

> Minor Concerns:
>
> Section 2.1:  s/4892/5892/

Ohhhh...good catch! Thanks!

> Section 2.3 says: "... CONTEXTJ, and CONTEXTO ..."  CONTEXT is explained earlier in the document, but please provide a brief explanation of these derived property values.  They are used later in the document too.

Taken care of based on other review.

> Nits:
>
> Section 1, last 3 paragraphs, says:
>
>    There were three incompatible changes in the Unicode standard after
>    Unicode 5.2.0 [Unicode-5.2.0] up to including Unicode 6.0.0
>    [Unicode-6.0.0], as described in RFC 6452 [RFC6452].  The code points
>    U+0CF1 and U+0CF2 had a derived property value change from DISALLOWED
>    to PVALID while U+19DA had a change in derived property value from
>    PVALID to DISALLOWED.  They were examined in great detail and IETF
>    concluded that the consensus is that no update was needed to RFC 5892
>    [RFC5892] based on the changes made to the Unicode standard.
>
>    As described in Section 3, more changes have been made to code points
>    between Unicode version 6.0.0 and Unicode version 12.0.0
>    [Unicode-12.0.0] so that the derived property values have been
>    changed in an incompatible way.  This document concludes that no
>    exceptions are to be added to RFC 5892 [RFC5892] even though there
>    are changes in the derived property value as a result of the changes
>    made in Unicode between version 6.2.0 and 12.0.0.
>
>    Further, in 2015, the Internet Architecture Board (IAB) issued a
>    statement [IAB] which requested the IETF to resolve the issues
>    related to the code point ARABIC LETTER BEH WITH HAMZA ABOVE (U+08A1)
>    that was introduced in Unicode 7.0.0 [Unicode-7.0.0].  This document
>    concludes that this code point is not to be added to the exception
>    list either.  It should be noted that the review on U+08A1 indicated
>    that it is not an isolated case and that a number of PVALID code
>    points of long standing may have similar issues.  The problem
>    resulted in a clarification of the review process of new Unicode
>    versions RFC 8753 [RFC8753].  This clarification of the review
>    process will impact review of Unicode versions after version 12.0.0.
>
> I propose a shorter summary that I think says the same thing:
>
>    There were three incompatible changes between Unicode 5.2.0
>    [Unicode-5.2.0] and Unicode 6.0.0 [Unicode-6.0.0]; they are
>    described in RFC 6452 [RFC6452].  The code points U+0CF1 and U+0CF2
>    had a derived property value change from DISALLOWED to PVALID, and
>    the code point U+19DA had a change in derived property value from
>    PVALID to DISALLOWED.  These changes were examined in great detail,
>    but the IETF concluded that these changes to the Unicode standard
>    did not warrant an update to RFC 5892 [RFC5892].
>
>    As described in Section 3, more incompatible changes have been made
>    to code points between Unicode 6.0.0 and Unicode 12.0.0
>    [Unicode-12.0.0]; however, the changes in the derived property values
>    do not result in exceptions being added to RFC 5892 [RFC5892].
>
>    Further, in 2015, the Internet Architecture Board (IAB) issued a
>    statement [IAB] that asked the IETF to resolve the issues around
>    the code point ARABIC LETTER BEH WITH HAMZA ABOVE (U+08A1) that was
>    introduced in Unicode 7.0.0 [Unicode-7.0.0].  Again, no exception is
>    being added to RFC 5892 [RFC5892]; however, it should be noted that
>    the review of the issues around U+08A1 indicated that this code point
>    is not an isolated case and that a number of PVALID code points of
>    long standing may have similar issues.  The problem resulted in a
>    clarification of the review process of new Unicode versions, which
>    are published in RFC 8753 [RFC8753].  This clarification of the
>    review process will impact the future review of Unicode versions
>    beyond 12.0.0.

Thanks!

> Section 2.3: s/version 3.2 of The Unicode Standard/Unicode 3.2/

Done!

   Patrik