Re: [Last-Call] Opsdir last call review of draft-ietf-suit-mud-06

Hannes Tschofenig <hannes.tschofenig@gmx.net> Thu, 21 December 2023 11:06 UTC

Return-Path: <hannes.tschofenig@gmx.net>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 59034C09037D; Thu, 21 Dec 2023 03:06:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmx.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1t_vCPFIuXxJ; Thu, 21 Dec 2023 03:06:43 -0800 (PST)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1F10DC090376; Thu, 21 Dec 2023 03:06:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1703156796; x=1703761596; i=hannes.tschofenig@gmx.net; bh=Ghm/WFIUv3OxQBD4eYfLxdUnv2mVVPtrvGkGI2ER9dI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=VYuRWby8Fikaw0ibUbXFdQG3JZTfxa/X4rUmurmiDMoc7wwbr2pqaKKD0Vw/wjIA 6kAqzfcCGjIXTsv6xhS5K0YW9SD5+ArTOy4udltihPl5/kCczirMiQN/KhJ8lwlpG 6g6qBFydqVGvs5oPY/iPbIzpDhgtAYkPQ4IdfSRKPeWHvNuy6/dZScjxC8p1Tmp7C Xpq+aCEw0xw8gpfDieTUodH2EsDb6RwCk4159Vd3oLXT47e1v1Ov0DYPt/6y2Ur6+ ZSdTe/gSSx807VmtpZIKeZprUc587Rk1n15RoB0N633dbbuiUYbeCQTihQfKe8gMG f6W0yLX9tVSMaTTnSQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from [172.16.254.186] ([185.176.157.173]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1Obb-1rAjTz2Oq3-012rZy; Thu, 21 Dec 2023 12:06:36 +0100
Content-Type: multipart/alternative; boundary="------------tV7R57LWle8G8jy0x9ExlAfw"
Message-ID: <aca7f406-ba0e-4f66-ae27-1e34d97cc28c@gmx.net>
Date: Thu, 21 Dec 2023 12:06:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Eliot Lear <lear@lear.ch>, Susan Hares <shares@ndzh.com>, ops-dir@ietf.org
Cc: draft-ietf-suit-mud.all@ietf.org, last-call@ietf.org, suit@ietf.org
References: <170170315182.17411.11522235103450951717@ietfa.amsl.com> <e92a87df-5554-4dda-b5aa-47155f3c4614@gmx.net> <ef80cde4-027a-463d-8b6b-21df80fa9d8e@lear.ch>
From: Hannes Tschofenig <hannes.tschofenig@gmx.net>
In-Reply-To: <ef80cde4-027a-463d-8b6b-21df80fa9d8e@lear.ch>
X-Provags-ID: V03:K1:E0BpHrt5nqG4OMukeAreL5rV3jS/umP8SA09AcoxP1sSOBqb3ls UZfPX5ulpmEWbgeRd1AbqkPshgK2ktPydRkvy8NAe052nEQ3ZDC6KFb4ITUbOjiVpo7/NjB oq2TX6EzYArvD/cMYldVhO+ZAVE++S3K4ciyQfXpKDRKa/J3Mfj6buHAWSsmY+NKIA8tARm ledFWIq78TTWp0SMzzv0g==
UI-OutboundReport: notjunk:1;M01:P0:+mcLhB1enGE=;c0Z8vBAO5AmhWfuHO0QMZDF1yi7 Wt4hdiIyWQtz558YWj6nxd3b1ALH8cm9biEsiMmWDYxmIzED1dQ4XBnWzkdqoZsta9rbqpPAT u33JSIWDzwNx9/Vwhat1eqNlj0feE3Myn1WEXq5tzkBnKerS0Dk6FMpJKSgnV1r1MEJZQH6av ZW3ufKgY619tUY4goc7Oif9TCZlYYMFsUVq6NDOjO2wS22xfDKhvyDhQ/lwdKb6CrigVd6fbD MhJvwZdz77K7GO6mqAvJlQFTefKl7f4InaUTqESdQv/QxI7tiANuxwGQ9q7Y9QQ0o/QBVn660 /oS4kns3hzPSnFm5A/jchiA/VFWTCVhnrQgD5B4PuKAqbUHgzDLPWrfI5MYknJa7w2hboWBAI 7x890JjM6ILg7ZCULsNsggtQRZYIhkNBSUk+kDkqR3dMZrekgVs1onb5y0Xzh7Prw/FGhGcP9 EqOQsEqYhv7EA1fun8KhOA4E5YAy8sB+7OwN9fu7IXGttbbdX4tYcSKKYC7iNeI3SSTzJiL6y Zh+PBheNuYV7dccXu+O9QCzul7pMREecyaWPpoYEQrgKmrGyT9FdFTyGh6InCYxNPfuLHy2Vt zQ/As0jWOVY1TvJskC5FsT633Kb8KHBtmkSa+EW+aqevzmsKt7qPIAhjhvrOWCrC02o7BtEgt zg2h6t/dT7qQ4k1uXyEOQA8Oic2Za9JJIXhuCooRTgebxmzVZdGOXDT+66WPhaJO/3+ROJvTD +fQok5fndVeD4tRvd+L82rtsLAe0UfksVpPSF6wQ+uOXq1Ka8BLoTuD/cXTZaAi4npdGmURsl GW8Zubj8ffT0GSqfV1sr1EEiy5eoxNhhQeZ2vEGIHjznW6ik2i6o1aufu4W1F+Lbk3kQDSSDK aoZ6Yz+CtEvPH3IxYHeKNvl8Lq5L3v6HmoBht6rpS5luRA4SB0xANKv3IcF7Q1cG3Q4r5lFVz sMgwODGG9Kdv8Wl44WvKCfNGgIc=
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/ZTJ7JYrUA194pTYDPbqceByd7so>
Subject: Re: [Last-Call] Opsdir last call review of draft-ietf-suit-mud-06
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Dec 2023 11:06:44 -0000

Hi Eliot,


thanks for the quick response.


That's good to hear but I haven't read how any error cases are reported
to some central device management system to take some actions.

Is that functionality documented somewhere as well? For example, some
YANG modules for use with Netconf?


Ciao

Hannes


Am 21.12.2023 um 11:35 schrieb Eliot Lear:
>
> Hi Hannes and thanks Sue
>
> The MUD Manager always has the responsibility to "consider the source"
> and then to consider the context.  The information provided in MUD
> files *can *be used to automate access control to their associated
> devices.  I think this is pretty well covered in RFC 8520, but I am
> starting to think about an update to that document.
>
> Eliot
>
> On 21.12.2023 11:08, Hannes Tschofenig wrote:
>> Hi Susan,
>>
>> thanks for your detailed review.
>>
>> You are correct that this document does not address operational
>> aspects of the MUD Manager and this is certainly something the OPSAWG
>> working group should address since this document is a tiny extension
>> to the already existing MUD RFC. Along these lines you are also
>> correct that the document does not define any mechanism for the MUD
>> Manager to notify the operator about any error situations with the
>> processing of MUD files and/or SUIT manifests. I will reach out to
>> Eliot and the OPSAWG working group to think about standardization
>> work in this direction.
>>
>> I have updated the draft to better explain how the different URIs are
>> passed around. I also added a figure to illustrate it graphically.
>> Attestation Evidence, which is used to convey information about the
>> MUD URL, also allows the network to double-check the
>> firmware/software (and other properties of the device). We didn't go
>> into any details about how Evidence is processed because this is part
>> of different documents, like the RATS architecture RFC. I hope the
>> updated text clarified these aspects.
>>
>> Regarding the CDDL I had a chat with Brendan and we will make an update.
>>
>> Ciao
>> Hannes
>>
>>
>> Am 04.12.2023 um 16:19 schrieb Susan Hares via Datatracker:
>>> Reviewer: Susan Hares
>>> Review result: Has Issues
>>>
>>> Overall comment:
>>> Qualifications: I am not an expert on SUIT implementations or an
>>> operator of
>>> networks using SUIT. Therefore, my issues may be covered by some
>>> general
>>> security considerations in a document I am not aware of.
>>>
>>> General comments to authors:  This feature is clearly described in this
>>> document. Brendan and Hannes did an excellent job of writing the
>>> document.
>>>
>>> Security/Operational Issues:
>>>
>>> The security of MUD URLs may move the attacks from individual
>>> devices to the
>>> MUD Manager. (Instead of a single lemming going over the cliff, a
>>> MUD manager
>>> may send many lemmings over the cliff). This document does not seem
>>> to consider
>>> the operational issues in the MUD Manager or provide mechanisms on
>>> how to check
>>> for these attacks (e.g. Yang modules with operational state).
>>>
>>> 1. An Attack on the MUD Manager can shut down or subvert the entire
>>> network.
>>>
>>> It is not clear how the operator knows an attack on the MUD Manager
>>> is happening
>>> or occurred. If the MUD Manager pulls in broken SUIT manifests and
>>> then pulls in broken software/firmware based on the SUIT manifests
>>> how does the operator know?  In other words what device watches
>>> that the MUD Manager is not subverted via a management protocol?
>>>
>>> I do not see any operational state in the MUD Yang module [RFC8620
>>> section 2.1]
>>> It would seem natural to have some operational state in the MUD
>>> Manager reports
>>> manifest state. Yang's notif protocols could report any manifest
>>> state change
>>> (over secure TLS connections) to a centralized security server.
>>>
>>> 2. For secure URLs transmitted by 802.1X with certificates,
>>> Why are these not a "double-check" on the validity of the software?
>>>
>>> Again, it would seem natural to utilize these secure certificates as
>>> "double-checks" on the MUD Manager being "in-sync"  with the devices.
>>>
>>> 3. As a less secure double-check on being "in-sync", is the
>>> reporting of
>>>   MUD URL sent via MUD Devices via DHCP or LLDAP that is not what is
>>> in the
>>>   manifest.
>>>
>>> These reporting features are useful in transition scenarios as well as
>>> detecting attacks on the MUD manager.
>>>
>>> Editorial nits:
>>>
>>> 1. section 1, last paragraph, sentence 2
>>>
>>> Old text: /can get/
>>> New text: /has/
>>>
>>> English grammar
>>>
>>> 2. Just for my sanity, would you check the following text is correct
>>>
>>> $$SUIT_severable-members-extensions //= (
>>>    suit-manifest-mud => bstr .cbor SUIT_MUD_container
>>> )
>>> It appears you are looking to define a CBOR Type for the
>>> the SUIT_MOD_container is defined in the text.
>>>
>>> What I think I'm missing is the .cbor value for SUIT.
>>> It looks correct, but I could  not derive this from
>>> draft-ietf-suit-manifest-24:
>>>
>>> SUIT_Severable_Manifest_Members = (
>>>    ? suit-payload-fetch => bstr .cbor SUIT_Command_Sequence,
>>>    ? suit-install => bstr .cbor SUIT_Command_Sequence,
>>>    ? suit-text => bstr .cbor SUIT_Text_Map,
>>>    * $$SUIT_severable-members-extensions,
>>> )
>>>
>>> And your IANA definitions of:
>>>
>>> IANA is requested to add a new value to the SUIT envelope elements
>>> registry
>>> created with [I-D.ietf-suit-manifest]: Label: TBD2 [[Value allocated
>>> from the
>>> standards action address range]]
>>>
>>> Name: Manufacturer Usage Description (MUD)
>>> Reference: [[TBD: This document]]
>>>
>>> Again, this may be due to my incomplete understanding.
>>> This is why this is a NIT rather than an Issue.
>>>
>>>
>>>
>>