Re: [Last-Call] Genart last call review of draft-ietf-ippm-ioam-ipv6-options-08

Joel Halpern <jmh@joelhalpern.com> Sun, 25 September 2022 04:26 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A6D6AC1522D8; Sat, 24 Sep 2022 21:26:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.806
X-Spam-Level:
X-Spam-Status: No, score=-2.806 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=joelhalpern.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z0o6I2DTgRC0; Sat, 24 Sep 2022 21:26:13 -0700 (PDT)
Received: from mailb2.tigertech.net (mailb2.tigertech.net [208.80.4.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A7DA7C14CF02; Sat, 24 Sep 2022 21:26:13 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailb2.tigertech.net (Postfix) with ESMTP id 4MZt9x3s9nz1pZ4R; Sat, 24 Sep 2022 21:26:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelhalpern.com; s=2.tigertech; t=1664079973; bh=clklW5G+MEMOTSJvUYlTSLk4yb3XNhhjXocZEIrxwYk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RBCAEhjx8UKJsnY6vaaN6nOPeM5jN9bNwluk9Mh7QFGfHkKOZgEinqEXoWXCCE+G4 ME/ndf7q0lXTvgOXHunE4FlN/BHVHscS0SiE5BKWnKkHrdyTj/7OVgUKlh7rxyBCmc UPF5nU0sz5PX7vd2w5AiZ4l1cNbg0ObnvJOogBm0=
X-Quarantine-ID: <PGZTB053mJIR>
X-Virus-Scanned: Debian amavisd-new at b2.tigertech.net
Received: from [192.168.23.73] (unknown [50.233.136.230]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailb2.tigertech.net (Postfix) with ESMTPSA id 4MZt9w51Dlz1nsDW; Sat, 24 Sep 2022 21:26:10 -0700 (PDT)
Content-Type: multipart/alternative; boundary="------------SIdhxAhAa03sv6oQQ7rAaEN7"
Message-ID: <d43e6a33-5aba-0d0a-67a2-6e9525a1e805@joelhalpern.com>
Date: Sun, 25 Sep 2022 00:26:09 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2
Content-Language: en-US
To: Shwetha Bhandari <shwetha.bhandari@thoughtspot.com>
Cc: gen-art@ietf.org, draft-ietf-ippm-ioam-ipv6-options.all@ietf.org, ippm@ietf.org, last-call@ietf.org
References: <165644698691.26121.8228321260533705192@ietfa.amsl.com> <CAMFZu3N0HQ4-41iLyU-CB+eAMLs9dDuhSpBL8svJOUgF0FXZVQ@mail.gmail.com>
From: Joel Halpern <jmh@joelhalpern.com>
In-Reply-To: <CAMFZu3N0HQ4-41iLyU-CB+eAMLs9dDuhSpBL8svJOUgF0FXZVQ@mail.gmail.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/bg1oday87Fhcr1Z17O6S4XGu9N4>
Subject: Re: [Last-Call] Genart last call review of draft-ietf-ippm-ioam-ipv6-options-08
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Sep 2022 04:26:17 -0000

Thank you for addressing my comments.  trimmed, responses where needed 
in line.

Yours,

Joel

On 9/24/2022 10:01 PM, Shwetha Bhandari wrote:
> Thank you for the detailed review and sorry for a very late response. 
> I am creating a revision of the draft based on this feedback.
> Responses and clarifications inline @SB
>
> On Wed, Jun 29, 2022 at 1:39 AM Joel Halpern via Datatracker 
> <noreply@ietf.org> wrote:
>
>     Reviewer: Joel Halpern
>     Review result: Ready with Issues
>
>     I am the assigned Gen-ART reviewer for this draft. The General Area
>     Review Team (Gen-ART) reviews all IETF documents being processed
>     by the IESG for the IETF Chair.  Please treat these comments just
>     like any other last call comments.
>
>     For more information, please see the FAQ at
>
>     <https://urldefense.com/v3/__https://trac.ietf.org/trac/gen/wiki/GenArtfaq__;!!MZ3Fw45to5uY!NoSxZQbYffG7SJV0yDCTEy7dKRhLkASqrXTvmSZYhuyCrik6ftQvulTvbfT6xyFBWdoxk_7S4nD87nOYMkJnckbF$
>     >.
>
>     Document: draft-ietf-ippm-ioam-ipv6-options-08
>     Reviewer: Joel Halpern
>     Review Date: 2022-06-28
>     IETF LC End Date: 2022-07-01
>     IESG Telechat date: Not scheduled for a telechat
>
>
>     Minor issues:
>
>         Section 5.1 (Considerations for IOAM deployment in IPv6 networks)
>         requirement C1 seems to be an implementation requirement not a
>     deployment
>         requirement.  The text even ends with "Implementations of IOAM
>     SHOULD..."
>         Why is this in a deployment considerations section?
>
>
> [SB] This was an important consideration for implementation and 
> deployment that came
> up during the workgroup discussions. Would renaming the sesion to 
> deployment and implementation
> considerations work?
<jmh>Yes, renaming the section to "deployment and implementation 
considerations" would resolve this concern. </jmh>
>
>
>         Requirement C5 in 5.1 says that leaks need to be easily
>     identified and
>         attributed.  That's nice.  It doesn't seem to say HOW that is
>     to be done.
>         So how does an implementor or deployer comply with the
>     requirement?
>
> [SB] This is not addressed in the current draft. A future draft could add
> IOAM field to indicate the AS that added the IOAM data.
<jmh>I marked this as minor, so if you really can't say anything else, I 
guess I can live with it.  But it seems more than a little odd to have a 
requirement in a draft with no way to meet it.</jmh>
>
>     Nits/editorial comments:
>
>
>         It would be helpful if section 5.3 (IOAM domains bounded by
>     network
>         devices) restated that such ingress edge devices will
>     encapsulate the user
>         packet, and put the IOAM option in the resulting encapsulating
>     header.  And
>         decapsulate at the egress.
>
> [SB] The deployment options elaborates this option, it is difficult to 
> summarize that and add it as part of the requirement.
> I would prefer to keep this context in the deployment options section.
<jmh>Okay.</jmh>
>
>
> Thanks,
> Shwetha