Re: [Last-Call] [EXTERNAL] Artart last call review of draft-ietf-lamps-ocsp-nonce-update-04

Himanshu Sharma <himanshu@netskope.com> Mon, 01 April 2024 22:12 UTC

Return-Path: <himanshu@netskope.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E816CC14F6AB for <last-call@ietfa.amsl.com>; Mon, 1 Apr 2024 15:12:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.091
X-Spam-Level:
X-Spam-Status: No, score=-2.091 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=netskope.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nQatPiUaL52x for <last-call@ietfa.amsl.com>; Mon, 1 Apr 2024 15:12:47 -0700 (PDT)
Received: from us-smtp-delivery-117.mimecast.com (us-smtp-delivery-117.mimecast.com [170.10.133.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B48CC14F68D for <last-call@ietf.org>; Mon, 1 Apr 2024 15:12:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netskope.com; s=mimecast20210603; t=1712009565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=crRMqTB/KHb/yDWr6iNsJCGqYK0lFsgrkjma2TTl2wE=; b=GO4ku+q37D6HbiZwNcfN8FF9cYPl8tHGDM5JDTIvzahqkx6YhbokfnzsHcT+7jRBjcTiXU MvyIMG3b6KcJJtrNVPTpcU2HSmBvrcmuhVSBuP1O2Lkbz6X+3khvZVqmQwjeqSEqVFkyqh t1Y9HB/4u4z2SEEa4ujnstNXEZJBD7E=
Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-fn3gGF6qNM-gSl_uGjdjLA-1; Mon, 01 Apr 2024 18:12:43 -0400
X-MC-Unique: fn3gGF6qNM-gSl_uGjdjLA-1
Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-6147c5b33e7so31574337b3.3 for <last-call@ietf.org>; Mon, 01 Apr 2024 15:12:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712009563; x=1712614363; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UgNNZRhrUNvni5MyZ6lPU1Ob+cifjHPy/O7OplOxEvc=; b=ODVt2BSCcA0B+DKFmaqKl0C6zgVBOr7U78MaJa2k1WYRknn63oDPe5kU13nxRa7fho sPJwB3dLpq5Lf3TjcAPjZoOMTHX0GEJ+cIC1sFq/wKman278m3dKtmCvWElEhlHGVzdw 3UpV/jp3STzT7hYHyBzrE1PKpa8qC6xqwyfeL/ZqMqCxP2VoItkpSixRbovIPEcvYsMA 46M65D/qgh4p7aS2VOl/gaTl+vuefmKN14AQ931TnCV/nJo+1Lh8CZtkxXnU/CZ470KS YoBcb6cbaQb5h8lERetwuES2OUEst8XVAOWP6uLPsLInvyeaz51sGNp96SsvvGf5Im0j Eibw==
X-Forwarded-Encrypted: i=1; AJvYcCUlJ98Jl3ifGkh0zDI3Mwg3V3gyeT6w8o3/jP6Jx5fDHqWA30QOfYx5Wj9bEU/lKf8wadfKldUSvwwSBifALiou998=
X-Gm-Message-State: AOJu0YzDeDTQ1cAVYdWo8djHfgb/fd9BQP4C8kueqliWxJuR/vrEwOIz ukCD/znijB6r7gG6jQ/zyDOtVCYtJ5Wmkm/mtWxWEUe+nf0wuveDjsX2uMofn3YX4KSFVa65KMQ gGtN7tb0leoDZlxMZdvGGyXz6wHP/8YpY8P3CXczGXhMMtW+WfvQX7dX8jExLVBBoLCIErcw0nq y25pUBXAmMhLqu8p2TAUxoSONJ
X-Received: by 2002:a81:4f81:0:b0:615:c70:243e with SMTP id d123-20020a814f81000000b006150c70243emr1861773ywb.6.1712009563158; Mon, 01 Apr 2024 15:12:43 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IH0gYGi19B1kkBAC5gBxbZkXkT69mpBkSPkQjEM5XkaECqQrtSN+5ygxD3T30FYXU8i7mnKVSCGEGtp
X-Received: by 2002:a81:4f81:0:b0:615:c70:243e with SMTP id d123-20020a814f81000000b006150c70243emr1861765ywb.6.1712009562871; Mon, 01 Apr 2024 15:12:42 -0700 (PDT)
Received: from netskope.com ([163.116.128.167]) by smtp-relay.gmail.com with ESMTPS id hn2-20020a05690c62c200b006110a52d974sm573653ywb.58.2024.04.01.15.12.42 for <last-call@ietf.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 15:12:42 -0700 (PDT)
X-Relaying-Domain: netskope.com
Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1e0e2fd2113so28823065ad.0 for <last-call@ietf.org>; Mon, 01 Apr 2024 15:12:42 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCUmouXXDQjBGqSl3KL67/fHgSO6QlImiYnwzmEj/2UWRjz8K2mnVd6km4eMQI0qnZwN9pDVJ8QbpHEWcPODV5u7T4w=
X-Received: by 2002:a17:902:a388:b0:1dd:b3ef:4528 with SMTP id x8-20020a170902a38800b001ddb3ef4528mr8556220pla.52.1712009561607; Mon, 01 Apr 2024 15:12:41 -0700 (PDT)
X-Received: by 2002:a17:902:a388:b0:1dd:b3ef:4528 with SMTP id x8-20020a170902a38800b001ddb3ef4528mr8556209pla.52.1712009561242; Mon, 01 Apr 2024 15:12:41 -0700 (PDT)
MIME-Version: 1.0
References: <171199463982.27279.13238273687080929241@ietfa.amsl.com>
In-Reply-To: <171199463982.27279.13238273687080929241@ietfa.amsl.com>
From: Himanshu Sharma <himanshu@netskope.com>
Date: Mon, 01 Apr 2024 15:12:29 -0700
Message-ID: <CAL9pJ7mQg_eWye9OVV2w192Jcuchzcs_es6moFmSo=05DOLKsQ@mail.gmail.com>
To: Jim Fenton <fenton@bluepopcorn.net>
Cc: art@ietf.org, draft-ietf-lamps-ocsp-nonce-update.all@ietf.org, last-call@ietf.org, spasm@ietf.org
x-netskope-inspected: true
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: netskope.com
Content-Type: multipart/alternative; boundary="000000000000c07296061510497c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/r_MfWvIktfRuxgmc-QYm_2prFZE>
Subject: Re: [Last-Call] [EXTERNAL] Artart last call review of draft-ietf-lamps-ocsp-nonce-update-04
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Apr 2024 22:12:53 -0000

Thanks Jim for your time to review the Draft.
 I will work on the suggestions and update the draft accordingly.



On Mon, Apr 1, 2024 at 11:04 AM Jim Fenton via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Jim Fenton
> Review result: Almost Ready
>
> I am the designated ART ART reviewer for
> draft-ietf-lamps-ocsp-nonce-update-04.
>
> Status: Almost ready
>
> Comments:
>
> Section 1, suggest replacing "[RFC8954] enforce the maximum" to "[RFC8954]
> limits the maximum"
>
> Section 2, suggest replacing "enforce" with "limit".
>
> Section 2.1 paragraph 1 can be deleted since this is replacing RFC8954 in
> its
> entirety.
>
> Section 2.1 paragraph 3: "An OCSP client that implements this document
> SHOULD
> use a minimum length of 32 octets..." while RFC 8954 says, "Newer OCSP
> clients
> that support this document MUST use a length of 32 octets..." It seems like
> this requirement has been weakened; is there a reason for that? Also in
> that
> paragraph, rather than "in excess of what is permitted by RFC 8954" suggest
> saying "in excess of the limit of 32 octets that was specified in RFC
> 8954."
>
> Section 2.1 paragraph 4: replace "...MUST accept Nonce octets length of at
> least 16 octets..." with "...MUST accept Nonce lengths of at least 16
> octets..."
>
> Section 2.1 paragraph 5: replace "Nonce octet length" with "Nonce length"
>
> In the example, the object identifier, in addition to Offset and Length,
> is in
> decimal.
>
> I don't have the expertise in ASN.1 to fully review Appendix A; hopefully
> another reviewer can check that.
>
> IDNITS points out that you have a normative reference to RFC 5912, which is
> informational. I'm not sure the reference is really normative, though.
>
>
>