IETF Logo Mail Archive

Re: [Last-Call] Genart last call review of draft-allan-5g-fmc-encapsulation-07

David Allan I <david.i.allan@ericsson.com> Thu, 28 January 2021 23:51 UTC

Return-Path: <david.i.allan@ericsson.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 33F1C3A17DD; Thu, 28 Jan 2021 15:51:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.351
X-Spam-Level:
X-Spam-Status: No, score=-2.351 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bOuJLpWQiE_h; Thu, 28 Jan 2021 15:51:42 -0800 (PST)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 607513A17D7; Thu, 28 Jan 2021 15:51:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sy5kMdWgXBjq0PxZTOT5ds11YNBA8Ak1KbR4VeNhC/Q8ULCt3ljtKE5x1EfgOzYkAawvJ47XMGGB5qtEyBoIp6wH/S/v6nhAKTh0EICbgQPXPucUjYjXTnzkE6jAaORoDbd2fFrXCEHYiqkMuIiUKUf5XfbskwLxlWbU7+j7C1/b5YtGt4jcSj1NyzXkGma/cVKrJoDquO5n5jET2ueuG84c19oeY03QctTum7rg38q04p1WpZ6JYDQCrS9nnoRAzTIIpj063wXkmb4lHw0fGoqYZup3U/Frc2pkmdFp7pvhNsVzYQp4T2QD1UMvxwXbeYKrA4BO+o09129GLFv5yA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BYTmtV0vvjMJUKOl8YyhEnfJQPz06BmJVQPjNYPIm8=; b=OY9SiUL31M3md0T3NPJQFhYiz2IA8O5Js2aL8C6bpIVtApAvoQieQL4VxtdJ4+IhvBjdPB0tZ5/5ImSYjoC/31EWemFcfXR0NsHq5w2pg6RfGzP082ZSBMJz1Xl40T8g9xg+Xbl8+PJcM6BqthqjI2gYFjbu5aHek/unt8JLVK92yPzm0daWcgqKMH6n3yPmi5TdEUOmsnoTfvPya7ajKAsoNksWvnK6QWlZ0acXXszk3wDHeurRxiEEXciPvRL++x6d3wq6bOuRnpLRQuj3bIW4Je6JZdyzfhoA276+teRWkDB7vBi81qd62lnMo99TcZXHiGHLTPnMlgerBw+f8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BYTmtV0vvjMJUKOl8YyhEnfJQPz06BmJVQPjNYPIm8=; b=bC2x1/2g5vDfeDSHFCfBDg6vBX+wtFVZhOfHzTM7p4yg6TXCzV2iumYCmnZaZ1Z3aCR7G+4dv80cIAroK2iu10JQYUSgjSw2gFMUguVQ6x/BZTLcdbVU/QPsuA7ieDSPU456kAW+G8JI6iRyKkDmMJ4Jd+UeBZmr/ZXQLsMqkiY=
Received: from BY5PR15MB3715.namprd15.prod.outlook.com (2603:10b6:a03:1fe::28) by BYAPR15MB3192.namprd15.prod.outlook.com (2603:10b6:a03:10f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Thu, 28 Jan 2021 23:51:34 +0000
Received: from BY5PR15MB3715.namprd15.prod.outlook.com ([fe80::ec85:fc81:db49:7c3]) by BY5PR15MB3715.namprd15.prod.outlook.com ([fe80::ec85:fc81:db49:7c3%7]) with mapi id 15.20.3805.019; Thu, 28 Jan 2021 23:51:34 +0000
From: David Allan I <david.i.allan@ericsson.com>
To: Russ Housley <housley@vigilsec.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-allan-5g-fmc-encapsulation.all@ietf.org" <draft-allan-5g-fmc-encapsulation.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-allan-5g-fmc-encapsulation-07
Thread-Index: AQHW9Y8EQLuOMjKKrEugPGo7cbaJj6o9sMnw
Date: Thu, 28 Jan 2021 23:51:34 +0000
Message-ID: <BY5PR15MB37156033CA2E6D2AAF2F2E43D0BA9@BY5PR15MB3715.namprd15.prod.outlook.com>
References: <161184974409.10546.4997528219479351790@ietfa.amsl.com>
In-Reply-To: <161184974409.10546.4997528219479351790@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: vigilsec.com; dkim=none (message not signed) header.d=none;vigilsec.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [76.28.201.119]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f5f4c370-2423-4eea-c39c-08d8c3e7a50b
x-ms-traffictypediagnostic: BYAPR15MB3192:
x-microsoft-antispam-prvs: <BYAPR15MB31927B6BC2C0D698198CEF24D0BA9@BYAPR15MB3192.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: MoyUDMkXJ1zd6UMJXq4ZxJWjtxv6Qr1XBZkEB/5M2pRGTPgtZFWz/DInBKiAtMY0+dEg2LRSxlUytc4iB0Fb6YQcR7/HhLCi2qnC7urf6B3Mwbj37TXE14lzrUn5MYi5ObBqXI0yicvQYNu0hUTN1D1LuqUfX1r2CaBKQ/s1oYiq4okQALw6CoUNtv+TgS3bWL7wp+5KeNfEKfwtay9030pJ3cmClWHyV8cSOCE87M+ZtD6uJXW10tnfU58sBeSj4S5jc9N/jwf65SFu4POOpGXu6b72z9yBTiizqFlrd/tKwfJG7dg+L/f6tPPOZb8sPpVve6vN0Wntnu4KfB1qxy+ESjLjuee4WSKTNoMeklnUpTi4K3FDDW7LVuRhc50ZJUPVJ+XWx05nxVKP9tUcusX0g1YyuamV09FP2FbcFZDX0Bms1veryPqvAG4k4ysOL/ojwQHnMq8FK2RkA0qOiNvW6fthPBbuOiAa8MDUF2D5OlS3yBQ8soBiBSB8e7vYvLvR1gzI7D40bTbLjZ4W2ab60G3v6uausVLlZqIGARFH7WtjjbVmBMCcFjpHZTwu0PEP0NbplxlRrjPCc6QgWWqEPbtjfyZppZo1UWdoWag=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR15MB3715.namprd15.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(8676002)(53546011)(2906002)(71200400001)(6506007)(26005)(86362001)(7696005)(186003)(5660300002)(478600001)(33656002)(4326008)(66946007)(66446008)(9686003)(8936002)(54906003)(55016002)(110136005)(52536014)(316002)(76116006)(66476007)(66556008)(64756008)(83380400001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: +NJpAe8slc9V96muP4j6d22KQu9gFg5mqxZoS4kP8+YYdLdikLN7Ponscz+7vHFATs8gqBBZcSFmPIQLt5MtPqzUwePsTac/NEOuqa2i6F00n4coRLK+Rohcn4XK+fTMtOVTTmxLkSi78lZorjcTR5BLRFFH/yzVvgxnNcuzuNCY7iXWipMDO9mWLcJmC83XJL0t6QnSc4ZsMGGqTSN47+rZOwamBdZeNb/L4RsDfmEoNQ4QxBlJU/gtQJk5lZFjq9icAmNpvhGbvUqqyoYwidQwo5HJFC98elVoyPbvmTadOXvY/XK3ihrF1WB/D8xmRs2EzV+aRTYJPSby1SkktmO54bBjjZS9mPruyXj5IYGuzWqZpJbiiyKWomwvsvg5vPSwV8+o3sgE+P+MpDjWVPD4SF6Hr0KoEBml8suqhO2bYiJ5dObGPEeJ2O9y7xiD/ffn3WnV9dipAJK4xBRXVVg+NvOLiztpxvx1JS9roa1PbbmQYhzgVJpCizDLPtjoVl8e5Qw/arP5uBt15MX/gtQEIBioN28ViL0D+wsiac11fSJrQBB1VnzmavIsx3rIFNR7Vh8kafADEZa7AUNrit1rKt+fG4lt9wXiM39BQh5N9N+mgUBf54oQuFWxn0084Uj79P2L9+dLWNVD1Lq8bnh9HVxgSskq7JRfNWUtC4Sw7D3hBQteMX6EqQ0RQ1hP5pERAbhhfXTUjG6eozJzmSFo+yyy/9Hr8OOB0c6NLGU+rvRMwtoKgvbghmi2XdTMlRkr5JhhFTMmd232mD7BnChh41m3fobIij2Iwiybs0XnWuki7/+BayZUx5iaVxHkNMtoWWXVE7DvviGxiA2Gp32inW0purx5Hzc0L5n2WWT1uWeBLSLgFPWugNC9iqm3WJVhy0yj+p28rI4sxbyAjiD8f7PFfDOS8ZYFN6m/ZygVxPpnx2lcaoeZAHGg9rjP8OYqfS+kcK4xPqbSrxpeRETmVqwC68/z+IenPpC56gAvjteF/t7XARU9gqP72/8QL83uAiSklj8mMJkwgfAOC3l/4cHyBQLJKRb0UVVGk7UeAKrMhxMgGY4mzFlQyCd9
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3715.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5f4c370-2423-4eea-c39c-08d8c3e7a50b
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2021 23:51:34.6048 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: macvpQ/fN4hXM9NCg0Qws/qwxd9TPxn5EFIzqrtgwbTN0YoAbIFb75KnYDS8bLk0YzSTL1LmQjAx8mvYKNcX/vLhQJ/QqO8sA4JPrdFAK1M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3192
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/u-aaEPdeE60mCf8jyuNh4tpsMjs>
Subject: Re: [Last-Call] Genart last call review of draft-allan-5g-fmc-encapsulation-07
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2021 23:51:44 -0000

HI Russ:

I understand your major concern. How does this work?

   This encapsulation is expected to be used in environments where RFC 2516 is deployed. Therefore implementations MUST examine the version number:
    - if the version number is 1, and PPPoE [RFC2516] is supported, process the frame further, else silently discard it.
    - if the version number is 2 and 5WE is supported, process the frame further, else silently discard it.  
   In both cases frames for the supported version number should  have session IDs corresponding to established sessions for the respective protocol models. A 5WE frame with an unrecognized session ID MUST be silently discarded.

We'll correct the minor nit along with the wherever we get to with the above, and any other updates that come out of the LC.

Rgds
Dave



-----Original Message-----
From: Russ Housley via Datatracker <noreply@ietf.org> 
Sent: Thursday, January 28, 2021 8:02 AM
To: gen-art@ietf.org
Cc: draft-allan-5g-fmc-encapsulation.all@ietf.org; last-call@ietf.org
Subject: Genart last call review of draft-allan-5g-fmc-encapsulation-07

Reviewer: Russ Housley
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-allan-5g-fmc-encapsulation-07
Reviewer: Russ Housley
Review Date: 2021-01-28
IETF LC End Date: 2021-02-05
IESG Telechat date: Unknown


Summary: Almost Ready

Thank you for addressing all of the concerns raie in my earlier review.


Major Concerns:

Section 1 says:

   This encapsulation is expected to be used in environments where RFC
   2516 is deployed. Therefore implementations are required to examine
   the version number and react accordingly.

Please reword as a MUST statement.  Also, a simple sentence that tells the implementer how to "react accordingly" is needed.  I suspect that one should follow RFC 2516 if the version is 0x01 and follow this memo if the version is 0x02.


Minor Concerns:

None.


Nits:

Section 1 says: "... same offset as the [RFC2516] PPPoE data ...".
The [RFC2516] is placed in an awkward location in the sentence.

v2.23.0 | Report a Bug | By Email