Re: [Lime] draft-ietf-lime-yang-oam-model-07.txt: YANG compilation error

Benoit Claise <bclaise@cisco.com> Wed, 07 September 2016 13:37 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8035B12B1FC; Wed, 7 Sep 2016 06:37:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.029
X-Spam-Level:
X-Spam-Status: No, score=-16.029 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.508, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CHd-AAPi6dJm; Wed, 7 Sep 2016 06:36:59 -0700 (PDT)
Received: from aer-iport-2.cisco.com (aer-iport-2.cisco.com [173.38.203.52]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1354912B026; Wed, 7 Sep 2016 06:36:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=8313; q=dns/txt; s=iport; t=1473255419; x=1474465019; h=subject:to:references:from:message-id:date:mime-version: in-reply-to; bh=ETv8LPbMRxLZb4Z56bp1urPDj5N2fZss+RJa1XMlMjY=; b=i37LIGjUVHJ+6gMBADUuCipDFQQ3l6FbfwgXGtsjgcD8lGqFCj4SU0kT vM5koCM1ht9FvbuFvy7kF8n4YuyWf6cPuP5tjRG8gJrX35cVwwP9J4/NP fSGadVX5/rcl5h7UNeGTLjl6QbZTle6NliIQZvo8eJqlFQ++N1eILlvFy s=;
X-IronPort-AV: E=Sophos;i="5.30,296,1470700800"; d="scan'208,217";a="645338042"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2016 13:36:57 +0000
Received: from [10.60.67.84] (ams-bclaise-8913.cisco.com [10.60.67.84]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id u87Dau15025249; Wed, 7 Sep 2016 13:36:57 GMT
To: draft-ietf-lime-yang-oam-model@ietf.org, "lime@ietf.org" <lime@ietf.org>, "Carl Moberg (camoberg)" <camoberg@cisco.com>
References: <12082947-20f8-f237-38d8-b2e9242294fc@cisco.com> <32650ca7-8764-255b-8d57-1947a54276db@cisco.com>
From: Benoit Claise <bclaise@cisco.com>
Message-ID: <ab5319e5-13a9-3690-849f-f401176cfa11@cisco.com>
Date: Wed, 07 Sep 2016 15:36:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <32650ca7-8764-255b-8d57-1947a54276db@cisco.com>
Content-Type: multipart/alternative; boundary="------------4B40E87B4E8ED93376AB8E58"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/7kjxKsccD0AmU025_Sh-rwHTx9E>
Subject: Re: [Lime] draft-ietf-lime-yang-oam-model-07.txt: YANG compilation error
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Sep 2016 13:37:02 -0000

Dear authors,

Please solve the compilation issue with your draft.

I've been adding a new column to the report at 
http://www.claise.be/IETFYANGPageCompilation.html, where from you can 
download the extracted YANG module.
Lately, I received some concerns about the line number from the pyang 
output that could not easily match to the YANG module line number.
Indeed the pyang error line number is the one from the YANG module and 
not the IETF draft. This is specifically a concern with xpath issues.
On top of that, some people use rfcstrip as opposed to xym.py to extract 
the YANG modules from IETF draft.

The error for your draft is:

    ietf-conn-oam.yang:351: error: the node 'MD-name-format' from module
    'ietf-conn-oam' is not found
    ietf-conn-oam.yang:351: error: the node 'name-format-null' from
    module 'ietf-conn-oam' (in node 'MD-name-null' from 'ietf-conn-oam')
    is not found
    ietf-conn-oam.yang:391: error: the node 'MA-name-format' from module
    'ietf-conn-oam' (in node 'domain' from 'ietf-conn-oam') is not found
    ietf-conn-oam.yang:391: error: the node 'name-format-null' from
    module 'ietf-conn-oam' (in node 'MA-name-null' from 'ietf-conn-oam')
    is not found

Downloading the YANG, I confirm that this is a xpath issue.

     choice MD-name {
       case MD-name-null {
         leaf MD-name-null {
         when "../../../MD-name-format = name-format-null" 
{                     <= line 351
         description
         "MD name format is equal to null format.";
         }
         type empty;
         description
         "MD name Null.";
         }
       }
       description
         "MD name.";
     }


   grouping MA-name {
     description
       "MA name";
     leaf MA-name-format {
       type identityref {
         base name-format;
       }
       description
         "Ma name format";
     }
     choice MA-name {
      case MA-name-null {
       leaf MA-name-null {
        when "../../../MA-name-format = name-format-null" 
{               <= line 391
        description
          "MA";
       }
         type empty;
         description
         "empty";
         }
       }
       description
         "MA name";
     }
   }

Regards, Benoit
> Dear authors,
>
> Part of the IETF hackathon today, I integrated confdc , as a second 
> YANG module compiler, in 
> http://www.claise.be/IETFYANGPageCompilation.html. Reason? For 
> example, confdc validates xpath while pyang doesn't.
> And confdc found an issue with your draft, which is now flagged as 
> failing the YANG compilation.
> Please correct this issue.
> Note: you're not alone, look at the green dip today on green graph 
> <http://claise.be/IETFYANGPageCompilation.png>!
>
> During the hackathon today, Carl Moberg also integrated the confdc 
> output in his www.yangalidtor.com.
> This might help you.
>
> Regards, Benoit
>
>
> _______________________________________________
> Lime mailing list
> Lime@ietf.org
> https://www.ietf.org/mailman/listinfo/lime