Re: [lisp] Tsvart telechat review of draft-ietf-lisp-rfc6830bis-19

Dino Farinacci <farinacci@gmail.com> Tue, 25 September 2018 17:08 UTC

Return-Path: <farinacci@gmail.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F76C124D68; Tue, 25 Sep 2018 10:08:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o6v9em9Fil7r; Tue, 25 Sep 2018 10:08:40 -0700 (PDT)
Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3C3A12426A; Tue, 25 Sep 2018 10:08:39 -0700 (PDT)
Received: by mail-pg1-x52b.google.com with SMTP id y4-v6so12011015pgp.9; Tue, 25 Sep 2018 10:08:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J2dy3tU0K91JntPqBsnC8w1/nt1enfcPMFSY4yheQ0k=; b=SnthT9nzrOF5rfMQNLKOkvXX0sB+NKti9ughaYf5yLvpQQEq4ER8sFkydEQPZPd4Cl nihuN7eYERs7Vyvy1mj2+fGF8nTCrrYGdPar6Ns46m8xLhBf/PMXyK8ZUxfY89RvNtDI YlhdoaSpPsTYZgK4311+qClizzycfDLy8ZqvRQIi29jewMCyEDjhwkbD+aLpx4H/dJ3W lGf3qZKGW2+05xT+YtbGtGosoRQEJER0FZ+rK2mPJQbCc83hLujf0/bOzllvstbghCOL cYeI/r3ROZ8jAnuLHjea5Q6egjQ+03D5XrnNDIxWSOnT92Dj3CRgKUiFZmLef6xQMdm8 Ysog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J2dy3tU0K91JntPqBsnC8w1/nt1enfcPMFSY4yheQ0k=; b=iY2+UBfknsTrIVxlUz3OCqnNSQxCNg2w2k5pa7INdGhQW3p8DdEUzrvhb8GWInXbPC DulImWSaqg6+AcuyMIzUjwIuvcKCc4pqmCyhAr4C6GOKL0OmSQXrOH5w9EJ3AgdwtPiF L+am6pSv69MF/jx1/jzxy5zki3ALfpN4ISYPr/D1e2nuNQwsxk2p6KW0VWnRFggE6BFt 2QPsF+MPu/h4Y4D54sZj0eNHPCFrARVLJtCh1bx1ss9I4JhJLmdIq5WhMzywBbtyI54m XqUw4NpTtGmBXADfj2afMJ7KqsLrYbZwY+jy8RK22nwDSZh+afH5y4SbwJlbBJmsd9+i RkZg==
X-Gm-Message-State: ABuFfojirX0ZoO0d3+z3VyNATiER0LCwxDOi+6mwEgrSbIdOvrrfxyv/ s9bJcu/cRQ6O5gb+hdzZPzKw7mBW
X-Google-Smtp-Source: ACcGV62IKqy0OwKrtKH6cMKI17H75OA4tbtC1/jftVUm0bMh9BuWcJMGtyUmhBls2IMcOSuC/yPjow==
X-Received: by 2002:a63:c046:: with SMTP id z6-v6mr1955010pgi.114.1537895319406; Tue, 25 Sep 2018 10:08:39 -0700 (PDT)
Received: from [10.228.203.131] (72-172-185-190.bayarea.net. [72.172.185.190]) by smtp.gmail.com with ESMTPSA id w2-v6sm3383984pgb.61.2018.09.25.10.08.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Sep 2018 10:08:38 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Dino Farinacci <farinacci@gmail.com>
In-Reply-To: <153786758036.30012.5926379631854398353@ietfa.amsl.com>
Date: Tue, 25 Sep 2018 10:08:37 -0700
Cc: tsv-art@ietf.org, draft-ietf-lisp-rfc6830bis.all@ietf.org, ietf@ietf.org, lisp@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0B81D5C1-6D51-407A-91D5-E793E59E873D@gmail.com>
References: <153786758036.30012.5926379631854398353@ietfa.amsl.com>
To: Brian Trammell <ietf@trammell.ch>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/37U-sJhy2cjewPli1wJPFjKgGXo>
Subject: Re: [lisp] Tsvart telechat review of draft-ietf-lisp-rfc6830bis-19
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 17:08:41 -0000

Thanks Brian. Consider it changed in the -20.

Dino

> On Sep 25, 2018, at 2:26 AM, Brian Trammell <ietf@trammell.ch> wrote:
> 
> Reviewer: Brian Trammell
> Review result: Ready with Nits
> 
> Thanks for the revisions. Following up on my previous tsvart review, there is
> one remaining nit from previous transport reviews:
> 
> - Section 5.3, the list "When doing ITR/PITR encapsulation", third item needs a
> citation fix:
> 
> OLD:
> 
>      The 'Explicit Congestion Notification' (ECN) field (bits 6 and 7
>      of the IPv6 'Traffic Class' field) requires special treatment in
>      order to avoid discarding indications of congestion [RFC3168].
> 
> NEW:
> 
>     The 'Explicit Congestion Notification' (ECN) field (bits 6 and 7
>      of the IPv6 'Traffic Class' field) requires special treatment in
>      order to avoid discarding indications of congestion [RFC6040].
> 
> Thanks, cheers,
> 
> Brian
> 
>