Re: [lisp] Fwd: AD Review of draft-ietf-lisp-6834bis-09

Alvaro Retana <aretana.ietf@gmail.com> Tue, 26 April 2022 18:28 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72F14C1D5ADE; Tue, 26 Apr 2022 11:28:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id im6DSD3qGxwh; Tue, 26 Apr 2022 11:28:21 -0700 (PDT)
Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FD60C1D5ABC; Tue, 26 Apr 2022 11:28:21 -0700 (PDT)
Received: by mail-wm1-x32c.google.com with SMTP id bi24-20020a05600c3d9800b00393ff664705so148919wmb.4; Tue, 26 Apr 2022 11:28:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=z2LrBh8bbGgf9EhgjuqzXZK/IbTPeJmyYkIKAP42f0A=; b=ktQFNkdgMRWWrSYMK5FBTFkHVKiEqu3w+UDkLAdZVhMRpzk9ApA6i0gg1h6uQrEDsT /2OmdPIyz3x+nu368A02ziveRM6ngY13Nbc0AeWTCdW01nVHOeaQz8jAFBTG25S/Lm5F FE1ZzVnZtOszxCeLHVJnyHIj/ty3eyLEAOcMJ/87iEm0uzMWiX3QJOhBICpaVqOkus98 gIB8pbqROP+fig/vIwUGITNTVnj8INC7rIxhbvy4V6XamerEuR7hsAL6wXAMZmIXTOZa 6VjpT6IHc++6c7MVmZzXP5kp5Ha5vxfwCH9T2vCcL9F1Ci7Dc6XH9ntpowzCUD1rXEwH XLHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=z2LrBh8bbGgf9EhgjuqzXZK/IbTPeJmyYkIKAP42f0A=; b=3uVWN6/dpw249JyspVim4Mm9jNEaHMKu9onTnsaoNfvFl4DACTJECTGgFDtNqN0y5O jQj/AUTnDJBqjO3DCaPpv9DkSqWZzXtdrDXn4WVeB3JK6pAqc0vAT/YegWArNmrDSBRs p6ZewNBDdmu5ETDmu+IR04LA4qyLjagunDCiYQ9bhkqHoZTrcr2DXtnUxzclq1JxPouH ugTUzErkZv3jONveOuoh+kVqdTWVgqI+jU4CglP+O6Z8FplgbW4OO614H/AXGDY0YPtE KF3z+4qNwqbb0GeoaQ84PX0uNimkTKXbsLUlSZ4XHko8OgB3Vu5UxsvG6FETKBDGyrmd MOPw==
X-Gm-Message-State: AOAM532aBBYxV9xDBDrMrctRj8fnhiELGDH9SR9hPhNuuBn3oFFzY+bB bU40aYcqk6yIn9XAxlyf613yZYXVhU0tViCf97wKxCVyWf4=
X-Google-Smtp-Source: ABdhPJxAP+gPrIq2rpHWnkZr97f85cLFwIiexqaQ5OAvPtDbIQMgWCYRtHY9IlrXZl4I+a1B2l6D7RWze0hXqA49hBw=
X-Received: by 2002:a1c:2b41:0:b0:392:9543:9782 with SMTP id r62-20020a1c2b41000000b0039295439782mr22338737wmr.124.1650997699671; Tue, 26 Apr 2022 11:28:19 -0700 (PDT)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Tue, 26 Apr 2022 20:28:19 +0200
From: Alvaro Retana <aretana.ietf@gmail.com>
In-Reply-To: <4422D18E-B48B-49EE-8108-EF6300DF2E89@gigix.net>
References: <2c8e60b4a15c4b6096984920d12cdfcf@huawei.com> <4422D18E-B48B-49EE-8108-EF6300DF2E89@gigix.net>
MIME-Version: 1.0
Date: Tue, 26 Apr 2022 20:28:19 +0200
Message-ID: <CAMMESsyEbTsXby-ese74tJdP+BHXj=ZE76cPaMBLSnJMEZePLw@mail.gmail.com>
To: Luigi Iannone <ggx@gigix.net>
Cc: draft-ietf-lisp-6834bis@ietf.org, Padma Pillay-Esnault <padma.ietf@gmail.com>, lisp-chairs@ietf.org, lisp@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/L0mpckg6lhDASYpzasj8zU8gucA>
Subject: Re: [lisp] Fwd: AD Review of draft-ietf-lisp-6834bis-09
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2022 18:28:27 -0000

On April 26, 2022 at 9:44:10 AM, Luigi Iannone wrote:

[Adding to the distribution list to keep everyone in the loop.]



Luigi:

Hi!

I have some replies below.

I'll take a look at the diffs when you post an update.


Thanks!

Alvaro.



...
> > > (1) Duplication and overlap
...
>
> [LI] Having a look to 6830bis:
> Yes, Section 13.2 can be dropped altogether. 6830bis references Section 13.2
> in Section 10 and Section 5.3. Both references can be replaced to a reference
> to 6834bis.
>
> As for the last two paragraphs: The very last is the text to be put in
> section 5.3.
>
> The second last is actually already present in the security section of
> 6834bis. This should be enough, right?
>
> I would just add the sentence “Further security considerations on
> Map-Versioning can be found in [6834bis]” in the paragraph mentioning
> Map-Versioning in Section 16 “Security Considerations” in 6833bis.

This sounds good to me.

As Shepherd for rfc6830bis, can you please take care of making sure
this update gets done?


> For 6833bis:
> In Section 5.4 replacing:
>
> Map-Version Number: When this 12-bit value is non-zero, the Map-
> Reply sender is informing the ITR what the version number is for
> the EID record contained in the Map-Reply. The ETR can allocate
> this number internally but MUST coordinate this value with other
> ETRs for the site. When this value is 0, there is no versioning
> information conveyed. The Map-Version Number can be included in
> Map-Request and Map-Register messages. See Map-Versioning
> [I-D.ietf-lisp-6834bis] for more details.
>
> With:
>
> Map-Version Number: 12-bit version number assigned to the EID
> record contained in the Map-Reply. See Map-Versioning
> [I-D.ietf-lisp-6834bis] for more details.
>
> The above should completely eliminate any duplication.

Yup.

Please also take care of this update.


...
> > 224 4.1. The Null Map-Version
> >
> > [] The comments below indicate that there are multiple places that
> > overlap with this section. The text from this section may be
> > relocated (and clarifying actions taken) to make the document clearer.
> > This section could then be eliminated.
> >
> > Paragraph 1 could be moved to §6.
> >
> > Paragraph 2 could be moved to §5/§5.1/§5.2.
> >
> > Paragraph 3 could be moved to §7.
> >
> > Paragraph 4 could be moved to §4.
...
>
>
> [LI] This is certainly a possible approach, but actually back to the writing
> of the original 6834, the section has been added in order to have one single
> place that specifies everything related to the null version number. If you
> really think that readability will have a huge improvement but spreading the
> content in other sections this can be done.

Yes, that's fine.


...
> > 262 5. Dealing with Map-Version Numbers
> > ...
> > 272 To each mapping, a version number is associated and changes each time
> > 273 the mapping is changed. Note that Map-Versioning does not introduce
> > 274 new problems concerning the coordination of different ETRs of a
> > 275 domain. Indeed, ETRs belonging to the same LISP site must return for
> > 276 a specific EID-prefix the same mapping, including the same Map-
> > 277 Version number. This is orthogonal to whether or not Map-Versioning
> > 278 is used. The synchronization problem and its implications on the
> > 279 traffic are out of the scope of this document.
> >
> > [] See my comment in §7 about leaving this out of scope and the
> > requirement from rfc6833bis.
>
>
> [LI] Not sure what is the issue here. This paragraph has been added in the
> first 6834 document because of the question “can different ETRs have
> different Map-Version for the same mapping” The answer is no. That text does
> not change anything in the 6833bis.

The text was cut before you got to §7. :-(