Re: [lisp] [Tsv-art] Tsvart last call review of draft-ietf-lisp-rfc6830bis-15

"Brian Trammell (IETF)" <ietf@trammell.ch> Thu, 30 August 2018 09:57 UTC

Return-Path: <ietf@trammell.ch>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 59DA4130DC1; Thu, 30 Aug 2018 02:57:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 563_gdfLI93z; Thu, 30 Aug 2018 02:57:34 -0700 (PDT)
Received: from gozo.iway.ch (gozo.iway.ch [212.25.24.36]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02B731277C8; Thu, 30 Aug 2018 02:57:33 -0700 (PDT)
Received: from gozo.iway.ch (localhost [127.0.0.1]) by localhost (Postfix) with ESMTP id CBBB1340FBB; Thu, 30 Aug 2018 11:57:29 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by localhost (ACF/6030.31875); Thu, 30 Aug 2018 11:57:29 +0200 (CEST)
Received: from switchplus-mail.ch (switchplus-mail.ch [212.25.8.236]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by gozo.iway.ch (Postfix) with ESMTPS; Thu, 30 Aug 2018 11:57:29 +0200 (CEST)
Received: from nb-10604.ethz.ch (account ietf@trammell.ch [82.130.102.91] verified) by switchplus-mail.ch (CommuniGate Pro SMTP 6.1.18) with ESMTPSA id 65718244; Thu, 30 Aug 2018 11:57:29 +0200
From: "Brian Trammell (IETF)" <ietf@trammell.ch>
Message-Id: <B466126A-DBE8-4088-AC93-F7D49C534ABE@trammell.ch>
Content-Type: multipart/signed; boundary="Apple-Mail=_EB589D8F-24BF-4303-B865-101E27C9A1D1"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 30 Aug 2018 11:57:28 +0200
In-Reply-To: <C4425CD6-B44D-479A-819A-BEFCC83E9E33@gmail.com>
Cc: draft-ietf-lisp-rfc6830bis.all@ietf.org, tsv-art@ietf.org, IETF Discussion Mailing List <ietf@ietf.org>, "lisp@ietf.org list" <lisp@ietf.org>
To: Dino Farinacci <farinacci@gmail.com>
References: <153538054829.30074.15428909912816972228@ietfa.amsl.com> <ED34F830-1FEF-42BB-BB6E-805D724AB339@gmail.com> <79FA52C8-94AC-43CE-B052-9F921A65E0D5@trammell.ch> <23680BD5-0DD3-4404-888D-D1C78A0A437D@gmail.com> <130902C2-9CEE-4931-8957-D32446723B89@trammell.ch> <CF5E3C7B-E492-4EE9-A2E6-A2D823C6610F@gmail.com> <1514B576-87FD-475F-B6C5-BBA1C2CA94ED@trammell.ch> <CE7ECD23-E8A2-4D48-B752-0D246C02F27E@gmail.com> <FBA13CF2-8E44-46DA-AB5D-9082B5288F05@trammell.ch> <5E2CBC85-87FF-48DC-950B-403E6E8E14BF@gmail.com> <C4425CD6-B44D-479A-819A-BEFCC83E9E33@gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/WgsCoKvnCl35QbjyRUsOpRSD3N8>
Subject: Re: [lisp] [Tsv-art] Tsvart last call review of draft-ietf-lisp-rfc6830bis-15
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Aug 2018 09:57:36 -0000

hi Dino,

Almost. How about:


OLD:

When the UDP and LISP headers require integrity protection, the
methods of using UDP checksums in [RFC8085] can be considered.

NEW:

Implementors are encouraged to consider UDP checksum usage guidelines in section 3.4 of [RFC8085]. Specifically, when the UDP, LISP, and outer IPv6 headers require protection against corruption, the use of non-zero UDP checksums is RECOMMENDED.


Thanks, cheers,

Brian

> On 29 Aug 2018, at 20:18, Dino Farinacci <farinacci@gmail.com> wrote:
> 
> Brian, see the second reference to RFC 8085 in the diff file below. Let me know if this could satisfy your comment. Thanks.
> 
> Dino
> 
> <rfcdiff.html>
> 
>> On Aug 29, 2018, at 10:17 AM, Dino Farinacci <farinacci@GMAIL.COM> wrote:
>> 
>>> We're talking past each other here, I think.
>>> 
>>> There are, as I see it, two completely separate problems here:
>>> 
>>> (1) The document permits/recommends zero UDP checksum on IPv6 outer packets. This leaves the IPv6 header unprotected against inadvertent corruption. To prevent this, LISP should follow the guidelines in section 3.4.1 of 8085, specifically:
>>> 
>>>    Use of the UDP checksum with IPv6 MUST be the default
>>>    configuration for all implementations [RFC6935].  The receiving
>>>    endpoint MUST only allow the use of UDP zero-checksum mode for
>>>    IPv6 on a UDP destination port that is specifically enabled.
>>> 
>>> and
>>> 
>>>    A UDP application MUST check that the source and destination IPv6
>>>    addresses are valid for any packets with a UDP zero-checksum and
>>>    MUST discard any packet for which this check fails.  To protect
>>>    from misdelivery, new encapsulation designs SHOULD include an
>>>    integrity check at the transport layer that includes at least the
>>>    IPv6 header, the UDP header and the shim header for the
>>>    encapsulation, if any [RFC6936].
>>> 
>>> See also Magnus' tsvart review on lisp-gpe; his issue A is basically the same problem.
>> 
>> This issue has come up at least once or twice every 2 years. We suggest a zero checksum no matter what the  outer header is because we wanted to be practical with respect to what implementations do. No matter what the IETF says, the industry has moved forward and not only do not check checksums for UDP based tunnels but if they wanted to they can’t because many hardware does not have the entire packet buffer in the forwarding engine that does header processing.
>> 
>> So I would not want to change our text at this point. We are very aware this is controversial but it is emotionally packed as well. UDP packets in all probability will not be missed forward because layer-2 chips do a very good job at CRC. So if its bit errors one worries about, that is very rare. If it is packet corruption due to MITM, that is another story.
>> 
>> We can make a reference to 8085 with respect to checksums but we have to craft the text carefully because I really don’t want to release a spec that doesn’t reflect reality. So if you can help us craft a couple sentences, we can consider putting it in.
>> 
>>> 
>>> None of this, however, defends against the second problem:
>>> 
>>> (2) Any on-path attacker, or any off-path attacker who knows the addresses of the xTRs, can guess the current state of mappings, and can spoof packets from one of them, can send packets with valid LISP
>> 
>> They cannot if the inner header is encrypted. The EIDs will be obfuscated. All that is known is that one location is sending to another location and not who is sending to who.
>> 
>>> headers (and, indeed, valid checksums if they so choose) which will change xTR state in ways which can lead to denial of service conditions. A cryptographic integrity check over the LISP header would prevent the on-path attacks. I *think* the nonce echo functionality can be used to prevent off path attacks, or at least allows an endpoint that suspects it is under attack to challenge
>> 
>> For this context, the key-id field in the LISP header is the only precious entity. All other bits could be  MITM attacked and the ETR could verify if the settings are real or not (at some expense). If the key-id field is changed, then the ETR will get decryption or ICV errors and drop packets. Yes, I know that is a DoS.
>> 
>> To resolve this, I’d be willing to refer to 8085 and use checksum when users believe they need to protect the UDP and LISP headers.
>> 
>> What do you think?
>> 
>>> Indeed, the security considerations section (and 7835 on which it is based) acknowledges most of this, and it seems that work is ongoing to fix this (draft-ietf-lisp-sec-15), so I guess you can simply take my comment on the second problem as encouragement to get lisp-sec done (subject, of course, to the warnings in draft-trammell-optional-security-not).
>>> 
>>> Cheers,
>> 
>> What do you think of my suggestion?
>> 
>> Dino
>> 
>> 
>