[lisp] Yangdoctors early review of draft-ietf-lisp-yang-20
Joe Clarke via Datatracker <noreply@ietf.org> Mon, 27 November 2023 18:04 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: lisp@ietf.org
Delivered-To: lisp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 5556CC15109C; Mon, 27 Nov 2023 10:04:51 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Joe Clarke via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: draft-ietf-lisp-yang.all@ietf.org, lisp@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.15.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170110829132.9448.206573558890876120@ietfa.amsl.com>
Reply-To: Joe Clarke <jclarke@cisco.com>
Date: Mon, 27 Nov 2023 10:04:51 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/dX1tlWcC0BM49JgFzEjoa-C2yxY>
Subject: [lisp] Yangdoctors early review of draft-ietf-lisp-yang-20
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.39
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Nov 2023 18:04:51 -0000
Reviewer: Joe Clarke Review result: On the Right Track I am the latest member of YANG Doctors to review this document and the modules therein. I looked over chopps' previous review, and it appears most of his comments have been addressed. In my own reading, I found inconsistent use of capitalization and punctuation in descriptions (e.g., some ended in periods, some did not; most started with a capital letter, some did not); as well as inconsistent quoting. All modules would benefit from a `pyang -f yang` normalization and an editorial pass. In the ietf-lisp module itself, there are a couple of patterns in there where I wonder if the regex is what you want exactly. For example, is it okay if an eid-id starts with a ':' or a '-'? For the locator-id, this is a string of 1-64 characters, but the regex hints it could be zero or more of the character class (a similar example exists with hop-id in address-types). All modules' initial revisions reference the original LISP RFC but do so with a URL only vs. a more correct, RFC 6830: ... syntax. And speaking of revision, most of the modules have a revision of 2021-02-22 with the exception of itr and mapresolver. This isn't a big deal now, as I assume you'll set all of these when the draft is finalized. You should also update all of the copyright years and copyright text. As to the two questions asked here, I can see some benefit of breaking out the IANA parts of address-types into a module that they maintain. But in its current form, I don't know that it makes sense to have them maintain it. As for geoloc, I do see some overlap, but I am not a LISP expert at all, so I cannot comment as to whether bringing that whole module in makes sense or would even work with LISP implementations. That is, it seems LISP lat and long are expressed in degrees° minutes'seconds" whereas geoloc does this as a decimal64 from a reference frame. I do feel that whatever direction is taken, text explaining why geoloc is not used is useful.
- [lisp] Yangdoctors early review of draft-ietf-lis… Joe Clarke via Datatracker
- Re: [lisp] Yangdoctors early review of draft-ietf… Luigi Iannone
- Re: [lisp] Yangdoctors early review of draft-ietf… Alberto Rodriguez-Natal (natal)