Re: [Lsr] Pre-writeup review comments

"Joel M. Halpern" <jmh@joelhalpern.com> Thu, 08 October 2020 15:00 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E3103A0B56; Thu, 8 Oct 2020 08:00:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.311
X-Spam-Level:
X-Spam-Status: No, score=-2.311 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.213, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=joelhalpern.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SUedGWfnvaT3; Thu, 8 Oct 2020 08:00:43 -0700 (PDT)
Received: from mailb2.tigertech.net (mailb2.tigertech.net [208.80.4.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DC1973A096C; Thu, 8 Oct 2020 08:00:43 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailb2.tigertech.net (Postfix) with ESMTP id 4C6ZBz4gLtz1nyBg; Thu, 8 Oct 2020 08:00:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelhalpern.com; s=2.tigertech; t=1602169243; bh=dCnDcSyjse5yPvtIchdb+mk5Je2vgIMA49OH0kBT1ZE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZwGQGvgPHyiiGswLnVFmrX6PfLNY9zmrGxejCb29xkvERJ0x2ZEYVRx4OnFR1insa Td6GB2iOnbAj8GpsiW7WOHPmMT1MxRgp33ZXGHYISm6zG9m91U4Ro2blTa2dXMaSu7 mO9AbY9E4Cx6ORj+OGR1fi2fbGzJgeSvzLooluq0=
X-Quarantine-ID: <fiftN5_8WW_n>
X-Virus-Scanned: Debian amavisd-new at b2.tigertech.net
Received: from [192.168.128.43] (unknown [50.225.209.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailb2.tigertech.net (Postfix) with ESMTPSA id 4C6ZBy6fg3z1nvn7; Thu, 8 Oct 2020 08:00:42 -0700 (PDT)
To: Peter Psenak <ppsenak=40cisco.com@dmarc.ietf.org>, chopps@chopps.org
Cc: lsr@ietf.org, draft-ietf-lsr-isis-srv6-extensions@ietf.org
References: <F4960B6C-87E7-4A32-8340-37E2C82A2CBC@chopps.org> <e68c2baa-4fbb-a2dd-aee8-42d8e1de7538@cisco.com> <CF2C1EE5-8A9D-46C4-A30C-57A78144A90D@chopps.org> <4794a984-38fe-0a85-9622-fb62d12bdb31@cisco.com>
From: "Joel M. Halpern" <jmh@joelhalpern.com>
Message-ID: <dbdc7965-56f2-3ae8-0237-7560f35a203e@joelhalpern.com>
Date: Thu, 8 Oct 2020 11:00:42 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <4794a984-38fe-0a85-9622-fb62d12bdb31@cisco.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/0Bp5DJrRJPvRyzZMZS0P_OE8Y7Q>
Subject: Re: [Lsr] Pre-writeup review comments
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Oct 2020 15:00:46 -0000

Just to confirm, yes, that change Peter has made removing END.T resolves 
my concerns.
Thanks,
Joel

On 10/8/2020 9:38 AM, Peter Psenak wrote:
> Hi Chris,
> 
> please see inline:
> 
> On 02/10/2020 12:32, Christian Hoppsprotocol= application/pgp-signature 
> wrote:
>> Thanks for the update, a couple issues remain.
>>
>> [ ] 7.1 and 8.1
>>
>> The reserved bits for "SRv6 Locator TLV" and "SRv6 End.X SID sub-TLV" are
>> defined differently (and probably incorrectly) than the other reserved 
>> bits.
>> Reserved bits "MUST" be set to zero, not "SHOULD", I believe.
> 
> fixed.
> 
>>
>> [ ] 11.  Implementation Status
>>
>> I know you mentioned that the section should be removed, but how about 
>> adding a note to the editor in the next revision e.g., "RFC Ed.: 
>> Please remove this section prior to publication"?
> 
> done
> 
>>
>> [ ] 12.5.  Sub-Sub-TLVs for SID Sub-TLVs
>>
>> This section needs to better conform to registry creation standards (see
>> https://tools.ietf.org/html/rfc8126). In particular there is no guidance.
> 
> I have modified the section 12.5.
> 
> 
>>
>> It looks like there is more discussion from Joel on this draft, so I 
>> will hold off on submission for that to resolve.
> 
> I have removed the END.T in the latest version. The discussion with Joel 
> is closed.
> 
> thanks,
> Peter
> 
>>
>> Thanks,
>> Chris.
>>
>>> On Sep 23, 2020, at 4:36 PM, Peter Psenak 
>>> <ppsenak=40cisco.com@dmarc.ietf.org> wrote:
>>>
>>> Hi Chris,
>>>
>>> thanks for your comments.
>>>
>>> Please see inline (##PP):
>>>
>>> On 18/09/2020 16:08, Christian Hoppsprotocol= 
>>> application/pgp-signature wrote:
>>>> During my review and while doing the Shepherd writeup for 
>>>> https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-srv6-extensions/ I 
>>>> came up with the following comments:
>>>> 4.3 - Maximum H.Encaps MSD Type:
>>>>    - what is the default if not advertised?
>>>
>>> ##PP
>>> added "or no value is advertised" as for other MSD types.
>>>
>>>> 6.  Advertising Anycast Property
>>>> Should "Locator that is advertised..." be:
>>>>    "An SRv6 Locator that is advertised..."?
>>>> or:
>>>>    "A prefix/SRv6 Locator that is advertised..."?
>>>
>>> ##PP
>>> fixed.
>>>
>>>> 7.1 SRv6 Locator TLV Format
>>>> The R fields and their handling, are not defined.
>>>
>>> ##PP
>>> added
>>>
>>>
>>>> 8.  Advertising SRv6 Adjacency SIDs
>>>> "must be" "in order to be correctly applied" -> "are" and ""?
>>>
>>> ##PP
>>> I replaced with:
>>>
>>> Certain SRv6 Endpoint behaviors 
>>> [I-D.ietf-spring-srv6-network-programming] are associated with a 
>>> particular adjacency.
>>>
>>>
>>>> 8.1.  SRv6 End.X SID sub-TLV
>>>> "Other bits" -> "Reserved bits" -- labels should match
>>>
>>> ##PP
>>> fixed.
>>>
>>>> 8.2.  SRv6 LAN End.X SID sub-TLV
>>>> I'm sympathetic to Bruno's comment, and so I think it would be 
>>>> better to say:
>>>> Diagram: "System ID (1-6 octets)" and in text:
>>>> "6 octets" -> "System ID: 1-6 octets"
>>>> I see no reason to mess with this even if the commonly-implemented 
>>>> value is 6 at
>>>> this point. IS-IS implementations that only support 6 octets are 
>>>> free to only
>>>> support 6 in this sub-TLV as well. They won't be talking with other 
>>>> IS-IS
>>>> routers that are configured to have a non-6 octet system ID value. 
>>>> What other
>>>> extension RFCs may or may-not do WRT this doesn't really matter I 
>>>> think.
>>>
>>> ##PP
>>> I have updated the text to match what is being used in RFC8667, 
>>> section 2.2.2
>>>
>>>
>>>> "Other bits" -> "Reserved bits" -- labels should match
>>>
>>> ##PP
>>> fixed
>>>
>>>> 11.  Implementation Status
>>>> Does this section need a "RFC Ed.: Please Remove prior to 
>>>> publications"? It
>>>> seems pretty wrong to document current status of implementations 
>>>> permanently in
>>>> an Standards Track RFC.
>>>
>>> ##PP
>>> yes this section will be removed prior to publication. This is a 
>>> standard procedure we follow.
>>>
>>>> 12. IANA Considerations
>>>> An odd space between "sub- TLV".
>>>
>>> ##PP
>>> fixed
>>>
>>>> 12.5.  Sub-Sub-TLVs for SID Sub-TLVs
>>>> This section needs to better conform to registry creation standards 
>>>> (see
>>>> https://tools.ietf.org/html/rfc8126).
>>>
>>> ##PP
>>> I updated the IANA section format similar to RFC8667.
>>>
>>>
>>>> ID-NITS:
>>>>    There are 19 instances of too long lines in the document, the 
>>>> longest one
>>>>    being 5 characters in excess of 72.
>>>
>>> ##PP
>>> fixed.
>>>
>>>> References:
>>>>    Normative:
>>>>      Published: RFC 8754 draft-6man-segment-routing-header
>>>
>>> ##PP
>>> fixed.
>>>
>>>
>>>>      Out of date reference: [I-D.ietf-6man-spring-srv6-oam]
>>>>      Out of date reference: [I-D.ietf-spring-srv6-network-programming]
>>>
>>> ##PP
>>> Whenever the new version of draft-ietf-lsr-isis-srv6-extension is 
>>> published it picks the latest version, but as these drafts keep 
>>> changing the reference may get out of date quickly.
>>>
>>>
>>>
>>>>    Informative:
>>>>      Published: RFC 8402 draft-ietf-spring-segment-routing
>>>
>>> ##PP
>>> fixed
>>>
>>> thanks,
>>> Peter
>>>
>>> _______________________________________________
>>> Lsr mailing list
>>> Lsr@ietf.org
>>> https://www.ietf.org/mailman/listinfo/lsr
>>>
>>
>>
> 
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org
> https://www.ietf.org/mailman/listinfo/lsr