Re: [Lsr] Rtgdir early review of draft-ietf-ospf-mpls-elc-09

Peter Psenak <ppsenak@cisco.com> Thu, 03 October 2019 13:11 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0AB91200F8; Thu, 3 Oct 2019 06:11:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.502
X-Spam-Level:
X-Spam-Status: No, score=-14.502 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k5lflj7GIv_g; Thu, 3 Oct 2019 06:11:19 -0700 (PDT)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E77912001A; Thu, 3 Oct 2019 06:11:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5376; q=dns/txt; s=iport; t=1570108279; x=1571317879; h=from:subject:to:cc:references:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=BKw8pbKtwMcsILUZjyKKGBhvtVMafLYLxkZCa+vUKaM=; b=N+PEVT2TQGqppR5ls72xOK/nWbbeJedVlAKU6bjQG6KToefJTr7gE9wD 6PQOEC71ahCIUBQJTQFtG2F+qMuHrLmQpJ+2LvPibUceO8kd0OJyJ17nU 3WKYgCaMnE6tRT21FxR8wDL5txRzM1ZMagY8AgRgFcJUj0vxpYwtdRkWh 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BYAQA78pVd/xbLJq1mGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQwBAQEBAQGBZwKDCVMgEioEhB6JAodCJZshCQEBAQ4jDAEBhEACgmg?= =?us-ascii?q?4EwIDCQEBBAEBAQIBBQRthS0MQgEQAYR3AQEBAQIBIw8BBTwFBQsLFAMBAgI?= =?us-ascii?q?mAgJPCAYBDAgBAYMeAYF7Dw+tTXWBMoRMQUCDMIFIgQwoAYUVhxCBQD+BEAE?= =?us-ascii?q?nDIJfPoJWCwIDAYRqglgEnkeOcIItgi+EWY4KBhuCOXKGXIQEizOOKogfkTm?= =?us-ascii?q?BaSKBWDMaCBsVGoMOCEcQFIpWhUE/AzGKR4ZTAQE?=
X-IronPort-AV: E=Sophos;i="5.67,252,1566864000"; d="scan'208";a="17529483"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 03 Oct 2019 13:11:16 +0000
Received: from [10.147.24.59] ([10.147.24.59]) by aer-core-1.cisco.com (8.15.2/8.15.2) with ESMTP id x93DBFX0021634; Thu, 3 Oct 2019 13:11:16 GMT
From: Peter Psenak <ppsenak@cisco.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>, rtg-dir@ietf.org
Cc: lsr@ietf.org, ietf@ietf.org, draft-ietf-ospf-mpls-elc.all@ietf.org
References: <156828311401.16614.6386779752971919411@ietfa.amsl.com>
Message-ID: <db33b455-2cd4-00fa-5954-df90c584fb3c@cisco.com>
Date: Thu, 3 Oct 2019 15:11:14 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <156828311401.16614.6386779752971919411@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Outbound-SMTP-Client: 10.147.24.59, [10.147.24.59]
X-Outbound-Node: aer-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/0b0JDQWfDkVWbe6OazCcMoiYFe4>
Subject: Re: [Lsr] Rtgdir early review of draft-ietf-ospf-mpls-elc-09
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Oct 2019 13:11:23 -0000

Hi Dhruv,

please see inline (##PP)



On 12/09/2019 12:11, Dhruv Dhody via Datatracker wrote:
> Reviewer: Dhruv Dhody
> Review result: Has Issues
> 
> Subject: RtgDir Early review: draft-ietf-ospf-mpls-elc-09
> 
> Hello
> 
> I have been selected to do a routing directorate “early” review of this draft.
> ​https://datatracker.ietf.org/doc/draft-ietf-ospf-mpls-elc/
> 
> The routing directorate will, on request from the working group chair, perform
> an “early” review of a draft before it is submitted for publication to the
> IESG. The early review can be performed at any time during the draft’s lifetime
> as a working group document. The purpose of the early review depends on the
> stage that the document has reached.
> 
> As this document is in working group last call, my focus for the review was to
> determine whether the document is ready to be published. Please consider my
> comments along with the other working group last call comments.
> 
> For more information about the Routing Directorate, please see
> ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
> 
> Document: draft-ietf-ospf-mpls-elc-09
> Reviewer: Dhruv Dhody
> Review Date: 12-09-2019
> Intended Status: Standards Track
> 
> Summary: I have some minor concerns about this document that I think should be
> resolved before it is submitted to the IESG.
> 
> The draft is focused and straightforward, the reader needs to be aware of
> RFC6790 and draft-ietf-mpls-spring-entropy-label beforehand. I have reviewed
> this and the IS-IS I-D together and you will find similar comments for both
> I-Ds.
> 
> Minor
> *****
> 
> (1) Please use updated requirement language text as per RFC 8174, as you do
> have a mix of upper-case and lower-case terms in your I-D.
> 
>        The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
>        NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
>        "MAY", and "OPTIONAL" in this document are to be interpreted as
>        described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
>        appear in all capitals, as shown here.

##PP
RFC 8174 allows the usage of a mix of upper and lower case. If used in 
lower case "they have their normal English meanings", which is the case 
in this draft. Do you have any specific concerns in that regard?

> 
> (2) Could you mark that the codepoints mentioned in the draft are early
> allocated by IANA? This would make it clear that you are not squatting on them.
> I also suggest following change in Section 7 (IANA Considerations) -
> 
> OLD:
>     This document requests IANA to allocate one flag from the OSPFv2
>     Extended Prefix TLV Flags registry:
> 
>        0x20 - E-Flag (ELC Flag)
> 
>     This document requests IANA to allocate one flag from the OSPFv3
>     Prefix Options registry:
> 
>        0x04 - E-Flag (ELC Flag)
> NEW:
>     IANA is requested to confirm the early allocation of the following
>     code point in the OSPFv2 Extended Prefix TLV Flags registry:
> 
>        0x20 - E-Flag (ELC Flag)
> 
>     IANA is requested to confirm the early allocation of the following
>     code point in the  the OSPFv3 Prefix Options registry:
> 
>        0x04 - E-Flag (ELC Flag)
> END

##PP
I'm not sure above is necessary, given that the above text would change 
eventually to simply say which code points have been allocated.

> 
> (3) Section 4, I think a reference to RFC 8476 is needed as well to state the
> ERLD is advertised as part of Node MSD advertisement as defined in [RFC8476].

##PP
I have updated the normative reference from 
ietf-isis-segment-routing-msd to RFC 8476.

> As mentioned in my review of the IS-IS I-D, what happens if one receives ERLD
> in the Link MSD advertisement? As per my understanding this is not allowed,
> better to add normative text for the case then.

##PP
added a sentence to ignore it in Link MSD Sub-TLV.


> 
> (4) Section 8, suggest to also add one sentence for the impact of advertising
> incorrect ERLD. If there isn't any, that can also be stated.

##PP added the sentence.

> 
> Nits
> ****
> (1) Suggested ordering of sections - ..ELC/ERLD/BGP-LS/ACK..  [matching between
> OSPF/ISIS]

##PP
done

> 
> (2) Section 2, add [I-D.ietf-mpls-spring-entropy-label] for terminology
> reference

##PP
done

> 
> (3) Section 3, Add reference to draft-ietf-mpls-spring-entropy-label for the
> definition and usage of ERLD

##PP
The Introduction section has:

"This capability, referred to as Entropy Readable Label Depth (ERLD) as 
defined in[I-D.ietf-mpls-spring-entropy-label]"

Is not that sufficient?

> 
> (4) Section 6,
> 
>     The ERLD MSD-type introduced for OSPF in Section 4 is advertised
>     using the Node MSD TLV (TLV 266) of the BGP-LS Node NLRI Attribute as
>     defined in section 3 of [I-D.ietf-idr-bgp-ls-segment-routing-ext].
> 
> I think you mean draft-ietf-idr-bgp-ls-segment-routing-msd here!

##PP
right, corrected it.

> 
> Also, maybe change the title "BGP-LS Extension" as there is no 'extension'
> required, ELC/ERLD is BGP-LS would be automatically supported.

##PP
renamed to "Signaling ELC and ERLD in BGP-LS".

> 
> (5) Expand MSD on first use.

done.

thanks,
Peter
> 
> Thanks!
> Dhruv
> 
> 
>