Re: [Lsr] Working Group Last Call for "OSPFv3 Extensions for SRv6" - draft-ietf-lsr-ospfv3-srv6-extensions-06.txt (Corrected Address)

Yingzhen Qu <yingzhen.ietf@gmail.com> Tue, 16 August 2022 23:52 UTC

Return-Path: <yingzhen.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D295BC15258F; Tue, 16 Aug 2022 16:52:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.103
X-Spam-Level:
X-Spam-Status: No, score=-7.103 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_FONT_FACE_BAD=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KjSh4KPR9AUq; Tue, 16 Aug 2022 16:52:16 -0700 (PDT)
Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1C4A5C1522AC; Tue, 16 Aug 2022 16:52:16 -0700 (PDT)
Received: by mail-pl1-x636.google.com with SMTP id x23so10601671pll.7; Tue, 16 Aug 2022 16:52:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc; bh=pjqPoKIVD8E1cGHqjkli50Auuhd1oay+LfjhGu8Xwdw=; b=baFuzpGP5HsPqlsUG0LvpMtvikeVS84NMkHdCKuEN2E6S+ZcDSZyetFV4A+RByMfwm 1BPEAHFVSPnU0BEZRqh0bdMLJFCVQCRTmZbjBNt1U9xKXFbqKlC/xIpX57+mQ5I24jlI +P+uWmEvmG9PCLF++JU3yM3ZIAILVonKfjXL1qoeOHnS4VbYXp3pJQs4UNMQGfMChVhH pihiDO8EIkTYtYi+KyFQtRVATheh0/rBvhsYsoR3mVOp/3SdNP9CpgnfPVbeWL9J/z3U hxt9DoWd9A4VlWXsWX6wxkxOcj1RY37oH6wWtYtakNxmBZG9sw1LA76QfjyDfMTFdjMU ql2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc; bh=pjqPoKIVD8E1cGHqjkli50Auuhd1oay+LfjhGu8Xwdw=; b=K9sudO6iAZgvfNbZmMnYv94LeN6GuOg0X/RlROc7zSSxF4wi3ijcTBrtd+UNecq65V zGD7ZEUyGEE2oOlgwH5gHC16RGvDso85gWzhE1WyjzMtXZi0wwTZ8hmM2DYQaEladcTm jUjEQOwp2V9fojh4RTm9yp2m6XCnIUqGVC7uY6Jtm2NMmGu1Si+vRqX7373mzONjAwZE 1PTb5Rsfb+uLUQE5kYwBZ4BDkcR8jUcvaUroLac0yntM9ESxPKxiQ9MFDa2oWrKWWgPV Tlggp2Y/jBjkqEGe1bAWg6bXZ0jP2cpiWEPhpZb/woxrpzkAaEMMlivael0UzFmoCNKP QsuQ==
X-Gm-Message-State: ACgBeo0vmmUQMK4v6zIw5Zl9L37hCPRaIvjCGXYf+qLNGkWNRBz5qDLT o3LcmBe9E7FvZbvm5tJianUezct2AQ==
X-Google-Smtp-Source: AA6agR5ywerJsrkPtUwqF6I2qyou6TPHjuJxIxTaX5C58qggZ2u66OV2LctJMPSp9pTvRjYlmuAhKg==
X-Received: by 2002:a17:90a:c283:b0:1f8:a3e3:f937 with SMTP id f3-20020a17090ac28300b001f8a3e3f937mr972838pjt.141.1660693935329; Tue, 16 Aug 2022 16:52:15 -0700 (PDT)
Received: from smtpclient.apple ([2601:646:9702:c61:1ccc:f204:43a9:293b]) by smtp.gmail.com with ESMTPSA id z18-20020a63c052000000b003fbb455040dsm8198993pgi.84.2022.08.16.16.52.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2022 16:52:14 -0700 (PDT)
From: Yingzhen Qu <yingzhen.ietf@gmail.com>
Message-Id: <39FCA529-767D-4654-94B6-E8D41434A961@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_541A9650-D061-4F20-9354-DB5DB8C1696F"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Date: Tue, 16 Aug 2022 16:52:08 -0700
In-Reply-To: <3FC4BE76-5D3A-405F-B81D-85296BD8136A@cisco.com>
Cc: lsr <lsr@ietf.org>, "draft-ietf-lsr-ospfv3-srv6-extensions@ietf.org" <draft-ietf-lsr-ospfv3-srv6-extensions@ietf.org>
To: "Acee Lindem (acee)" <acee=40cisco.com@dmarc.ietf.org>
References: <3FC4BE76-5D3A-405F-B81D-85296BD8136A@cisco.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/1qYvpM8GrtkY3faCfHVEh_OP6xU>
Subject: Re: [Lsr] Working Group Last Call for "OSPFv3 Extensions for SRv6" - draft-ietf-lsr-ospfv3-srv6-extensions-06.txt (Corrected Address)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Aug 2022 23:52:19 -0000

I support progressing this draft. 

I have the following minor comments for the authors to consider:

The title of Section 4 of this draft is “Advertisement of SRH Operation Limits”, and really it only covers the advertisements of MSDs, so may consider to change the title to be consistent with the ISIS SRv6 extensions draft, "Advertising Maximum SRv6 SID Depths”.
The subsections in section 4 are almost identical to the subsections in draft-ietf-lsr-isis-srv6-extesions. It’s up to the authors and the WG to decide whether to keep this duplicate.
In draft-ietf-lsr-isis-srv6-extensions, “topology/algorithm” is used, and it’s not consistently used in this draft. For example, in section 5 the second paragraph, only “algorithm” is used, while “topology/algorithm” is used later.

Nits (line numbers are from idnits):
208	   the SR Algorithm TLV defined in [RFC8665] as described in [RFC8666]
SR Algorithm/SR-Algorithm  Please add a “-“ to be consistent with RFC 8665.

355	   The SRv6 Locator LSA has a function code of TBD while the S1/S2 bits
“TBD” should be replaced with “42” as in IANA considerations. 

Thanks,
Yingzhen


> On Jul 29, 2022, at 10:16 AM, Acee Lindem (acee) <acee=40cisco.com@dmarc.ietf.org> wrote:
> 
> As promised in today’s LSR WG meeting, this begins a 3 week WG Last Call, ending on August 19th, 2022, for draft-ietf-lsr-ospfv3-srv6-extensions. The extra week is to account for PIST (Post-IETF Stress Syndrome). The corresponding IS-IS draft is already on the RFC Queue and there are implementations.
>  
>     https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-srv6-extensions/ <https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-srv6-extensions/>
>  
>  
> Thanks,
> Acee & Chris
>  
>  
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org <mailto:Lsr@ietf.org>
> https://www.ietf.org/mailman/listinfo/lsr <https://www.ietf.org/mailman/listinfo/lsr>