Re: [Lsr] New Version Notification for draft-xu-lsr-flooding-reduction-in-clos-01.txt

Vasilenko Eduard <vasilenko.eduard@huawei.com> Tue, 28 November 2023 11:13 UTC

Return-Path: <vasilenko.eduard@huawei.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A5C3C14CE53 for <lsr@ietfa.amsl.com>; Tue, 28 Nov 2023 03:13:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.904
X-Spam-Level:
X-Spam-Status: No, score=-6.904 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BvuNTRuNoU9M for <lsr@ietfa.amsl.com>; Tue, 28 Nov 2023 03:13:42 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C4C19C14CF05 for <lsr@ietf.org>; Tue, 28 Nov 2023 03:13:41 -0800 (PST)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Sffpp1vvmz67HLW; Tue, 28 Nov 2023 19:09:06 +0800 (CST)
Received: from mscpeml500004.china.huawei.com (unknown [7.188.26.250]) by mail.maildlp.com (Postfix) with ESMTPS id E0130140D27; Tue, 28 Nov 2023 19:13:37 +0800 (CST)
Received: from mscpeml500004.china.huawei.com (7.188.26.250) by mscpeml500004.china.huawei.com (7.188.26.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Tue, 28 Nov 2023 14:13:37 +0300
Received: from mscpeml500004.china.huawei.com ([7.188.26.250]) by mscpeml500004.china.huawei.com ([7.188.26.250]) with mapi id 15.02.1258.028; Tue, 28 Nov 2023 14:13:37 +0300
From: Vasilenko Eduard <vasilenko.eduard@huawei.com>
To: Jeff Tantsura <jefftant.ietf@gmail.com>, Robert Raszuk <robert@raszuk.net>
CC: Acee Lindem <acee.ietf@gmail.com>, "Les Ginsberg (ginsberg)" <ginsberg=40cisco.com@dmarc.ietf.org>, Tony Li <tony.li@tony.li>, "xuxiaohu_ietf@hotmail.com" <xuxiaohu_ietf@hotmail.com>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: [Lsr] New Version Notification for draft-xu-lsr-flooding-reduction-in-clos-01.txt
Thread-Index: AQHaHPUnseizL3oU0E+32ATrqZg+dbCIGjoDgAADbXSAAi1pgIAClIiAgAAZAYCAAAuNgIABo5uAgADnn7A=
Date: Tue, 28 Nov 2023 11:13:37 +0000
Message-ID: <9751238b5e514208994ad13b969f857e@huawei.com>
References: <CAOj+MMH_7PSdNRsSzAhN7hbB_QyyrKO3i-4EYt-0e2EKtvT3Tg@mail.gmail.com> <1F10AE52-C87C-4245-A034-81D8110623C6@gmail.com>
In-Reply-To: <1F10AE52-C87C-4245-A034-81D8110623C6@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.199.56.242]
Content-Type: multipart/alternative; boundary="_000_9751238b5e514208994ad13b969f857ehuaweicom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/KEeYZwtFYnGlmsng6GlFyuYUlnA>
Subject: Re: [Lsr] New Version Notification for draft-xu-lsr-flooding-reduction-in-clos-01.txt
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2023 11:13:46 -0000

Hi Jeff,
5 topology hops is 5/3->66% worse than 3 hops for latency, reliability, and cost.
Why do you assume 5 hops if the needed scale is possible to achieve by 3 hops?
In fact, modern 1-ASIC switches (4.8Tbps, 51.2Tbps) permit 390k 100GE end-points for Megafly 3-hops topology (with 50% oversubscription) or 195k*100GE wire-speed.
Warning: Megafly in general demands equal load distribution at the application level – this restriction always exists for full mesh instead of centralized boxes.
PS: You said “stage” which probably means that the Server/Processor port is not included in the hops calculation. 3 topology hops with end-points are 5 hops overall.
Eduard
From: Lsr [mailto:lsr-bounces@ietf.org] On Behalf Of Jeff Tantsura
Sent: Tuesday, November 28, 2023 2:32 AM
To: Robert Raszuk <robert@raszuk.net>
Cc: Acee Lindem <acee.ietf@gmail.com>; Les Ginsberg (ginsberg) <ginsberg=40cisco.com@dmarc.ietf.org>; Tony Li <tony.li@tony.li>; xuxiaohu_ietf@hotmail.com; lsr@ietf.org
Subject: Re: [Lsr] New Version Notification for draft-xu-lsr-flooding-reduction-in-clos-01.txt

Robert,

In context of LLM (10% of that for DLRM) training clusters, towards 2024/25 we would be looking to up to 8K end-points in a 3 stage leaf-spine fabric and up to 64-256K in 5 stages.
Virtualization and how it is instantiated might significantly change amount/distribution of state in underlay/overlay.

Obviously, these are hyperscale size deployments, many will be running 10-30 switches fabrics, where anything could work.
BGP seems to work just fine, some data plane signaling could be used as a near real time augmentation to “slow but stable” control plane.

Cheers,
Jeff


On Nov 26, 2023, at 14:30, Robert Raszuk <robert@raszuk.net<mailto:robert@raszuk.net>> wrote:

Hey Jeff,

Could you be so kind and defined term: "scaled-out leaf-spine fabrics" ?

Specifically folks watching us here would highly appreciate if we state max target nodes with vanilla ISIS and max target nodes when your ISIS implementation supports draft-ietf-lsr-dynamic-flooding<https://datatracker.ietf.org/doc/html/draft-ietf-lsr-dynamic-flooding>

While I am a BGP person I feel pretty strongly that BGP is not a best fit for the vast majority of DC fabrics in use today.

Cheers,
Robert


On Sun, Nov 26, 2023 at 10:49 PM Jeff Tantsura <jefftant.ietf@gmail.com<mailto:jefftant.ietf@gmail.com>> wrote:
I agree with all aforementioned comments.

Wrt AI/ML networking - if a controller is used, what is required is link state exposure northbound and not link state protocol  in the fabric. (I could argue for RIFT though ;-))
I’d urge you to take a look at Meta’s deployment  in their ML clusters (publicly available) - they use BGP as the routing protocol to exchange reachability (and build ECMP sets) and provide a backup if controller computed next hop goes away/before new one has been computed.
Open R is used northbound to expose the topology (in exactly same way - BGP-LS could be used).

To summarize: an LS protocol brings no additional value in scaled-out leaf-spine fabrics, without significant modifications -  it doesn’t work in irregular topologies such as DF, etc.
Existing proposals - there are shipping implementations and experience in operating it, have proven their relative value in suitable deployments.

Cheers,
Jeff

> On Nov 26, 2023, at 12:20, Acee Lindem <acee.ietf@gmail.com<mailto:acee.ietf@gmail.com>> wrote:
>
> Speaking as WG member:
>
> I agree. The whole Data Center IGP flooding discussion went on years ago and the simplistic enhancement proposed in the subject draft is neither relevant or useful now.
>
> Thanks,
> Acee
>
>> On Nov 24, 2023, at 11:55 PM, Les Ginsberg (ginsberg) <ginsberg=40cisco.com@dmarc.ietf.org<mailto:40cisco.com@dmarc.ietf.org>> wrote:
>>
>> Xiaohu –
>> I also point out that there are at least two existing drafts which specifically address IS-IS flooding reduction in CLOS networks and do so in greater detail and with more robustness than what is in your draft:
>> https://datatracker.ietf.org/doc/draft-ietf-lsr-distoptflood/
>> https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-spine-leaf-ext/
>> I do not see a need for yet another draft specifically aimed at CLOS networks.
>> Note that work on draft-ietf-lsr-isis-spine-leaf-ext was suspended due to lack of interest in deploying an IGP solution in CLOS networks.
>> You are suggesting in draft-xu-lsr-fare that AI is going to change this. Well, maybe, but if so I think we should return to the solutions already available and prioritize work on them.
>>    Les
>>  From: Lsr <lsr-bounces@ietf.org<mailto:lsr-bounces@ietf.org>> On Behalf Of Tony Li
>> Sent: Thursday, November 23, 2023 8:39 AM
>> To: xuxiaohu_ietf@hotmail.com<mailto:xuxiaohu_ietf@hotmail.com>
>> Cc: lsr@ietf.org<mailto:lsr@ietf.org>
>> Subject: Re: [Lsr] New Version Notification for draft-xu-lsr-flooding-reduction-in-clos-01.txt
>> Hi,
>> What you’re proposing is already described in IS-IS Mesh Groups (https://www.rfc-editor.org/rfc/rfc2973.html) and improved upon in Dynamic Flooding (https://datatracker.ietf.org/doc/html/draft-ietf-lsr-dynamic-flooding).
>> Regards,
>> Tony
>>
>>
>> On Nov 23, 2023, at 8:29 AM, xuxiaohu_ietf@hotmail.com<mailto:xuxiaohu_ietf@hotmail.com> wrote:
>> Hi all,
>> Any comments or suggestions are welcome.
>> Best regards,
>> Xiaohu
>> 发件人: internet-drafts@ietf.org<mailto:internet-drafts@ietf.org> <internet-drafts@ietf.org<mailto:internet-drafts@ietf.org>>
>> 日期: 星期三, 2023年11月22日 11:37
>> 收件人: Xiaohu Xu <xuxiaohu_ietf@hotmail.com<mailto:xuxiaohu_ietf@hotmail.com>>
>> 主题: New Version Notification for draft-xu-lsr-flooding-reduction-in-clos-01.txt
>> A new version of Internet-Draft draft-xu-lsr-flooding-reduction-in-clos-01.txt
>> has been successfully submitted by Xiaohu Xu and posted to the
>> IETF repository.
>>
>> Name:     draft-xu-lsr-flooding-reduction-in-clos
>> Revision: 01
>> Title:    Flooding Reduction in CLOS Networks
>> Date:     2023-11-22
>> Group:    Individual Submission
>> Pages:    6
>> URL:      https://www.ietf.org/archive/id/draft-xu-lsr-flooding-reduction-in-clos-01.txt
>> Status:   https://datatracker.ietf.org/doc/draft-xu-lsr-flooding-reduction-in-clos/
>> HTMLized: https://datatracker.ietf.org/doc/html/draft-xu-lsr-flooding-reduction-in-clos
>> Diff:     https://author-tools.ietf.org/iddiff?url2=draft-xu-lsr-flooding-reduction-in-clos-01
>>
>> Abstract:
>>
>>   In a CLOS topology, an OSPF (or ISIS) router may receive identical
>>   copies of an LSA (or LSP) from multiple OSPF (or ISIS) neighbors.
>>   Moreover, two OSPF (or ISIS) neighbors may exchange the same LSA (or
>>   LSP) simultaneously.  This results in unnecessary flooding of link-
>>   state information, which wastes the precious resources of OSPF (or
>>   ISIS) routers.  Therefore, this document proposes extensions to OSPF
>>   (or ISIS) to reduce this flooding within CLOS networks.  The
>>   reduction of OSPF (or ISIS) flooding is highly beneficial for
>>   improving the scalability of CLOS networks.
>>
>>
>>
>> The IETF Secretariat
>>
>> _______________________________________________
>> Lsr mailing list
>> Lsr@ietf.org<mailto:Lsr@ietf.org>
>> https://www.ietf.org/mailman/listinfo/lsr
>> _______________________________________________
>> Lsr mailing list
>> Lsr@ietf.org<mailto:Lsr@ietf.org>
>> https://www.ietf.org/mailman/listinfo/lsr
>
>
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org<mailto:Lsr@ietf.org>
> https://www.ietf.org/mailman/listinfo/lsr

_______________________________________________
Lsr mailing list
Lsr@ietf.org<mailto:Lsr@ietf.org>
https://www.ietf.org/mailman/listinfo/lsr