Re: [Lsr] [Technical Errata Reported] RFC5838 (7644)

Acee Lindem <acee.ietf@gmail.com> Mon, 18 September 2023 12:12 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D0F8C1516F2 for <lsr@ietfa.amsl.com>; Mon, 18 Sep 2023 05:12:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UapLOnOo-kK2 for <lsr@ietfa.amsl.com>; Mon, 18 Sep 2023 05:12:44 -0700 (PDT)
Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9BE22C151988 for <lsr@ietf.org>; Mon, 18 Sep 2023 05:12:44 -0700 (PDT)
Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-65649b49ff1so9049456d6.3 for <lsr@ietf.org>; Mon, 18 Sep 2023 05:12:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695039163; x=1695643963; darn=ietf.org; h=to:references:message-id:reply-to:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k5UzraIngV/Z6JpMFmNeidjgcSwyt8uS1nXPdOFPtP4=; b=QBXnXFUi8CFH7mEw6DaT0HVATOTUc4fOlTQ8vl3KUMsAG6evfeknX5K3ACnaXr5CQI V7EbUOJ17BeB2SgqG+TT+2J+3/U+u0A4fN3fJcwAWkU7vlZznnJXwzlvaj8swP1HlcXp Ah2veO5jnisqDdHCVDzaBo6RN0p5nTG7vWFnZjys6/RIXprovT+n+8qx3nS+Iq6lsAfT brPWaKDuolroiifKzDV7+2Be21LAxC8mmSrV+x3gTne69XrUz0aDEhMs4U8xMChWqS6G wPMqqJ9KcFVH7cqZpB2uAn/M0AfSPU2X8G8pVu8VSorTGGBKZQ0ZJhm8zbtE6tIoYfSs Fr+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695039163; x=1695643963; h=to:references:message-id:reply-to:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k5UzraIngV/Z6JpMFmNeidjgcSwyt8uS1nXPdOFPtP4=; b=n1+9Y7593D+vdUh6DIIGqGfq7Uctd2iZoej+iXKcbR4gJc5SI8YPKLKPat6ms+6p1C jvASXtcl4V+HNi1G+rHH6qUfPCLaUqvLlgplAEvheOp/z8dy1t9M87q/SzGK7cqbGPrT ZiANUFCOHqBTjOACIBWs7JA+ozLXqBkRPGQtsrCBWD1IajaJzdtk51ki54NA3qHq671H i5+5Ry0rdMlCUGjV1RaW+Iy3sY87jLZhtxz14+ulyAxCuO9VTI2dTO4jieW8ArLGmDbD WZbF7us0mIQvX5kclfMTN2/PPgFdltYeuh3BP1QbEH1qpnsBldKqK9lsz0KpCUhramot M34w==
X-Gm-Message-State: AOJu0YyW173gI8Kz5LXpDLJH5JCIFHxr5A8swKinXNTfG7c4Ls7I77DB gRtvQnMy786G875J1MKxGPQ=
X-Google-Smtp-Source: AGHT+IHjx0G8yWEhilhrEvhHZoArw3QNkdoMgXSB4NRRmvg1/UB8Dij3fcl5n9QU0BGCJP7wCunx/g==
X-Received: by 2002:a0c:b24e:0:b0:655:dccc:9789 with SMTP id k14-20020a0cb24e000000b00655dccc9789mr8238317qve.28.1695039162972; Mon, 18 Sep 2023 05:12:42 -0700 (PDT)
Received: from smtpclient.apple ([2605:a601:9199:bf00:bc32:6641:618b:d730]) by smtp.gmail.com with ESMTPSA id q8-20020a0cf5c8000000b00656526862f1sm20563qvm.66.2023.09.18.05.12.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Sep 2023 05:12:42 -0700 (PDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_7423D86C-B899-429E-B5AF-BD4708E16B6C"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <CAOj+MMFe9Ku0CwQPQN0qtUKeB1eCFmNRuGYjOqzVN1jObZq1JA@mail.gmail.com>
Date: Mon, 18 Sep 2023 08:12:31 -0400
Cc: Owen DeLong <owen@delong.com>, RFC Errata System <rfc-editor@rfc-editor.org>, smirtora@cisco.com, akr@cisco.com, mjbarnes@cisco.com, rahul@juniper.net, Alvaro Retana <aretana.ietf@gmail.com>, John Scudder <jgs@juniper.net>, Andrew Alston - IETF <andrew-ietf@liquid.tech>, lsr <lsr@ietf.org>
Reply-To: Yingzhen Qu <yingzhen.qu@futurewei.com>
Message-Id: <F1B6EBA5-31EE-4715-B641-E3C51CB36596@gmail.com>
References: <20230917195809.395BC7FDC1@rfcpa.amsl.com> <B42F42AB-7440-48B4-A57D-0BCA57543609@gmail.com> <3E1C5E0C-FDCD-4F43-A12A-2224B187D6AB@delong.com> <5880DC25-B7A2-495B-94E5-919A3E219F31@gmail.com> <CAOj+MMFe9Ku0CwQPQN0qtUKeB1eCFmNRuGYjOqzVN1jObZq1JA@mail.gmail.com>
To: Robert Raszuk <robert@raszuk.net>
X-Mailer: Apple Mail (2.3731.700.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/WKfL9PR7zrPU15MQKobI0Ht1C7Q>
Subject: Re: [Lsr] [Technical Errata Reported] RFC5838 (7644)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2023 12:12:49 -0000

Hi Robert, 



> On Sep 18, 2023, at 07:50, Robert Raszuk <robert@raszuk.net> wrote:
> 
> Acee,
> 
> I agree with your assessment. 
> 
> But looking at the RFC I would say it is missing a Terminology section. If such section would clearly define meaning of virtual link in the context of this RFC there would be no ambiguity. 
> 
> Otherwise those not skilled in OSPF art may take a document and apply casual meaning to virtual link (which does indeed include a tunnel of any sort :). 
> 
> Of course this entire RFC is about OSPFv3 so this should be very intuitive to read it in such context not as casual IETF issued paper. 

Right. 

> 
> If any errara is needed here IMHO is just to add terminology section unless there is some formal definition that in all IETF RFCs terms apply only to the context of given subject doc. I am honestly not sure if there is one. 

I believe you could take almost any Routing RFC and improve it with editing and the addition of more context. This was clearly the case for https://datatracker.ietf.org/doc/draft-ietf-rtgwg-vrrp-rfc5798bis/

This started out as a respin of the document for inclusive language but I also made significant edits to improve the readability (as well as address errata and other minor errors). After that, I received some really good input from reviewers (e.g., Quentin Arimitage provided around 70 comments and suggestions, most of which were incorporated). 

However, improvements such as these are usually not done with an Errata. 

Thanks,
Acee



> 
> Thx,
> R.
> 
> On Mon, Sep 18, 2023 at 1:27 PM Acee Lindem <acee.ietf@gmail.com <mailto:acee.ietf@gmail.com>> wrote:
>> 
>> 
>> > On Sep 17, 2023, at 22:07, Owen DeLong <owen@delong.com <mailto:owen@delong.com>> wrote:
>> > 
>> > You say they are unnecessary, then why do we have vendors doing this wrong and pointing to this requirement of the RFC as their reason for doing so?
>> > 
>> > While there may be a valid argument that they shouldn’t be necessary, I would argue that real world implementation experience suggests that they are
>> > most definitely necessary and are a minor edit to provide additional clarity.
>> 
>> An OSPF virtual link and a tunnel (e.g., GRE tunnel) are totally different constructs. The vendor is incorrect in arguing that this text specifics operation over a GRE tunnel. Rather, they should be arguing that OSPF doesn’t have any path MTU capabilities and since a tunnel can be multi-hop, OSPF doesn’t know the MTU. 
>> 
>> Thanks,
>> Acee
>> 
>> 
>> > 
>> > Are you really arguing to preserve ambiguous language when the problem is so easy to solve?
>> > 
>> > Owen
>> > 
>> > 
>> > 
>> >> On Sep 17, 2023, at 15:25, Acee Lindem <acee.ietf@gmail.com <mailto:acee.ietf@gmail.com>> wrote:
>> >> 
>> >> Given that the context of the “Interface MTU” is specifically the “interface MTU” field in OSPFv3 Database Description packets and OSPF virtual links (RFC 2328), the additions recommended in this Errata are unnecessary. The Errata should be rejected. 
>> >> 
>> >> Thanks,
>> >> Acee
>> >>> On Sep 17, 2023, at 15:58, RFC Errata System <rfc-editor@rfc-editor.org <mailto:rfc-editor@rfc-editor.org>> wrote:
>> >>> 
>> >>> The following errata report has been submitted for RFC5838,
>> >>> "Support of Address Families in OSPFv3".
>> >>> 
>> >>> --------------------------------------
>> >>> You may review the report below and at:
>> >>> https://www.rfc-editor.org/errata/eid7644
>> >>> 
>> >>> --------------------------------------
>> >>> Type: Technical
>> >>> Reported by: Owen DeLong <owen@delong.com <mailto:owen@delong.com>>
>> >>> 
>> >>> Section: 2.7
>> >>> 
>> >>> Original Text
>> >>> -------------
>> >>> Interface MTU
>> >>>    The size in octets of the largest address family specific datagram
>> >>>    that can be sent on the associated interface without
>> >>>    fragmentation.  The MTUs of common Internet link types can be
>> >>>    found in Table 7-1 of [MTUDISC].  The Interface MTU SHOULD be set
>> >>>    to 0 in Database Description packets sent over virtual links.
>> >>> 
>> >>> 
>> >>> Corrected Text
>> >>> --------------
>> >>> Interface MTU
>> >>>    The size in octets of the largest address family specific datagram
>> >>>    that can be sent on the associated interface without
>> >>>    fragmentation.  The MTUs of common Internet link types can be
>> >>>    found in Table 7-1 of [MTUDISC].  The Interface MTU SHOULD be set
>> >>>    to 0 in Database Description packets sent over (OSPF3) virtual links.
>> >>>    This recommendation MUST NOT be applied to tunnel and other virtual
>> >>>    or software interfaces which carry traffic other than OSPF protocol packets.
>> >>> 
>> >>> Notes
>> >>> -----
>> >>> Currently, the language is ambiguous and at least one vendor has implemented OSPF3 sending an MTU of zero on GRE interfaces (and possibly others such as IPIP, IPSEC, etc., as I have not tested these). I believe that the intent of the RFC is to refer strictly to OSPF virtual-links which carry only OSPF protocol data and therefore have no meaningful MTU. When this is mistakenly applied to other forms of "virtual" interfaces such as tunnels, the results can be quite harmful.
>> >>> 
>> >>> As such, I think that clarification is in order, since the vendor in question is unrepentant and claims their current implementation to be compliant with the RFC.
>> >>> 
>> >>> Instructions:
>> >>> -------------
>> >>> This erratum is currently posted as "Reported". If necessary, please
>> >>> use "Reply All" to discuss whether it should be verified or
>> >>> rejected. When a decision is reached, the verifying party  
>> >>> can log in to change the status and edit the report, if necessary. 
>> >>> 
>> >>> --------------------------------------
>> >>> RFC5838 (draft-ietf-ospf-af-alt-10)
>> >>> --------------------------------------
>> >>> Title               : Support of Address Families in OSPFv3
>> >>> Publication Date    : April 2010
>> >>> Author(s)           : A. Lindem, Ed., S. Mirtorabi, A. Roy, M. Barnes, R. Aggarwal
>> >>> Category            : PROPOSED STANDARD
>> >>> Source              : Open Shortest Path First IGP
>> >>> Area                : Routing
>> >>> Stream              : IETF
>> >>> Verifying Party     : IESG
>> >>> 
>> >>> _______________________________________________
>> >>> Lsr mailing list
>> >>> Lsr@ietf.org <mailto:Lsr@ietf.org>
>> >>> https://www.ietf.org/mailman/listinfo/lsr
>> >> 
>> > 
>> 
>> _______________________________________________
>> Lsr mailing list
>> Lsr@ietf.org <mailto:Lsr@ietf.org>
>> https://www.ietf.org/mailman/listinfo/lsr