Re: [Lsr] WG Last Call for draft-ietf-lsr-ospfv3-extended-lsa-yang

[Acee Lindem <[e-mail]>]

Hi Tom, 

Thanks for the review. 

> On Aug 21, 2023, at 06:57, tom petch <[e-mail]> wrote:
> 
> From: Lsr <[e-mail]> on behalf of Christian Hopps <[e-mail]>
> Sent: 19 August 2023 01:26
> 
> This begins a 2 week WG Last Call, ending Sep 1, 2023, for:
> 
>  https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/
> 
> <tp>
> Some stray thoughts from a quick look at -22
> 
> **   It is an augmentation of the OSPF base model provided support for
> perhaps provides
> 
>             /ospf:ospfv3/ospf:body:
> I have forgotten what that final colon does but it is not in the YANG
> 
> OLD
>             |  +--ro prefix-options
>             |  |  +--ro prefix-options*   identityref
> NEW
>             |  +--ro prefix-options
>             |  |  +--ro prefix-option*   identityref
> might be clearer with the singular

This is a leaf-list of options. One can debate whether it would be cleaner if it were singular. However, this is moot point as this is from RFC 9129. 

> 
>     identity ospfv3-e-inter-area-router-lsa {
> ...
>       reference
>         "RFC 8362: OSPFv3 Link State Advertisement (LSA)
>          Extensibility, Section 4.3";
> Section 4.4 I think
> I have not checked to see which section the data objects relate to

Fixed. 

> 
>       description
>         "Intra-Area Prefix TLV Grouping";
>       reference
>         "RFC 8362: OSPFv3 Link State Advertisement (LSA)
>          Extensibility, Section 3.4";
> Section  3.7 I think
> I have not checked to see which section the data objects relate to

Fixed. 



> 
>         reference
>           "RFC 8362: OSPFv3 Link State Advertisement (LSA)
>            Extensibility, Appendix B - AreaExtendedLSASupport";
> (twice)
> Appendix B is Area Configuration Parameters

Fixed. 

Thanks,
Acee

> 
> Tom Petch
> 
> Authors,
> 
> Please indicate to the list, your knowledge of any IPR related to this work.
> 
> Thanks,
> Chris.
>