Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

["Acee Lindem (acee)" <[e-mail]>]

Hi Alvaro,
I believe version -23 addresses your comments. For “config true” timers leaves, I couldn’t use the ietf-routing-types.yang types since the union included “infinity” and “not-set” which aren’t really applicable. I did use the RFC8294 types for “config false” timers.

https://datatracker.ietf.org/doc/draft-ietf-ospf-yang/

Thanks,
Acee
P.S. I did lose some changes that I hadn’t checked into GitHub. Hopefully, I’ve reconstructed them correctly.

From: Alvaro Retana <[e-mail]>
Date: Thursday, June 27, 2019 at 7:55 AM
To: Acee Lindem <[e-mail]>, "[e-mail]" <[e-mail]>
Cc: "[e-mail]" <[e-mail]>, Stephane Litkowski <[e-mail]>, "[e-mail]" <[e-mail]>
Subject: Re: AD Review for draft-ietf-ospf-yang-21




On June 26, 2019 at 9:31:05 PM, Acee Lindem (acee) ([e-mail]<mailto:[e-mail]>) wrote:

...

...

3936       leaf dead-timer {

3937         type uint32;

3938         units "seconds";

3939         config false;

3940         description "This timer tracks the remaining time before

3941                      the neighbor is declared dead.";

3942       }



[major] For *-timer: Is tracking the remaining time in seconds enough?  I would assume that ms would be the right unit.  Why seconds?

<acee> Because sub-second hellos was a bad idea – three words: B-F-D…'

This question is not about sub-second Hellos…it’s about the *remaining time*.  Even if Hellos are x seconds apart, the “remaining time before the neighbor is declared dead” can still be in ms, right?  Why not?  Note that there are other places in the model that are characterized as tracking the remaining time.

I don’t feel that strongly. However, it would seem that one would use the same granularity as the configuration. No?

I wouldn’t think so.  If I was an operator I would like to know if there are 500ms left before my neighbor dies, and not just 1 or 0.  I think this may also be useful for troubleshooting.

But I’m not an operator…

Alvaro.

We found that the RFC 8294 timer types aren’t good for “config true” values since the values “infinity” and “not-set” are included in the union. Hence, they lend themselves better to operational state than configurable values.