[Lsr] Murray Kucherawy's Discuss on draft-ietf-isis-te-app-14: (with DISCUSS and COMMENT)

Murray Kucherawy via Datatracker <noreply@ietf.org> Mon, 08 June 2020 19:29 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: lsr@ietf.org
Delivered-To: lsr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DEF333A0F4F; Mon, 8 Jun 2020 12:29:31 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Murray Kucherawy via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-isis-te-app@ietf.org, lsr-chairs@ietf.org, lsr@ietf.org, Acee Lindem <acee@cisco.com>, aretana.ietf@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.2.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Murray Kucherawy <superuser@gmail.com>
Message-ID: <159164457188.13461.3876956617720302557@ietfa.amsl.com>
Date: Mon, 08 Jun 2020 12:29:31 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/gtPQhagJhskdzgfeMRXL8yIoq_g>
Subject: [Lsr] Murray Kucherawy's Discuss on draft-ietf-isis-te-app-14: (with DISCUSS and COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2020 19:29:32 -0000

Murray Kucherawy has entered the following ballot position for
draft-ietf-isis-te-app-14: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-isis-te-app/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

An easy one:

Sections 7.3 and 7.5 create new IANA registries with "Expert Review" rules, but
Section 7.5 provides no particular guidance to the Designated Expert about how
to review applications, as required by Section 4.5 of BCP 26.


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Since this document is in many parts a copy of
draft-ietf-ospf-te-link-attr-reuse, I'm only reviewing this delta between them
here:
https://www.ietf.org/rfcdiff?url1=draft-ietf-ospf-te-link-attr-reuse-14&url2=draft-ietf-isis-te-app-14

Section 2:
* "... expected to continue - so any discussion ..." -- change to "... expected
to continue.  Therefore, any discussion ..." * "... key points identified in
the introduction - which are:" -- change hyphen to a comma

Section 3:
* "... advertisements include sub-TLVs for TLVs ..." -- Please define or expand
"TLV" on first use. * Please just name the registries, rather than giving
multi-line URLs to them.

Section 3.1:
* As with the matching OSPF document, I don't see the benefit of citing current
registry contents rather than just referencing the registry.

Section 4.3:
* Interestingly, the entries for IPv4 are not capitalized (e.g., "interface
address"), but they are for IPv6 (e.g., "Interface Address").

Section 6.3.2:
* These two paragraphs read like they're in the wrong order.

Sections 7.1 and 7.2:
* These should refer back to Sections 4.2 and 4.3, respectively, where the new
values are fully described.