Re: [Lsr] AD Review of draft-ietf-isis-te-app-09

Alvaro Retana <aretana.ietf@gmail.com> Fri, 10 January 2020 18:22 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80B51120B40; Fri, 10 Jan 2020 10:22:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r0SPHZ7AjIzR; Fri, 10 Jan 2020 10:22:02 -0800 (PST)
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F02751200FF; Fri, 10 Jan 2020 10:22:01 -0800 (PST)
Received: by mail-ed1-x52e.google.com with SMTP id m8so2411211edi.13; Fri, 10 Jan 2020 10:22:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=KHl0pW0Y1T36ytzGlVJaKDWFtRNhcWYiWojqhp6LZsY=; b=dgj8aXFpm7e/c1LoHccZCZKa/b3u3JP0vtzus39sdb6amNuILvd0xSEISXpUlaw8g2 cCk7XltCx6EIfIfzpFbyWWWwWt8ZpP3nh1RdW97DhM8MMMbGcy4n4YppyhuVb1qyyHIy CnT337xn8lu5v1TsOY+5pMClrv+k2a9rAJ8JH1cWRMVSADxNLxasAzXT+gGZBbE94hZH 3iXYTIWX9lEnr4gHPjkMx7k2mtAla8mTsmxVX3vMoP1jz2tfNHgqQorCFtp8hRgvM12U suQXb12/gWMTu1YFv4oewircAMOQbte8T1xPCUfQCXQXK+xkEVTImaukYq325shiBrP1 AzBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=KHl0pW0Y1T36ytzGlVJaKDWFtRNhcWYiWojqhp6LZsY=; b=hXByyF1eOB3xSEhgWLY33xs88hLmOC0Ui5QkXV23nZqjoFwQNey11n7BTqwhim7M4y /gdF1oEglmHofW/G/e8TXvxGnFAcEGISzWKu3yA4XRivzv7Hbi9GVxahG4L+kzRrAVwk XozhFicogdU7WYt1mbhDkEmtgFqcZxmwgDpDiSRT6gEqfaEma1zcmL0vCvZ9Y9nYuj6g GsLi6LxoVrdRPliK31J/8RVgxyK2sHHlkEPbWuRhHEtnVLBI+3BMa6Ym4SwzofEildt2 ILXOB3o3HDwYmK0rtu5oiYeZxsDOInc2XYb8zeG9XeNQRlh98Su2ohleP0v8YXphJ92T xpaQ==
X-Gm-Message-State: APjAAAW+M7hCFR1eEziSQFfZlXW0HaKPWUX7miuw/32KXn85rCHlFkFF fUk2jWNMUAutONdedGNrnBA2WXzQynjCJURVxeNF6w==
X-Google-Smtp-Source: APXvYqxVrVYi1Mi5oIETankbWi+24AdEaQet55wEA+4jGO3sucObrUqkp+j4cvePnhMfqN6BGosgsNTApq9IWYTRTfg=
X-Received: by 2002:a50:aacd:: with SMTP id r13mr4953581edc.129.1578680520567; Fri, 10 Jan 2020 10:22:00 -0800 (PST)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Fri, 10 Jan 2020 10:21:59 -0800
From: Alvaro Retana <aretana.ietf@gmail.com>
In-Reply-To: <MWHPR11MB16169C35A8AF297CF4A044D5C1380@MWHPR11MB1616.namprd11.prod.outlook.com>
References: <CAMMESswTr=qepRXrUEJp1AUhwD5RJ49pg=wUs9gLy5ZLYhD8ug@mail.gmail.com> <MWHPR11MB16169C35A8AF297CF4A044D5C1380@MWHPR11MB1616.namprd11.prod.outlook.com>
MIME-Version: 1.0
Date: Fri, 10 Jan 2020 10:21:59 -0800
Message-ID: <CAMMESswFSE2=fbuAgPj8HrYK2fpGrQsd2fFyFf0zczy_A9JOVQ@mail.gmail.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, "draft-ietf-isis-te-app@ietf.org" <draft-ietf-isis-te-app@ietf.org>
Cc: "Acee Lindem (acee)" <acee@cisco.com>, "lsr@ietf.org" <lsr@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/ijhMKD6nrgCTXSZyWK-S6OrObio>
Subject: Re: [Lsr] AD Review of draft-ietf-isis-te-app-09
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jan 2020 18:22:03 -0000

On January 10, 2020 at 10:53:40 AM, Les Ginsberg wrote:

Les:

Hi!

> We are working on addressing your comments - but it will take us a bit of
> time to complete that - please be patient.

You have all been very patient with me already -- I can only return
the favor. :-)


> One question. In several places you are requesting a forward reference to the
> IANA Considerations section. For example in Section 4.1.
> I find this ask rather unusual.
> Section 4.1 is defining the format of some fields in the new sub-TLV. What
> would be the need of a forward reference to the IANA section?
> I cannot recall ever doing the equivalent in any draft I have worked on.


231	4.1.  Application Identifier Bit Mask

233	  Identification of the set of applications associated with link
234	  attribute advertisements utilizes two bit masks.  One bit mask is for
235	  standard applications where the definition of each bit is defined in
236	  a new IANA controlled registry.  A second bit mask is for non-
237	  standard User Defined Applications(UDAs).

In this case, there is a mention in the text about the new registry --
I thought it would be useful to the reader to have a pointer to where
the values are.

The comment was meant just as a suggestion.

Alvaro.