Re: [Lsr] Comments on draft-ietf-lsr-distoptflood-01

Antoni Przygienda <prz@juniper.net> Fri, 10 March 2023 20:55 UTC

Return-Path: <prz@juniper.net>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7587BC15153D; Fri, 10 Mar 2023 12:55:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.796
X-Spam-Level:
X-Spam-Status: No, score=-2.796 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b="sgaNXLUI"; dkim=pass (1024-bit key) header.d=juniper.net header.b="MILl2g4Z"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c7Hi2r6G00_K; Fri, 10 Mar 2023 12:55:26 -0800 (PST)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 77294C1516EB; Fri, 10 Mar 2023 12:55:23 -0800 (PST)
Received: from pps.filterd (m0108156.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32ACvWtf004899; Fri, 10 Mar 2023 12:55:16 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=w5gGz6cSKDvk25aehyZc1SnRVZIaU21E4hLAX+zdA44=; b=sgaNXLUIK5jlwzQ/gQKw3omNeNnbylcME7tzy7kOV+YrkOZZ42RiAcKdDP+h58BrRzHt xFB6XEldH+IBZdz3QUyWhvQxgMx2cIRppPv48jrDRoG12XvSjKP487k4a2vW1i9Ukp5H M63kSvdOSuL8VsBCwqeHF6+3wyj7m6P+7LfPvxPptOEEfsPUVTpaxuVBthzbRvQurTeo IxOmfXgWIoXNu8xezjHWCcT+RWGW6wyS5YgRvbJS9/VFxws7EAiP0NVzBvLOUugrZUS2 SqfqS9Lc6O5VISqwjFqfC0sNmPHRrFwt3QXV0pSMP7o2468bBvHXZT+z+zNiTKA9bhd/ nQ==
Received: from bl0pr02cu006-vft-obe.outbound.protection.outlook.com (mail-eastusazlp17013035.outbound.protection.outlook.com [40.93.11.35]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 3p81k19b03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Mar 2023 12:55:16 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5WHbdgKzFIenfuKNhvFkbUbG01Ob5S5JftCetuR/9yRvx0f1zIHpbPxHj6kjOua+1leoPZpZvesk5o6JKIx85WnaiA3xBfwqsGsWK+AnJDy4MC65ypDMsczGm7FOfwHN/4EJMDRMUSmwXwFEuKHcnv1dmEzEcf7Wx+wquzHotjgM9/hdmE63szJDvnXIDhGy99vxE2qnQ3WezaGlIZfiTW6HOe4tOGk8nOyamVyWn62a0w2q6/X4uYxqza8baQi8Eq6ITdnsxg/3E51ySaQSh8XlbjeOPF0IM0CH3hrfi7JDfQBRyJXUbdnBK0KBQ+B+YO+bGzeUeFpJKyiwzhQLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5gGz6cSKDvk25aehyZc1SnRVZIaU21E4hLAX+zdA44=; b=Lko6FwcBc+voK+9UXmwCJQRpC+P16NlU21pg+7JDtwhhZXAA4pqN22UN2KB7dk9eFQC1norBGYGHbHKa99UjaLpZFZ69DmiFCbI+3YBmIAYTZygBh+RIWQ/yym6yiTfDWogGDD2FwgvUY3jI3DGxiVx9Kcvze0Wkf2apjSIuRdcWaXX7Njg4OPP4HwU08BJPwFvj72Y+Jh2k4tOkyp1urkKLmB2Z+SVWh6PgHTQM6A55oqe4TbwWXusI47HTBGWulFUah3UyeDhFvCsL6j/SIAh/oev1ySZLhJQjPKtBoFEMzNt9QSAaF4XQSYyGtxDXXsE13jiiNUJsx5BB8I1Bgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5gGz6cSKDvk25aehyZc1SnRVZIaU21E4hLAX+zdA44=; b=MILl2g4Z7hHHIKYmV4aRlwemclZDvuwHB43ERWM1xQ8VXxhiOcq09K+K3D97yDUSZU7JLDIhKub31LaLRAOY71dojIjevvOYFbEejAzGGgNPqF2nG4K/noW2Eu0r899/DYhdO3eh63+vuKfukcPw5Q4HPu1B1/J6ccihhmesqt8=
Received: from CO1PR05MB8492.namprd05.prod.outlook.com (2603:10b6:303:eb::7) by DM6PR05MB6953.namprd05.prod.outlook.com (2603:10b6:5:206::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 20:55:13 +0000
Received: from CO1PR05MB8492.namprd05.prod.outlook.com ([fe80::a9a5:986a:63e9:85fc]) by CO1PR05MB8492.namprd05.prod.outlook.com ([fe80::a9a5:986a:63e9:85fc%4]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 20:55:13 +0000
From: Antoni Przygienda <prz@juniper.net>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-lsr-distoptflood.authors@ietf.org" <draft-ietf-lsr-distoptflood.authors@ietf.org>
Thread-Topic: Comments on draft-ietf-lsr-distoptflood-01
Thread-Index: AdlTFE7MaAfkX8jISZOnCGzxWY5GdwAfV0TA
Date: Fri, 10 Mar 2023 20:55:12 +0000
Message-ID: <CO1PR05MB8492C21BE789C0CC6E157489ACBA9@CO1PR05MB8492.namprd05.prod.outlook.com>
References: <BY5PR11MB4337C07FC0B2A980F0CD27FBC1BA9@BY5PR11MB4337.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB4337C07FC0B2A980F0CD27FBC1BA9@BY5PR11MB4337.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=True; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2023-03-10T20:48:30.0959484Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CO1PR05MB8492:EE_|DM6PR05MB6953:EE_
x-ms-office365-filtering-correlation-id: 2de3b6ba-ae78-4f8f-5b2e-08db21a9be56
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: PVxdxB4WXw8EcEbDxxedZOboo956HURk2ik6SssrWBRJyejLD95Y0IXY5RA/86ERMPQMcQvv20DVgRWhC68yXAhk0d6Cz2xzmItCsyrv2Bw96SYPpQP3JU6eEULZkzDludNoJBzhKqyub7hHTCVGinDmw2b5sCM9Og6xxzByRF85P9mGPTRFuegLpay1UudkZjiHEclm9KcbI+COe9wrz+elxqVOOjS+3tRZpS4eiJg2dXG+NhaVafQ+DO6pIuF7vxYmxf6lQfNWqYYPUTlVVsy8TuDwOcUIXtk1E7uz83M/N+Au499NhJNbKdFPp2EFP0hQcMPx275gf8IsElGan+8wbsFf+x41ksUjdmAUiYaZYtCPogEfihPBB4RtS+T1ddtK59t+nPe2ZllcuV9Wtig+fCc4sYegL/TWuldVLHvqQ2vlPsxrvW+ZLnUzIKoLgLPZaeOn9Y8y79LuefmFpC/HY9ZnZFpzEUf1MfrXnzupjoP2xPfNZmhipXF33B94dFLJ6mjkdd4lCjyeKfS3g/RADbCLaMapEdV2pbv/WuueTRBAbWk3L9dpaKi8ZojcCR7Z1ZVPpVS4SOybj0lV9n0VhOcX2wUUORTnHDucj7vO+oHK8ETl1Oj0+hSR8kcVSap0j559CiLPuWNja5A5IFhZRBTSwcDc/f6SQ5D228/hfwp85GkKS2Tk6Z6pxrE+fiqMU521DfHG67OJd3Ye6kiS3xtBuGukNi86zxCOPSpIy5jIaibST9kLhEP0sfJo
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR05MB8492.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199018)(33656002)(83380400001)(6506007)(186003)(53546011)(9686003)(26005)(55016003)(7696005)(86362001)(66946007)(64756008)(76116006)(52536014)(41300700001)(8936002)(66476007)(66556008)(8676002)(2906002)(5660300002)(91956017)(66446008)(71200400001)(38070700005)(122000001)(478600001)(316002)(38100700002)(110136005); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 51rKRxsMIhkGrHO3DDglVS4wbNjjA/vFAy9RtWpkpx9y6jQI4iSWLpVh1HG79lgs/iirB4QxetVvrNWlnAYjw3CnFmA/o7uYBmKC/D2OQ3hd6BQGuHsyK7G+yFd6eU0PK/k+sisD40CWjOhCMXlo+T3rFh3W2IrqmcKz4DJrn5M3bcp/G/I/FPYA794fzcsDHF1n4Fhs/7tZLPQ8CU7II+63W0Y/PT6Tz7xLcE9X4ucBAxwl4FDhztEXrKftpoBpvaA3y7jvyIeEJcTGNCv3+6opym2+N0w7VXCpu0b4taJBPv9ySFsMU/tK+yQ8Prz3HOk5KNXWZN/YojclubHc9ljuZHFlgrvF6iJ0QsLRwz8GzcHRIK2uAVechpRFWG7sXHjI0FiWo5beLJWKFYsk85UcJ9NlUG5CXuaLtta26Hwx1Eunqno5QFs4ijl6i7YNP8M6NHgyKaqWUHgOOU4GwmR8czQaPQCfqgALzdckduIGY4BX2ljr7dtmRDc/5wEeNUh+gg2JCWRGzvt4Rbpj9L8zv5g66NmaxT1iA5wWfUdCyDgupzqPdS0PpBUidlNPZeI0bVV9nosX2KdcCiUXMQ6LOCX/2cJx7mAw6v7u6Ggz3FL+NSv70te5EODWNq5zQuVPbK0LRyqAUPWKgv5eClfCMSs6L1roGXeidyF8QIgA0/Sv69+kc/tUidFFZlPIoLERoH8qtJwuGC9qXKddpF0Es66TyDa00ZflyjMFjfmF6H8hz4Bwb1OrG3X/3m6EBmDbowhn1PKeWplfFss4F+a0d/8WbFkxLb4/z99WvNJJT9yd8BXQZ5b+KCtTdgidXdD0qo7FPmKe238X2r3vqkFMCjSN6m2yf8Nv1uPJK/mJacws5y5a8Hiae6iQvjkrxaXqiDiHqUCnfyVr06HDyRNpVm1EkQmQ/x8fIhufPXTapAEAX6F8iAOVeV6B9Q3nAxxOueirTdpqBEvFEBlkmEEm/gIPKz6RU3cnIbm52sNSbHm0KPh0jnjZ4NyTF3O5p+Kn7LNEzAozWx0xmYJVwX0q9F2fuhI/kTo+wLxXGM6WoLjGEZxb6kk5cKy4mkuW7VHC8F+Q8eAERVRSCkfghdkIcMyu8vmHeeoS+y7Bx1ndVw0AihADFQ2PPXtTXpGlNat9un4owwN/yZa7uO7oSLoNc/waMlAy+QpQcjsADTyYQ8TArE+XC3SErwtGZQmE8n5Oo/V7us73jVzUa35jp6MRoIJnnYvTOrQGvHvRl68dZZoEVWmSAWv7/SFJesymUMRgfyfuc6qfoP8aJtn0+FS3TGn3kzRs3D68OyfczaCfuBU54YwOcyc6k/nDy9Cdlzh+quph3/tS07ZPVRuTLIbjm2zi5i1nv+mSEdDDs8gSaZxr1IMowOGFIU9M2eUXrFUDIKucSvkfCZgizHuQzHR83eiRyuHDIw/wg7dRn9zkoLUdJ4+t7xux4NYZZNIlA8rKcx++TlLth2coobQaWTJB2Dz/xXDvNi6gtHYw2NGBVOYnVbcejf9NkHEMDIlrTUt1CGwq0vACrBQuhClRDftkUVIXpyjcN+Wvx1vV5b6gSZlzYFAgndlkMtf7Uw25
Content-Type: multipart/alternative; boundary="_000_CO1PR05MB8492C21BE789C0CC6E157489ACBA9CO1PR05MB8492namp_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR05MB8492.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2de3b6ba-ae78-4f8f-5b2e-08db21a9be56
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2023 20:55:12.8952 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bGjSZHsDuytRH/OXf67H+Ne2lc0QjaHF1pi7ylrhlAwBroI13FjxZE/TfKTwj1Yd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB6953
X-Proofpoint-GUID: nvI6Tni2WTUu7jd0rMV44nhPTyWllRaN
X-Proofpoint-ORIG-GUID: nvI6Tni2WTUu7jd0rMV44nhPTyWllRaN
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-10_10,2023-03-10_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 phishscore=0 malwarescore=0 adultscore=0 clxscore=1011 spamscore=0 mlxscore=0 suspectscore=0 impostorscore=0 mlxlogscore=892 bulkscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303100167
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/rnXOzzAaYD0fd0tNZ-h6D8h9cIA>
Subject: Re: [Lsr] Comments on draft-ietf-lsr-distoptflood-01
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Mar 2023 20:55:30 -0000

Thanks, most of the update were your comments.

Yeah, IANA will come

So, the problem is that you do NOT flood on those adjacencies where we suggest to send PSNPs and hence no RTX will happen, only CSNP will fix it and that’s slow. So PNSPs will speed it up … So I don’t follow your logic aobut (it will RTX anyway)

I’m perfectly fine keeping it a SHOULD or even MAY if you’re more comfortable with that, but it will speed up in case of hicc-ups AFAIS.

And no, we don’t have currently experimental data we can disclose … And neither have you so we basically all argue on “feelings and experience” and hence won’t make progress. Experimental data shouild come over time. And even then, it will hinge on so many topological, link behavior assumptions we can argue the whole day long anyway.

For the moment the draft will just chuck along in the WG as it is, it’s still early and further discusisons will happen  …

Thanks again Les for thorough reading and thinking it through


  *   Tony

From: Les Ginsberg (ginsberg) <ginsberg@cisco.com>
Date: Friday, 10 March 2023 at 07:31
To: lsr@ietf.org <lsr@ietf.org>, draft-ietf-lsr-distoptflood.authors@ietf.org <draft-ietf-lsr-distoptflood.authors@ietf.org>
Subject: Comments on draft-ietf-lsr-distoptflood-01
[External Email. Be cautious of content]


I am somewhat belated in commenting on the updated draft - apologies for that.



I thank the authors for addressing my comments and think the draft is significantly improved.

I do still have two issues - one minor and one more significant.



Minor issue:

I think you need a formal IANA section which defines what is needed in regards to the algorithm value advertised in the Area Leader sub-TLV defined in draft-ietf-lsr-dynamic-flooding.



More significant issue:



I am still not convinced that the proposed new use of PSNPs described in Section 2.3 is of value. Please hear me out on this.



One of the things we learned in the context of work related to draft-ietf-lsr-isis-fast-flooding is that optimal flooding throughput depends on knowing the delay employed by the neighbor when sending acknowledgments to received LSPs (what ISO 10589 calls "partialSNPInterval").

It is known that implementations vary significantly in the delays employed.

Some follow the suggested value in ISO 10589 - which is 2 seconds.

Some use a smaller - but still significant delay - for example 1 second.

And some implementations send acks "immediately" upon receipt of an LSP.



Without knowing the behavior of the neighbor in this regard, you do not know what value to use as a delay timer for the proposed PSNPs.

You want to be somewhat aggressive (i.e. faster than CSNP interval (typically 10 seconds)) but you don’t want to be overly aggressive or you risk diminishing the value of your flooding optimizations.

You also need to account for delays in receiving and processing the PSNPs.

This argues for a modest but multi-second timer.

But given that any LSP which is not acknowledged within the retransmit interval (proposed as 5 seconds by ISO 10589) will be retransmitted anyway, the need/usefulness of the triggered PSNP at a similar interval seems questionable. Within a few seconds either the LSP will be retransmitted or a periodic CSNP will be sent.  So the potential benefit to convergence is modest at best and it risks unnecessarily compromising your primary goal to dramatically reduce redundant flooding.



Have you implemented the proposal described in Section 2.3?

If you have, under what conditions have you actually seen a benefit? I am asking here about actual results - not theoretical outcomes.



You could argue that implementation of the procedures defined in Section 2.3 is not required (you deliberately use SHOULD rather than MUST in this section) and therefore skeptics (like me) are free to NOT implement this portion. However, there are two constituencies that concern me.



Implementors who read the document have a reasonable expectation that what is defined (whether it is MUST or SHOULD) is "best practice" and therefore they would be biased to do what the document says.

Customers who read the document have a reasonable expectation that what is defined is what they should require their vendors to supply. So even a stubborn guy like me might find it difficult to convince a customer that this portion should not be part of their RFP. 😊



Unless you can actually demonstrate that this adds value in real world scenarios, I think the draft would be better without this proposal.



Thanx for listening...



    Les




Juniper Business Use Only