[Lsr] Éric Vyncke's Yes on draft-ietf-lsr-ospf-reverse-metric-08: (with COMMENT)

Éric Vyncke via Datatracker <noreply@ietf.org> Wed, 05 October 2022 15:12 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: lsr@ietf.org
Delivered-To: lsr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EBBFC14F746; Wed, 5 Oct 2022 08:12:52 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Éric Vyncke via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-lsr-ospf-reverse-metric@ietf.org, lsr-chairs@ietf.org, lsr@ietf.org, chopps@chopps.org, acee@cisco.com, acee@cisco.com, Wassim.Haddad@ericsson.com
X-Test-IDTracker: no
X-IETF-IDTracker: 8.17.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Éric Vyncke <evyncke@cisco.com>
Message-ID: <166498277224.49409.17323495265436455304@ietfa.amsl.com>
Date: Wed, 05 Oct 2022 08:12:52 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/wNdbE_oDHyKYw9cqNMZg2kZ5sz4>
Subject: [Lsr] Éric Vyncke's Yes on draft-ietf-lsr-ospf-reverse-metric-08: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2022 15:12:52 -0000

Éric Vyncke has entered the following ballot position for
draft-ietf-lsr-ospf-reverse-metric-08: Yes

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-lsr-ospf-reverse-metric/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------


# Éric Vyncke, INT AD, comments for draft-ietf-shmoo-hackathon-07
CC @evyncke

Thank you for the work put into this document.

Please find below some non-blocking COMMENT points (but replies would be
appreciated even if only for my own education).

Special thanks to Acee Lindem for the shepherd's detailed write-up including
the WG consensus *and* the justification of the intended status. Even, if I
cannot really parse `During the WG last call, a number of WG members the draft
with the only issue being the predominant use cases.`.

Please note that Wassim Haddad is the Internet directorate reviewer (at my
request) and you may want to consider this int-dir reviews as well when Wassim
will complete the review (no need to wait for it though):
https://datatracker.ietf.org/doc/draft-ietf-lsr-ospf-reverse-metric/reviewrequest/16329/

I hope that this review helps to improve the document,

Regards,

-éric

## COMMENTS

### Abstract

`that receiving neighbor(s) should use for a link to the signaling router`
should the neighbor be qualified by "OSPF" ?

More generally about the abstract: it is rather hard to parse and to understand
(at least for a native English reader).

### Generic

Should this be "mirrored metric" rather than "reverse metric". I appreciate
that this is late in the process, but it sounds clearer.

### Section 1

s/and/or/ in `Open Shortest Path First (OSPFv2) [RFC2328] and OSPFv3 [RFC5340]
`?

```
   ... then R2 advertises this value
   as its metric to R1 in its Router-LSA instead of its locally
   configured value.
```
Suggest to s/in its Router-LSA/in its Router-LSAs to all its OSPF neighbors/

### Section 2.2

s/some point T/some point in time T/ ?

Please expand "CLOS"

### Section 6

` When using multi-topology routing with OSPF [RFC4915],` what about OSPFv3 ?

### Section 7

s/The use of reverse metric signaling does not alter the OSPF metric/The use of
*received* reverse metric *signalling* does not alter the OSPF metric/ ?

Rather than `If routers that receive a reverse metric advertisement log an
event to notify system administration, `, what about using "It is RECOMMENDED"
or a "SHOULD" ?

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues.

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments