Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-03.txt

tom petch <> Wed, 12 August 2020 11:52 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id D92FF3A1261; Wed, 12 Aug 2020 04:52:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id AU3QIrvG45St; Wed, 12 Aug 2020 04:52:03 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id ABA913A1248; Wed, 12 Aug 2020 04:52:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901;; cv=none; b=QH6Gw/C9s9wcmyUYQ7zkWE5iCWq8eId/PIp5lXv1Y97tGEMRAaufkpNICtdK8tZI0DIAuymAGl7lr6L2GLUXeFfCDXqrCpBnBmROSxOCGztIKdPoOckNSJ/h0+1qm779c6e7DMrYa+QNGGH1dmrLs2HfytIXaJCVhNthtNmyLyXWv1TqAqKH+9Xke6lcdxmukMNAOZyqF5Lyk2W5NOMkcoR1MFYfDeeuidpaYyxnUws0iCJA69kIxc8ogHYWIkIgQ1uHYaI+tDQmyjGKb2Eo1rVcL3h5WygO01TWFtwAFTHvznT0zyqPvzSqFS3YlSrfCVDc59t1St3ubs+f+KvwuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tfleed0H55k2Bf6zfhSoWUt/E13in8zSfhoCoY1VLJ0=; b=kGIa/oTj/oWGSGcmd682OJmEUpP1DyskxntHHp8jvIJS6uYmepiUAx50L9uVzpkh4xiAGzAf4mGQiV6ddGHWqP9cNfF7M/4iROhCZoTaW5eh+u23hS+Ly28iaNgBrb4kx5KKRh8EIk8l3qZBrYWPLd0QP7VUEj+QdEIw7Ma99tRPzQLcUH9b7NBK2m9Agtz+71HLsPRTDu11/2eYU0o0ZXke+jP2dZGEZOp2W/GIjcJcwC5RgXXm5cSF0hBqp+yYaMYBCcy9+7Kxf+A6Ofv+eO9wnykH5fdsCMtovhjTL1wnrc1drIPkaXZCs4hvKb41tjoyWfb7o7oboGuJmLdOhg==
ARC-Authentication-Results: i=1; 1; spf=pass; dmarc=pass action=none; dkim=pass; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tfleed0H55k2Bf6zfhSoWUt/E13in8zSfhoCoY1VLJ0=; b=jHSosS3xafqGOUdsbhGKY768ikOsnIgRnCaAsbPPXJYPZe5MBXF4A1j+5YnNOwuiRLi3XEHXgTKwU8eSsELC26QzJc25Pb6ZAGNq0rI/9qUkw1TmIE7m8YI6RN2efUBNHFTYm98LR15xVzvpmscvzvI2SpEp6yVOAyhME5C6Pq0=
Received: from (2603:10a6:20b:134::11) by (2603:10a6:20b:13e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.11; Wed, 12 Aug 2020 11:52:00 +0000
Received: from ([fe80::b570:437a:db46:400a]) by ([fe80::b570:437a:db46:400a%9]) with mapi id 15.20.3283.014; Wed, 12 Aug 2020 11:52:00 +0000
From: tom petch <>
To: Yingzhen Qu <>, "" <>, "" <>
Thread-Topic: I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-03.txt
Thread-Index: AQHWcJ78RmXEAI4DIkGUBHZ+5qK7OA==
Date: Wed, 12 Aug 2020 11:51:59 +0000
Message-ID: <>
References: <>, <>
In-Reply-To: <>
Accept-Language: en-GB, en-US
Content-Language: en-GB
authentication-results:; dkim=none (message not signed) header.d=none;; dmarc=none action=none;
x-originating-ip: []
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 53c0779d-a2a8-4ef5-547f-08d83eb61f28
x-ms-traffictypediagnostic: AM7PR07MB6325:
x-microsoft-antispam-prvs: <>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-forefront-antispam-report: CIP:; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM;; PTR:; CAT:NONE; SFS:(366004)(39860400002)(136003)(376002)(346002)(396003)(33656002)(9686003)(478600001)(7696005)(83380400001)(66446008)(2906002)(8676002)(71200400001)(91956017)(66946007)(76116006)(6506007)(66476007)(66556008)(64756008)(26005)(5660300002)(86362001)(8936002)(316002)(66574015)(110136005)(55016002)(186003)(52536014)(966005); DIR:OUT; SFP:1102;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-Network-Message-Id: 53c0779d-a2a8-4ef5-547f-08d83eb61f28
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2020 11:51:59.9964 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZGYc5x7sazof2mUQCgUQQAeGsJLqh4K3/C0e5q1cCg8LAh0CNGilP4BXH6FZZbIZzqG6vKaCuXbV6x8yxSBxwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6325
Archived-At: <>
Subject: Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-03.txt
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 12 Aug 2020 11:52:09 -0000

Looking at some more technical aspects of this

    /* Configuration */
        "This augments the OSPFv3 protocol configuration
         with segment routing.";

      leaf extended-lsa-support {
      leaf extended-lsa-support {
why two? what does it mean if one is true and one false?  (why not more
than two?:-)

I wonder too where this boolean is best placed; there seems to me to be
no obvious ospfv3 place for it so
is probably as good as any.

       when "/rt:routing/rt:control-plane-protocols"
          + "/rt:control-plane-protocol/rt:type = 'ospf:ospfv3'"  {
is rt:type always set to ospfv3 as opposed to ospf? is there something
in ospf-yang that ensures this?

     * Link State Database (LSDB) Augmentations
      when "derived-from-or-self(/rt:routing/rt:control-plane-protocols"
         + "/rt:control-plane-protocol/rt:type,"
         + "'ospfv3')"  {
derived-from seems unnecessary for ospfv3, equality would do

    grouping ipv4-link-local-tlv {
      container ipv4-link-local-tlv {
        description "IPv6 Link-Local LSA TLV";
IPv6 looks odd here

    grouping ospfv3-e-lsa-area {
      description "Area scope OSPFv3 Extended LSAs.";
      container e-router {
        when  "derived-from(../../ospf:header/ospf:type,
'ospfv3-e-router-lsa')" {
I see nothing derived from 'ospfv3-e-router-lsa' so I cannot see when
this is true

            leaf type {
              type uint8;
this is an enumeration in ospf-yang

        when "derived-from(../../ospf:header/ospf:type,
likewise I cannot see this being true

        when "derived-from(../../ospf:header/ospf:type,
and again

        when "derived-from(../../ospf:header/ospf:type,
and again

        when "derived-from-or-self(../../ospf:header/ospf:type,
I think you know this by now but this one would work but is not needed,
simple equality test would do.

        when "derived-from-or-self(../../ospf:header/ospf:type,
again equality is all that seems to be needed

        when "derived-from-or-self(../../ospf:header/ospf:type,
and again

        when "derived-from-or-self(../../ospf:header/ospf:type,
and again

Tom Petch

----- Original Message -----
From: <>
To: <>
Cc: <>
Sent: Friday, August 07, 2020 7:03 PM
Subject: I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-03.txt

> A New Internet-Draft is available from the on-line Internet-Drafts
> This draft is a work item of the Link State Routing WG of the IETF.
>         Title           : YANG Model for OSPFv3 Extended LSAs
>         Authors         : Acee Lindem
>                           Sharmila Palani
>                           Yingzhen Qu
>         Filename        :
>         Pages           : 26
>         Date            : 2020-08-07
> Abstract:
>    This document defines a YANG data model augmenting the IETF OSPF
>    model to provide support for OSPFv3 Link State Advertisement (LSA)
>    Extensibility as defined in RFC 8362.  OSPFv3 Extended LSAs provide
>    extensible TLV-based LSAs for the base LSA types defined in RFC
> The IETF datatracker status page for this draft is:
> There are also htmlized versions available at:
> A diff from the previous version is available at:
> Please note that it may take a couple of minutes from the time of
> until the htmlized version and diff are available at
> Internet-Drafts are also available by anonymous FTP at: