IETF Logo Mail Archive

Re: [Lsr] [Pce] Intdir telechat review of draft-ietf-lsr-pce-discovery-security-support-12

Dhruv Dhody <dd@dhruvdhody.com> Wed, 12 October 2022 06:35 UTC

Return-Path: <dd@dhruvdhody.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A4B4C1524D1 for <lsr@ietfa.amsl.com>; Tue, 11 Oct 2022 23:35:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.905
X-Spam-Level:
X-Spam-Status: No, score=-1.905 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20210112.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mac5DCo2T3ia for <lsr@ietfa.amsl.com>; Tue, 11 Oct 2022 23:35:31 -0700 (PDT)
Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D248EC1524B8 for <lsr@ietf.org>; Tue, 11 Oct 2022 23:35:10 -0700 (PDT)
Received: by mail-vs1-xe2c.google.com with SMTP id a2so10850999vsc.13 for <lsr@ietf.org>; Tue, 11 Oct 2022 23:35:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MnDI9FnhaPyenN+PN3PpUHjQvZe6D4/nxvD2vsR+9g4=; b=UADPM1q2OpcBOntN7WWnP66pxprTgrARhNaCz8F0n7bK+DHa8N9bdUaL6lQp9FRUmq 2EdJ/aoFfV+bVRKxOf1TDfRcyd/kvfTbdRVQZIFgXD7cMCMV58LO7W8t2jPbnbs/6Frf vW+SAds/OWRw1ClRWdHvXMJHCYSx+FeK2Iv4DH7l6PUCJJe3vU9eZwntsGvJsheWPE6l Eap30GYBvdlWEe+LMMpjWj0XVv4wrpMBvgpMVKs19HfeUQJQ4Ln7TRxaGqvt3QxlRfmI ZMXIpcWE97mz0/h7W23rN5OD8fechtTYVIN4JHBrNLuH139KhL8RFNqSp9OH8Jny6//W hqWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MnDI9FnhaPyenN+PN3PpUHjQvZe6D4/nxvD2vsR+9g4=; b=P6LBf+0LX3kHhBqiEyb9+qvKaS6hqvBXAhJuaW0ZNIqiUjHtiezSlTP9jzRD3tBY8o Do9LAyhj3qXVrLvB4uKS48lHlN1GHurgZAjvBTfo/9tsvGKYAqJcS9pPgBDf79K7WVWF hAvC/StqByMfTh4u4N2wHeRAYHG0+CbxwADwDt/QSsLmVHpMlt4WzFXC3is2aXLXwMw5 DSbxdotmC1EPr5nlgKQPnWXm0UGOTD8Czrlhaw7S4YheJe5iW6JLxDoe/v45sZnFWvKx +JzUfDkZlXCkBO5D5ACEOiujjb1bt8v6vOMm2evj8ZlIoC3gjdceTjDEVXMhbnHALFXr stZg==
X-Gm-Message-State: ACrzQf2dW0qUAMEQ+NJZnGh6p3wXJ108K5CaWaQrUnyasiPvdgEC1h4G T1hzeUqvJbUz5W+C3bM1WRtqwc3IuEE32tTQilHg/A==
X-Google-Smtp-Source: AMsMyM4Jc3h2pQppiE+n41NH6vAsjuQ55Dgi+LjkNLSYvpqqnrpeHCr7nEgLlrdE+9AiMQ3EqKQDS5wcnS9LOUvLI1I=
X-Received: by 2002:a67:c297:0:b0:3a7:5f0c:54c4 with SMTP id k23-20020a67c297000000b003a75f0c54c4mr11544647vsj.76.1665556509466; Tue, 11 Oct 2022 23:35:09 -0700 (PDT)
MIME-Version: 1.0
References: <166549721104.35846.9858835884158053058@ietfa.amsl.com>
In-Reply-To: <166549721104.35846.9858835884158053058@ietfa.amsl.com>
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Wed, 12 Oct 2022 12:04:33 +0530
Message-ID: <CAP7zK5Y5gLL7+mwbaNDnaonjz0yjsRfzQKnmBMvfJjyPdOTjrQ@mail.gmail.com>
To: Carlos Pignataro <cpignata@cisco.com>
Cc: int-dir@ietf.org, draft-ietf-lsr-pce-discovery-security-support.all@ietf.org, last-call@ietf.org, lsr@ietf.org
Content-Type: multipart/alternative; boundary="00000000000019b73d05ead098c4"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/yQKVD7kHOCpHcYgz-ReWBa40tNA>
Subject: Re: [Lsr] [Pce] Intdir telechat review of draft-ietf-lsr-pce-discovery-security-support-12
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2022 06:35:31 -0000

Hi Carlos,

Thanks for your review!

On Tue, Oct 11, 2022 at 7:38 PM Carlos Pignataro via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Carlos Pignataro
> Review result: Ready with Nits
>
> This document defines a mechanism (flags and sub-TLV) to advertise via the
> PCE
> Protocol security required within the IGP being used.
>
> This is a very well written, clear, and sensible document. In my opinion,
> it is
> Ready.
>
> Flagging some potential nits:
>
> Abstract:
> Old:
>    capability.  Further, this document updates RFC 8231, and RFC 8306.
> New:
>    capability.  Further, this document updates RFC 8231 and RFC 8306.
>
>
Updated!



> Question:
> The header and Section 4 say this updates RFCs 5088 and 5089; however,
> that is not mentioned in the Abstract.
>
>
It is! See

      In addition, this
      document updates RFC 5088 and RFC 5089 to allow advertisement of a Key
      ID or Key Chain Name Sub-TLV to support TCP-AO security capability.
      Further, this document updates RFC 8231 and RFC 8306.



> Old:
>    The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
>    security parameters (key, key chain and TLS).
> New:
>    The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
>    security parameters (key, key chain, and TLS).
>
>
Updated!

The IETF datatracker status page for this draft is:
https://datatracker.ietf.org/doc/draft-ietf-lsr-pce-discovery-security-support/

There is also an htmlized version available at:
https://datatracker.ietf.org/doc/html/draft-ietf-lsr-pce-discovery-security-support-13

A diff from the previous version is available at:
https://www.ietf.org/rfcdiff?url2=draft-ietf-lsr-pce-discovery-security-support-13

Thanks,
Dhruv



> Thanks!
>
> Carlos.
>
>
> _______________________________________________
> Pce mailing list
> Pce@ietf.org
> https://www.ietf.org/mailman/listinfo/pce
>

v2.46.0 | Report a Bug | By Email | System Status