Re: [manet] draft-ietf-manet-olsrv2-multipath-06

Ulrich Herberg <ulrich@herberg.name> Wed, 14 October 2015 17:12 UTC

Return-Path: <ulrich@herberg.name>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1DAE41ACED3 for <manet@ietfa.amsl.com>; Wed, 14 Oct 2015 10:12:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.378
X-Spam-Level:
X-Spam-Status: No, score=-1.378 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FM_FORGED_GMAIL=0.622] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bRjY-x51nENw for <manet@ietfa.amsl.com>; Wed, 14 Oct 2015 10:12:54 -0700 (PDT)
Received: from mail-vk0-x229.google.com (mail-vk0-x229.google.com [IPv6:2607:f8b0:400c:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F25311A88E8 for <manet@ietf.org>; Wed, 14 Oct 2015 10:12:53 -0700 (PDT)
Received: by vkat63 with SMTP id t63so33800971vka.1 for <manet@ietf.org>; Wed, 14 Oct 2015 10:12:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=herberg.name; s=dkim; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2l7cVZuccf/w8jcFy8dozeViP6hF5SgV8OaLHLB5kU4=; b=piOI4Du/HvtyEK0t6i/N27dfRkNBwrLN/3Z0QfkQCx32aL7f9sfamoECo1urHyyknd WIcLZtyD3BoOV1jI3iX523CWRB0CMfvKI5rSjoWb+wetXZkQZDlSO53F6szKFHrpJ96u UA2/jl5A/rKmFidiqip8vrFgbLm0+5AIXDWik=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2l7cVZuccf/w8jcFy8dozeViP6hF5SgV8OaLHLB5kU4=; b=bME8Gg6zAjpqRFwB6vn4PGh689MlSEG5sa5i062B9IChG0R4PAWM1yWqcgwZ/yMvzm g0CzpljktM2Hbelm/JsSCeoplv6fTAzI/Hp4jG3p49i5RCIlZWiLOPJ6G9e97kJ3mTZo G7JXcL43I/oR8P9AnUTwHfcoDifWNLZyiGXXjRVeWKrGKvuEJgNZrIXlK2qs2n4imW0B e2TS+rtXMEvQE20stxxvfumfW9DOHLkp4HaATKx0fQF0iLYuKMPzfTt0LoOiSfntJLkX EB1367IQU6/v/I3oOXRF6Dl/g3+GBaUA8TbawNgSLr6MKSeuszitFcMirsg8DGzfubQg 3vnA==
X-Gm-Message-State: ALoCoQnuTPvEZxlQn4r6eEHhLdPRaA9/lwO0xtpeoid4f0CraKw3jbHs2pJ13Y8RgUklrirFfDg8
MIME-Version: 1.0
X-Received: by 10.31.179.83 with SMTP id c80mr2536665vkf.68.1444842772429; Wed, 14 Oct 2015 10:12:52 -0700 (PDT)
Received: by 10.31.96.85 with HTTP; Wed, 14 Oct 2015 10:12:52 -0700 (PDT)
In-Reply-To: <CAN1bDFyoeSCcRX3Lrde=q18Z+axCKHwGiB_if+bxVQNo7aYH4Q@mail.gmail.com>
References: <CALtoyomExzo2iGNJBd-tqufOL1+8KBd=cUeTksxFOimF=YO5YQ@mail.gmail.com> <CAN1bDFyoeSCcRX3Lrde=q18Z+axCKHwGiB_if+bxVQNo7aYH4Q@mail.gmail.com>
Date: Wed, 14 Oct 2015 10:12:52 -0700
Message-ID: <CAK=bVC_ZNFWk1ozjquPVb+3h_wPYstPzxDSQheB2BQzALSsCbg@mail.gmail.com>
From: Ulrich Herberg <ulrich@herberg.name>
To: Jiazi YI <ietf@jiaziyi.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <http://mailarchive.ietf.org/arch/msg/manet/Ab-E3DQEjwWhu-zRXQbnHgin0ek>
Cc: MANET IETF <manet@ietf.org>
Subject: Re: [manet] draft-ietf-manet-olsrv2-multipath-06
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Oct 2015 17:12:56 -0000

Jiazi,

thanks for the reminder. I read the draft and have a few comments and
questions. Overall, I think that the draft is well written, but lacks
some details that would have to be specified before I'd feel
comfortable implementing this in an interoperable fashion.


- section 5.1. (router parameters).
o NUMBER_OF_PATHS: Is this a constant? Can it change during router
operations? If so what are the constraints, and how does the change
impact existing routes? Is this a constant per router, or could I
have, say, 3 paths for a certain destination that I need a lot, but
only 1 for others?
o MAX_SRC_HOPS: same as above. (constant? constraints?)
Do these two parameters have to be negotiated between all routers or
are there no interop problems if routers use different values in the
network?
o fp/fe: This is a function (of what?). I am not sure I understand why
this is listed under a section Parameters. How can I implement this?

- section 6:
"To support source
   routing, a source routing header is added to each datagram routed by
   this extension."

I think there is a section missing about interaction with FIB/RIB.
Somewhere else it is said that "[...] the MP-OLSRv2 routing process
receives a datagram from upper layers or interfaces connecting other
routing domains". How does this work? This may also need some
additions to the applicability statement section.

- section 7.2:
How does this interact with the Routing Set in OLSRv2? Is this used
instead? Does the MR_valid_time have to be the same as the timeout on
the Routing Set?

- "PT_cost -   the cost of the path to the destination"
Cost in what? Hops? Does this support metrics other than hop count?

- "PT_address[1...n] -   the addresses of intermediate routers to be
      visited numbered from 1 to n."

A router may have multiple addresses for each of its interfaces. Does
it matter which addresses are used in this list? Is loop-freedom
guaranteed?

- Section 8.2.: SR_OLSR_HOLD_TIME
What is the relationship with other OLSRv2 information sets? Could
there be a situation where I still have an SR-OLSR Router Tuple, but
the same destination is not present anymore in other OLSRv2 sets
(Routing Set, Topology Set etc). Since the hold_time can be chosen
independently, that seems possible.

- Section 8.3: " When the MP-OLSRv2 routing process receives a
datagram from upper
   layers or interfaces connecting other routing domains..."
How does this work, "other routing domains"? How would a router determine this?

- "   o  If the length of the path (n) is greater than MAX_SRC_HOPS, only
      the key routers in the path are kept.  By default, the key routers
      are uniformly chosen in the path."

What are key routers? How does this work?

   o  The routers with higher priority (such as higher routing
      willingness defined in [RFC7181]) are preferred.

How?

- Section 8.4: This doesn't use the information bases that have been
defined before. How can I implement this using the existing
information form the protocol? (without all that abstraction)

- Section 8.5. This seems to be quite intrusive into the IP stack. I
thought it would be enough to add the source route header at the first
router along the path, and then just use standard source routing. Or
is the path changed during forwarding the packet?

- Security:

"Compared to OLSRv2, the use of source routing header in this
   specification introduces vulnerabilities related to source routing
   attacks, which include bypassing filtering devices, bandwidth
   exhaustion of certain routers, etc.  Those attacks are discussed in
   Section 5.1 of [RFC6554] and [RFC5095].  To make sure that the
   influence is limited to the OLSRv2/MP-OLSRv2 routing domain, the
   source routing header MUST be used only in the current routing
   domain."

Is this enough to let this pass the Sec ADs? How is this
enforced, "only in the current routing domain"?

Best regards
Ulrich

On Tue, Oct 13, 2015 at 3:18 PM, Jiazi YI <ietf@jiaziyi.com> wrote:
> Dear all,
>
> As a reminder, the WGLC of draft-ietf-manet-olsrv2-multipath-06
> (https://datatracker.ietf.org/doc/draft-ietf-manet-olsrv2-multipath/) will
> be closed on Oct. 16.
>
> Your comments on the document will be highly appreciated :)
>
> cheers
>
> Jiazi
>
> On Fri, Oct 2, 2015 at 3:33 PM, Stan Ratliff <ratliffstan@gmail.com> wrote:
>>
>> Hello WG participants,
>>
>> The above referenced draft seems to have addressed all of the outstanding
>> WG comments to date. Therefore, it's time for a Working Group Last Call
>> (WGLC) on this document. The WGLC period will close on October 16. Please
>> read and review the document, and provide comments, prior to that time if
>> possible.
>>
>> Regards,
>> Stan
>>
>> _______________________________________________
>> manet mailing list
>> manet@ietf.org
>> https://www.ietf.org/mailman/listinfo/manet
>>
>
>
> _______________________________________________
> manet mailing list
> manet@ietf.org
> https://www.ietf.org/mailman/listinfo/manet
>