IETF Logo Mail Archive

Re: [manet] Tsvart early review of draft-ietf-manet-dlep-credit-flow-control-09

Henning Rogge <hrogge@gmail.com> Wed, 07 February 2024 08:00 UTC

Return-Path: <hrogge@gmail.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B160C14F6A0; Wed, 7 Feb 2024 00:00:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.108
X-Spam-Level:
X-Spam-Status: No, score=-2.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5jkCc0zvFFkT; Wed, 7 Feb 2024 00:00:48 -0800 (PST)
Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02F19C14F69C; Wed, 7 Feb 2024 00:00:42 -0800 (PST)
Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5602500d1a6so343514a12.3; Wed, 07 Feb 2024 00:00:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707292841; x=1707897641; darn=ietf.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CXru4ti8d76sawzruJdahKgkOhgJJKscsXmgFVCrhkA=; b=RSUEA39qF6+TcLLsfWoYaYRJMyZkjnnlruEeS9eU87mxEFVa2gRgPEY8klgBRgAIJi yVRHNHk6hJsTutgrOJODopbiaWMOv51SexVRu7tqFp9DcMTcyVVTfHmMFYpAWSdQZPpi HalnFCkW/NoIvw3xNvDs5q53aKY4Sx2VqgW5b7g6rblbcnQq1g2pZm+o9xmvRo4GFdqI 073qy7fJs2xRoPnIruo2NLPF/d/dauJp1jGuZD/0f4FExstMIIt/mdtu6YWTvQmjwTb3 JGrzMe6U2OtYuPQs8/wrKv1PGt4nCPvh5bPVQ130c104zYPwR1i5CxK+yhpCoADm3mjn gh0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707292841; x=1707897641; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CXru4ti8d76sawzruJdahKgkOhgJJKscsXmgFVCrhkA=; b=eEm1BqtfE88mvEnhu3FPr73DaCFVDkaAq4n84RqQpWajYIdJr7vp3u8ZrPlI1atLps xSpTqzv1xq+bQ4U8nIkLLLyrJ4yq/MggUF1nN9pE/RcQZ8hrTOBwN6e7Po7C6RHPFu74 oSPWjkyHzVYml3LMcsU5YqcJ51V5yBtADidXcgIKV/xERhDpydMQ5JR+GzyX5ryJU3jj xwmb486OFno9GAFfANFom1D2hH4a1j78bHLh9qfrOzWRtv36T5j6MlTqHqWWrSV9xv3j vWVUEoVLVyjifkc3epvGtZ6pbwgGxLXJiSBSJrJJffInZHOVRkWeFcwY1wsnfZyR8s8a sX2w==
X-Gm-Message-State: AOJu0YxOehSFDhNlw1ZOm9gDthFiJ+4Ey2vHoMuaBqODqXZra+i3fC0m NPFU9cY15IFpyafjbJPzJJNEXnB4LuE/GzehygtF2W33loOg0vj3xL3KwWie3/x3GcuJeeVnEZA whiEWo02yEbrpx0Nu6xYMoYKBVDU=
X-Google-Smtp-Source: AGHT+IENEQKDTN5/BX/d0yuirT/33sI/e+vj2GddoVXwIqhtPvS64nRaH2UKGM8eVX1f/w56ItXoUuyqbDCDwfuScJQ=
X-Received: by 2002:a17:906:314c:b0:a37:20be:edaf with SMTP id e12-20020a170906314c00b00a3720beedafmr3413423eje.62.1707292840882; Wed, 07 Feb 2024 00:00:40 -0800 (PST)
MIME-Version: 1.0
References: <5d1bf77b-6391-65b2-8ca2-57d6736b0439@labn.net> <18399f51-73d3-25e6-c8e7-1acb7d30aace@labn.net> <MN2PR19MB4045DE0B35B5349A686465F183189@MN2PR19MB4045.namprd19.prod.outlook.com> <a13273b2-6cbe-00ff-25bd-df6c6c623dde@labn.net> <MN2PR19MB4045F38BCD91EB884D142BB7839A9@MN2PR19MB4045.namprd19.prod.outlook.com> <f255fd472a714dea95161209cd55dbb0@tno.nl> <PH7PR14MB53683A3705671E1D5DE87041BB412@PH7PR14MB5368.namprd14.prod.outlook.com> <MN2PR19MB4045C7EB432E61B258212FAF83452@MN2PR19MB4045.namprd19.prod.outlook.com>
In-Reply-To: <MN2PR19MB4045C7EB432E61B258212FAF83452@MN2PR19MB4045.namprd19.prod.outlook.com>
From: Henning Rogge <hrogge@gmail.com>
Date: Wed, 07 Feb 2024 09:00:14 +0100
Message-ID: <CAGnRvuojopZsM0MsXuKQ0fEi+ntbAExvKtCFWuCjZOagLLGRDA@mail.gmail.com>
To: "Black, David" <David.Black=40dell.com@dmarc.ietf.org>
Cc: Don Fedyk <dfedyk@labn.net>, "Velt, R. (Ronald) in 't" <Ronald.intVelt=40tno.nl@dmarc.ietf.org>, Lou Berger <lberger@labn.net>, "tsv-art@ietf.org" <tsv-art@ietf.org>, MANET IETF <manet@ietf.org>, "Black, David" <David.Black@dell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/X_ZQGHHFHZccF-FHLMBes2PxgRw>
Subject: Re: [manet] Tsvart early review of draft-ietf-manet-dlep-credit-flow-control-09
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2024 08:00:52 -0000

On Wed, Feb 7, 2024 at 2:45 AM Black, David
<David.Black=40dell.com@dmarc.ietf.org> wrote:
>
> > Hi  I did not see a reply on this thread.
> > David are you satisfied with the response?
>
> Hi Don,
>
> Sorry for the delay - I was on vacation for most of January, and am still digging out from the backlog ...
>
> David> Comments inline.
>
> In summary:
> - item [1] has been resolved via the shepherd writeup.
> - item [C] has an agreed resolution below.
> - item [2] discussion appears to have reached agreement in principle on what to do.
> - item [3] needs more thought, but appears to be headed towards resolution.
> - item [5] looks like an actual problem, as I am very surprised to see dropped traffic due to buffer overrun characterized as a "feature" of credit-based flow control - that definitely looks like a "bug" to me.

The feature here is that the radio can be "sure" that the router has
done something stupid so it's easy to decide "just drop it and maybe
log a local error".

Henning Rogge

v2.23.0 | Report a Bug | By Email