[manet] Tsvart early review of draft-ietf-manet-dlep-ether-credit-extension-02

David Black via Datatracker <noreply@ietf.org> Tue, 19 December 2023 22:14 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: manet@ietf.org
Delivered-To: manet@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 37D85C2395FF; Tue, 19 Dec 2023 14:14:17 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: David Black via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-manet-dlep-ether-credit-extension.all@ietf.org, manet@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.1.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170302405721.55866.12782124638086729472@ietfa.amsl.com>
Reply-To: David Black <david.black@dell.com>
Date: Tue, 19 Dec 2023 14:14:17 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/bAk-LSf5CMUxCr0Bahl5002tZHk>
Subject: [manet] Tsvart early review of draft-ietf-manet-dlep-ether-credit-extension-02
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2023 22:14:17 -0000

Reviewer: David Black
Review result: On the Right Track

This review is effectively an extension of aprior TSVART review of earlier
versions of three related DLRP drafts to include a fourth DLEP draft.

That prior TSVART review

        DLEP Credit-Based Flow Control Messages and Data Items
        DLEP DiffServ Aware Credit Window Extension
        DLEP Traffic Classification Data Item

The additional fourth draft that is the subject of this review is:

        DLEP IEEE 802.1Q Aware Credit Window Extension

This ether-credit-extension draft has strong similarities to the
da-credit-extension draft, so the prior review comments applicable to the
da-credit-extension draft should also be applied to this ether-credit-extension
draft.  Most of the prior review comments were on the credit-flow-control and
traffic-classification drafts, although there are a few that apply to the
credit-extension drafts, e.g., the security concern for which a resolution was
discussed on the mailing list.

The review request specifically mentioned the number of documents concern
raised by the prior review.  It is clear from the shepherd writeups for the
previously reviewed drafts that the WG has discussed whether to merge drafts
and has decided not to merge any of them, beyond which the addition of this
fourth draft weakens the rationale for merging.  That seems reasonable - this
reviewer will nowdefer to the judgement of the WG and the responsible ADs on
the number of drafts that are appropriate.