Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2
Stig Venaas <stig@venaas.com> Thu, 15 September 2016 21:41 UTC
Return-Path: <stig@venaas.com>
X-Original-To: mboned@ietfa.amsl.com
Delivered-To: mboned@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7CA512B046 for <mboned@ietfa.amsl.com>; Thu, 15 Sep 2016 14:41:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o4veEni22CW0 for <mboned@ietfa.amsl.com>; Thu, 15 Sep 2016 14:41:20 -0700 (PDT)
Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3613F12B019 for <mboned@ietf.org>; Thu, 15 Sep 2016 14:41:19 -0700 (PDT)
Received: by mail-lf0-x235.google.com with SMTP id g62so49172502lfe.3 for <mboned@ietf.org>; Thu, 15 Sep 2016 14:41:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U9n3GjZrixY9X+fa9kVDgn23ay7BfQKtpOhvL+G6E14=; b=kXanF4wMAgT2zXuEYrPdysxJkqvUI4EPTFlX4+2crU0ziGoHmmrhbzs7FCOJWce7ut C8QMYsMxohHoOmud1XYMa2Vh8Sq7Z6K2I0Z7YJZ43M6S/GHrREruulWB7BCaQC0hVgE/ 2wTBfU5b8UhB+3WKNmbusISIxZLh6EwYGOJUEMoav8EaeI7TuUycqdf4lqM4wdkGeD/m xdT7DmCzBe/9QUFi2VyEoYN3rei6pfd/yyj4HczIAWGdEr/KIbkxoXw9pqWt30/nAwFT ZyL2v8TUDZCTigXGfcYprl6jfM7LkwlKXpebFBBJKGCqb6t/kU74BnzbuKBbV/zR7hwx 7zjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U9n3GjZrixY9X+fa9kVDgn23ay7BfQKtpOhvL+G6E14=; b=MK1WMJzMYfU/4AYds5F2fHFm623kkuhP7Asb1vCa/6Ayur69hXQnn/xO7ekICt4k7/ LvREO4vWJSVy08t9UFQRgHXR/tdyLVynRpwBSmOpEeqZyUfOBLlgExPh/Ile9Z5WjSlS RgJbuu54qiF6eNzyOa0alqG2V9S4ctQWXY7FQBrll0SPcIqkaveKNmv0dJHTJWFkmIIH c52MqLiCOqsdE7hjG7u4uewxR8aaJAGgeLzk7p2unEsQT0hJa0SmWWNPoyEW/4JRJqqt 7NuXBOtDK02Z9vdBZAGC9SCU1I9CQCOeXebV7x5jOXYImUDjkh7XM+OTJTg47YOn5FsD pbkA==
X-Gm-Message-State: AE9vXwOcdp28ZtQPJM7kh4CBJc5zXMJug+9VVWsSQVgi6rSWN1X92gHHDE5eObnzmb+kFFMKNtrQ1sUldt60tQ==
X-Received: by 10.25.89.70 with SMTP id n67mr4469426lfb.163.1473975677225; Thu, 15 Sep 2016 14:41:17 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.25.28.15 with HTTP; Thu, 15 Sep 2016 14:41:16 -0700 (PDT)
In-Reply-To: <20160818122745.O28290@sapphire.juniper.net>
References: <20160818122745.O28290@sapphire.juniper.net>
From: Stig Venaas <stig@venaas.com>
Date: Thu, 15 Sep 2016 14:41:16 -0700
Message-ID: <CAHANBtL6qobVwHriADgJpmRtXH6E3336=_k__uwoEMtSPDig8A@mail.gmail.com>
To: Leonard Giuliano <lenny@juniper.net>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mboned/1KmlFNJ9wmBHRbR4BqdSjzFpjoE>
Cc: MBONED WG <mboned@ietf.org>
Subject: Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2
X-BeenThere: mboned@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Mail List for the Mboned Working Group <mboned.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mboned>, <mailto:mboned-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mboned/>
List-Post: <mailto:mboned@ietf.org>
List-Help: <mailto:mboned-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mboned>, <mailto:mboned-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Sep 2016 21:41:21 -0000
Hi I think the draft is ready for publication with just minor changes. Here are all my comments. In the introduction it first talks about tracing down vs up the tree. Then it says Mtrace2 is usually initiated from a Mtrace2 client towards a specified source, or a Rendezvous Point (RP) if no source address is specified. It's not clear here whether "usually" is regarding tracing to a source, or if it talks about the complete sentence. Given the first paragraph, "usually" could potentially mean something other than tracing from a client. Also please write "or towards a Rendezvous..." or should it be "or from a Rendezvous..."? Also in the introduction it says: RP is a special router where the source and receiver meet in PIM-SM [5]. Perhaps it would be better to write "sources and receivers"? We have this sentence: Moreover, Mtrace2 provides additional information such as the packet rates and losses, as well as other diagnosis information. Would it be better to say "diagnostic information"? Or maybe information for diagnosis? There is this sentence: Source, Receiver and Mtrace2 client are typically a host on the Internet. Should be "hosts on the Internet", or "Internet hosts". >From earlier in the introduction it appears that a source address is optional, that it can be an RP address instead? But then we have this sentence: When an Mtrace2 client initiates a multicast trace anywhere on the Internet, it sends an Mtrace2 Query packet to the LHR or RP for a multicast group and a source address. So it seems one always need to specify a source address? Maybe you can remove "anywhere on the Internet"? It seems unnecessary. Multicast is most often used outside of what is typically called the Internet, so I think it might be better to not use the term Internet that much. In 2.1 we have this text: Outgoing interface The interface to which data from the source or RP is expected to transmit for the specified source and group. It is also the interface on which the Mtrace2 Request will be received. Maybe "expectte to be transmitted" is better? It should maybe not say "the interface" as there can be many outgoing interface. Perhaps say that "it is also an interface on which an Mtrace2 Request may be received". Last-hop router (LHR) The router that is directly connected to the receivers. It is also the router that receives the Mtrace2 Query from an Mtrace2 client. Maybe better to say "A router that is directly connected to a receiver"? In second paragraph of section 3 it says: If the length of a TLV exceeds the length specified in the TLV, the TLV SHOULD be accepted; however, any additional data after the specified TLV length SHOULD be ignored. Note that if this happens one may need to ignore all data after the length. Not just what was supposed to be in that one TLV, as one does not know where the data ends. Also, it may not be possible to detect that the TLV is longer than the length. Once the length is reached, one will simply have to assume that the next byte is the start of the next "field" in the packet. Also if one were to find out, it is possible that there is some corruption, or that the value is not what it was intended to me. Please consider whether this sentence makes sense. If it does, please add some more clarification. In 3.1 it says: Length: 16 bits Length of Type, Length, and Value fields in octets. Minimum length required is 6 octets. The maximum TLV length is not defined; however the entire Mtrace2 packet length should not exceed the available MTU. As I understand it, type and length fields are included. Which means that a value must be at least 3 bytes? Is this correct? Even if it is correct now, is it wise to require at least 6 octets here? Isn't it possible that new TLVs might be defined in the future where this may not be the case? It looks like normative language may be missing some places. E.g SHOULD NOT in the length description here? See also MBZ fields. In 4.2.1 it says the term 224/24 is used. I think it is best to write 224.0.0.0/24. In 4.2.2 it says: The first one encountered is the one that is reported, i.e. all "note Forwarding Code N" should be interpreted as "if Forwarding Code is not already set, set Forwarding Code to N". Does this mean that the router must process the message following the steps in this order? I think it might make sense for a router to for instance report 5 ADMIN_PROHIB without first checking if it has a route NO_ROUTE in 3. In 4.3.2: An Mtrace2 Request should be sent with the address of the Incoming interface. However, if the Incoming interface is unnumbered, the router can use one of its numbered interface address as the source address. I think it should say "one of its numbered interface addresses". Same in 4.4.2. In 6 it says: This section describes the Mtrace2 behavior with the present of different multicast protocols. Present should be presence. iN 8.2 it says: The IANA should allocate UDP destination port for Mtrace2 upon publication of the first RFC. Maybe better to refer to this document? What do you want this section to say after publication? Perhaps it is better to write something like: The Mtrace2 UDP destination port is [TBD]. It might be easier for IANA if you here list the name and exact content of the registries. I see you are requiring Standards Action. Should e.g. Experimental RFCs not be allowed? Regards, Stig
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Hitoshi Asaeda
- [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Leonard Giuliano
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Stig Venaas
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Hitoshi Asaeda
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Stig Venaas
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Leonard Giuliano
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 TARAPORE, PERCY S
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Holland, Jake
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Hitoshi Asaeda
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Leonard Giuliano
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Holland, Jake
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Hitoshi Asaeda
- Re: [MBONED] WGLC for draft-ietf-mboned-mtrace-v2 Mankamana Mishra (mankamis)