Re: [MIB-DOCTORS] [IETFMIBS] MIB Doctor for draft-ietf-isms-dtls-tm

"Bert Wijnen \(IETF\)" <bertietf@bwijnen.net> Wed, 14 April 2010 21:58 UTC

Return-Path: <bertietf@bwijnen.net>
X-Original-To: mib-doctors@core3.amsl.com
Delivered-To: mib-doctors@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 2763D28C136; Wed, 14 Apr 2010 14:58:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.734
X-Spam-Level:
X-Spam-Status: No, score=0.734 tagged_above=-999 required=5 tests=[AWL=1.176, BAYES_00=-2.599, HELO_MISMATCH_NET=0.611, HOST_EQ_NL=1.545, HTML_MESSAGE=0.001]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E2XcwKF704dl; Wed, 14 Apr 2010 14:58:55 -0700 (PDT)
Received: from relay.versatel.net (relay57.tele2.vuurwerk.nl [62.250.3.57]) by core3.amsl.com (Postfix) with ESMTP id 6BF7E28C10F; Wed, 14 Apr 2010 14:58:54 -0700 (PDT)
Received: from [87.215.199.34] (helo=BertLaptop) by relay.versatel.net with smtp (Exim 4.69) (envelope-from <bertietf@bwijnen.net>) id 1O2Abb-0003h5-B6; Wed, 14 Apr 2010 23:58:43 +0200
Message-ID: <013862A294AD465CB9397780B8172023@BertLaptop>
From: "Bert Wijnen (IETF)" <bertietf@bwijnen.net>
To: Wes Hardaker <wes@hardakers.net>
References: <4BBE3A2D.8090207@ieca.com><EDC652A26FB23C4EB6384A4584434A04020C20D5@307622ANEX5.global.avaya.com><20100413100958.GH15769@elstar.local><B31D465B12E547F8BE50CD10DA8EB6DB@BertLaptop> <sdljcp9280.fsf@wjh.hardakers.net>
In-Reply-To: <sdljcp9280.fsf@wjh.hardakers.net>
Date: Wed, 14 Apr 2010 23:58:22 +0200
Organization: Consultant
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_23E2_01CADC2E.5D17D610"
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Windows Mail 6.0.6002.18005
X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6002.18005
Cc: Sean Turner <turners@ieca.com>, ietfmibs@ietf.org, "MIB Doctors (E-mail)" <mib-doctors@ietf.org>
Subject: Re: [MIB-DOCTORS] [IETFMIBS] MIB Doctor for draft-ietf-isms-dtls-tm
X-BeenThere: mib-doctors@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: MIB Doctors list <mib-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mib-doctors>
List-Post: <mailto:mib-doctors@ietf.org>
List-Help: <mailto:mib-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2010 21:58:57 -0000

Thanks Wes, the changes do address my comments.

Bert
  ----- Original Message ----- 
  From: Wes Hardaker 
  To: Bert Wijnen (IETF) 
  Cc: Juergen Schoenwaelder ; Romascanu, Dan (Dan) ; MIB Doctors (E-mail) ; Sean Turner ; ietfmibs@ietf.org 
  Sent: Wednesday, April 14, 2010 11:02 PM
  Subject: Re: [IETFMIBS] [MIB-DOCTORS] MIB Doctor for draft-ietf-isms-dtls-tm


  >>>>> On Tue, 13 Apr 2010 22:35:44 +0200, "Bert Wijnen (IETF)" <bertietf@bwijnen.net> said:

  BW> I agree that the MIB module is structurally sound.

  Bert,

  I've addressed them all in the document as discussed in my responses
  below.  Thanks again for the review and please let me know if you want
  to discuss any of the items further!

  My responses are prefixed below with "WH:" if you want to search for
  them.  The status of each item is as follows:

    DONE:     Suggestion was acted on
    WONTDO:   Nothing was done; refer to the WH: response for reasons why
    DISCUSS:  There is an outstanding question back to you
    ANSWERED: A question was answered but had no action resulting from it

  Comments and responses:


  1 --- SMICng cghecking 
  ~~~~~~~~~~~~~~~~~~~~~~~

          + Bert: successfull parsing. Great!

          + WH: Thanks for checking; I've only been checking smilint

  2 DONE ----- more or less serious (maybe?): 
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

            - tlstmParamsCount OBJECT-TYPE
                SYNTAX      Unsigned32
                MAX-ACCESS  read-only
                STATUS      current
                DESCRIPTION
                    "A count of the number of entries in the tlstmParamsTable"
                ::= { tlstmCertificateMapping 4 }

          + Bert: Is this an object for which the value can go up and
            down when connections come and go? If so, is it then not
            better to use a SYNTAX of Gaug32 ??

          + WH: That's fine by me.  I was using the Unsigned32 from an
            example somewhere else (that I don't remember) and looking
            through a number of MIBs that do similar things I see usages
            of both.  I'll switch them to Gaug32.

  3 DONE same for object tlstmAddrCount and maybe for some other 
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          Counts as well?

  4 DONE I see (page 31):                     Co-editors: 
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

          + Bert: while there is only 1 editor!?

          + WH: Good point

  5 DONE I personally thought that on page 32: 
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 
                    This version of this MIB module is part of RFC XXXX;
                    see the RFC itself for full legal notices."

                 -- NOTE to RFC editor: replace XXXX with actual RFC number
                 --                     for this document and remove this note

                   REVISION     "201003060000Z"
                   DESCRIPTION  "The initial version, published in RFC XXXX."
                -- NOTE to RFC editor: replace XXXX with actual RFC number
                --                     for this document and remove this note
                ::= { snmpModules xxxx }

            + Bert: Probably should all just be in the REVISION DESCRIPTION
              clause and not in the MODULE DESCRIPTION clause. But I can
              live with it.  However, if a future revision does ever
              come outm then the DESCRIPTION clause will have to be
              updated also.

            + WH: Fair point; I've changed it to:

                     REVISION     "MIBDATE0000Z"
                     DESCRIPTION  "This version of this MIB module is part of
                                   RFC XXXX; see the RFC itself for full legal
                                   notices."

              -- NOTE to RFC editor: replace XXXX with actual RFC number 
              --                     for this document and change the date to the
              --                     current date and remove this note
  -- 
  Wes Hardaker                                     
  My Pictures:  http://capturedonearth.com/
  My Thoughts:  http://pontifications.hardakers.net/