Re: [MIB-DOCTORS] Review for WG Adoption of draft-vkst-mpls-tp-oam-id-mib-02.txt

Thomas Nadeau <tnadeau@juniper.net> Mon, 04 June 2012 16:17 UTC

Return-Path: <tnadeau@juniper.net>
X-Original-To: mib-doctors@ietfa.amsl.com
Delivered-To: mib-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 07EC321F87E0; Mon, 4 Jun 2012 09:17:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.517
X-Spam-Level:
X-Spam-Status: No, score=-6.517 tagged_above=-999 required=5 tests=[AWL=-0.052, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, SARE_SUB_OBFU_OTHER=0.135]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wsbDpVIrX1n2; Mon, 4 Jun 2012 09:17:45 -0700 (PDT)
Received: from exprod7og123.obsmtp.com (exprod7og123.obsmtp.com [64.18.2.24]) by ietfa.amsl.com (Postfix) with ESMTP id 10D8521F878E; Mon, 4 Jun 2012 09:17:33 -0700 (PDT)
Received: from P-EMHUB01-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob123.postini.com ([64.18.6.12]) with SMTP ID DSNKT8zfnNBw5jlwqocK3aIxUjVo2Jt+bn/F@postini.com; Mon, 04 Jun 2012 09:17:44 PDT
Received: from p-emfe01-wf.jnpr.net (172.28.145.24) by P-EMHUB01-HQ.jnpr.net (172.24.192.35) with Microsoft SMTP Server (TLS) id 8.3.213.0; Mon, 4 Jun 2012 09:16:45 -0700
Received: from EMBX01-WF.jnpr.net ([fe80::1914:3299:33d9:e43b]) by p-emfe01-wf.jnpr.net ([fe80::d0d1:653d:5b91:a123%11]) with mapi; Mon, 4 Jun 2012 12:16:21 -0400
From: Thomas Nadeau <tnadeau@juniper.net>
To: Loa Andersson <loa@pi.nu>
Date: Mon, 04 Jun 2012 12:16:21 -0400
Thread-Topic: Review for WG Adoption of draft-vkst-mpls-tp-oam-id-mib-02.txt
Thread-Index: Ac1CbWEnaoiQRWEnQzOYxa2o9Epciw==
Message-ID: <23EA0526-866E-4151-BBF6-6C26DE0A44AF@juniper.net>
References: <CBE2CB86.E91B%tnadeau@juniper.net> <4FCAC8F6.8060200@pi.nu>
In-Reply-To: <4FCAC8F6.8060200@pi.nu>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: Swallow George <swallow@cisco.com>, "mpls@ietf.org" <mpls@ietf.org>, "ppan@infinera.com" <ppan@infinera.com>, Sami Boutros <sboutros@cisco.com>, "aldrin.ietf@gmail.com" <aldrin.ietf@gmail.com>, Ross Callon <rcallon@juniper.net>, Kannan KV Sampath <Kannan.Sampath@aricent.com>, "MIB Doctors (E-mail)" <mib-doctors@ietf.org>, "venkat.mahalingams@gmail.com" <venkat.mahalingams@gmail.com>, Martin Vigoureux <martin.vigoureux@alcatel-lucent.com>
Subject: Re: [MIB-DOCTORS] Review for WG Adoption of draft-vkst-mpls-tp-oam-id-mib-02.txt
X-BeenThere: mib-doctors@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: MIB Doctors list <mib-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mib-doctors>
List-Post: <mailto:mib-doctors@ietf.org>
List-Help: <mailto:mib-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jun 2012 16:17:46 -0000

yes we will update.

thanks again Joan for reviewing!

Tom 



On Jun 2, 2012, at 10:16 PM, "Loa Andersson" <loa@pi.nu> wrote:

> Authors,
> 
> The review by Joan was part of the MPLS RT review prior to polling the
> document to become a working group.
> 
> Though updating the draft prior to the poll is strictly not necessary
> to start the poll. However I would strongly prefer to poll an updated
> document.
> 
> Could you please update and republish.
> 
> /Loa
> (as wg chair)
> 
> On 2012-05-23 23:16, Thomas Nadeau wrote:
>> 
>>    Hi Joan!
>> 
>>    Thanks for the review. Comments inline start with TOM:
>> 
>> On 5/23/12 11:30 AM, "Joan Cucchiara"<jcucchiara@mindspring.com>  wrote:
>> 
>>> 
>>> Hello Authors,
>>> 
>>> Thank you for proposing this solution.
>>> Please see my notes below.
>>> 
>>> Thank you,
>>>  -Joan
>>> 
>>> 1) Coherency of document:
>>> A) Is document useful and likely to be used/useful in operational
>>> networks?
>>> 
>>> This document contains a MIB Module with 2 tables.  The tables allow
>>> creation of
>>> TP IDs of MPLS LSPs and Pseudowires.   Also a pointer to rows in
>>> other MIBs Modules., i.e. to an MPLS Tunnel in the MPLS-TE-STD-MIB
>>> (RFC3012)
>>> or
>>> pseudowire in the PWE-STD-MIB (RFC5601).   Since many vendors and
>>> operators
>>> support the MPLS-TE-STD-MIB and PW-STD-MIB, then one could agree with the
>>> authors that the architecture of this MIB is a viable approach.
>>> 
>>> In other words, the authors are leveraging off of existing MIB
>>> implementations.
>>> They are doing this in a way which adheres to the rules of SMIv2 and I do
>>> think that the MIB is likely to be used/useful in operational networks.
>>> 
>>> 
>>> B) Is document technically sound?
>>> 
>>> From a MIB perspective, no:
>>> 
>>> I) Many objects are of type "DisplayString" which is used
>>> in SMIv1 but not in SMIv2.
>>> 
>>> As the MIB Common TC doc specifies:
>>> 
>>> https://svn.tools.ietf.org/area/ops/trac/wiki/mib-common-tcs
>>> 
>>> 
>>>   "Note 2.  DisplayString does not support internationalized text.
>>>            It MUST NOT be used for objects that are required to
>>>            hold internationalized text (which is always the case
>>>            if the object is intended for use by humans [RFC2277]).
>>>            Designers SHOULD consider using SnmpAdminString,
>>>            Utf8String, or LongUtf8String for such objects."
>>> 
>>> II) The term "Trap" is used in both the document and the MIB.
>>> This needs to be replaced by the term "Notification".  Traps a mechanism
>>> in SNMPv1.   Please see RFC3584.
>> 
>> TOM: Ooops! We will fix this.
>> 
>>> 2) Is document ready for WG adoption?
>>> 
>>> I would ask that changes to remove DisplayString and use a TC which
>>> supports internationalization be done, and the term Trap removed
>>> prior to WG adoption for reasons stated above.
>>> 
>>> This request should only take a few minutes of editing, but will bring
>>> the
>>> document upto SMIv2.
>> 
>> TOM: Agree. There is no big issue fixing this. We will need to re-spin the
>> draft in a WG-approved format anyways, so we can fix this during those
>> edits.
>> 
>>> 
>>> Additionally, a few comments (mostly as fyi):
>>> 
>>> I) this MIB contains configuration (read-create) objects.
>>> 
>>> II) the document proposes to root the MIB under mplsStdMIB which was
>>> the convention for the set of MPLS MIBs in 2004 but guidelines have
>>> changed since then.
>>> 
>>> III) The use of the accessible-for-notify and imports of
>>> IFMIB tables do not seem necessary in the MIB's current state.
>>> As the MIB is updated, this should be removed or clarified.
>> 
>> TOM: Cool.
>> 
>>    --Tom
>> 
>>> 
>>> 
>> 
> 
> -- 
> 
> 
> Loa Andersson                         email: loa.andersson@ericsson.com
> Sr Strategy and Standards Manager            loa@pi.nu
> Ericsson Inc                          phone: +46 10 717 52 13
>                                              +46 767 72 92 13