Re: [MLS] Intdir telechat review of draft-ietf-mls-architecture-10

Benjamin Beurdouche <ietf@beurdouche.com> Mon, 30 January 2023 17:39 UTC

Return-Path: <ietf@beurdouche.com>
X-Original-To: mls@ietfa.amsl.com
Delivered-To: mls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CCFA7C17D66E for <mls@ietfa.amsl.com>; Mon, 30 Jan 2023 09:39:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.894
X-Spam-Level:
X-Spam-Status: No, score=-6.894 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=beurdouche-com.20210112.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6ROSXTSvMkEL for <mls@ietfa.amsl.com>; Mon, 30 Jan 2023 09:39:48 -0800 (PST)
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E594BC1782D0 for <mls@ietf.org>; Mon, 30 Jan 2023 09:39:48 -0800 (PST)
Received: by mail-wm1-x32a.google.com with SMTP id q8so8563870wmo.5 for <mls@ietf.org>; Mon, 30 Jan 2023 09:39:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beurdouche-com.20210112.gappssmtp.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=rWUaByvO8191VjzMpjNGYOtn2R0QtH0OBxR/k5exlNc=; b=i48l4D88Mi+7y8CcPl1I199kZFoGtbmbey3DALFW6cx9oixwbgQgAPw9fklHHh0hmn s2SPnJ5MjagsQfZZelxdkfU3OvdoV8PsUJxbGFu0ftmGISoMassmLfGlb9BCxeFpyzcr Gsz8WnHQIjL0tjE8H0YmKpoPEGQznLaIhocvwX2q3dDfXNdSQ/7GWh7wsdRt25d1eAj2 MwDK4+MQApEROrMRrlKvy1gx09OE6xuzYzShs4vgmaEESqnraVr3k7y0jusS4mIp6rXe zIqvvyXqkhj099KajGB4MOB9/vStSmfNusYsGoM0qFiKbqxG15HofmOCLzqC0yYWEC7d 1ZZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rWUaByvO8191VjzMpjNGYOtn2R0QtH0OBxR/k5exlNc=; b=fW5XDcUKiDm/K7H6P9AhlMdh14nhCyDEsoDxk8hBtv0Zgr16CRpM2n22kICaC+vloO GbnAj7igXF4fHxMFs9lEKvZ0oRXfhqp2NC7xyc8m3R/GSXZMStiMUIqib9SBk6NOVcrX m58e2dlymWQY1ULWQwYgc6imgwNcdJ8dNrLmbRvJn7SPwY5oCUXkg+8dUctBv0mTkSHP 2m+Zyai4Tyc7J+++afWe3SZIWgXlKrwrIaXCb63q3x5UQZ46laHVFO8ynxzV9rv5WLIs tAIPD1OGcmhIhdsQ3KLm4yXgJcsEbJwB2J+GW7yvvRvjh1BZ50UxVNs4ehXkg348x3mC dxrQ==
X-Gm-Message-State: AO0yUKVen+jVRRCxTdPS83EHBEW+Cd5aMefof4CtlqPtuAfeF1Vb9SZ8 crF1MiKVS8h+Xgnc+sBHx1OIaQ==
X-Google-Smtp-Source: AK7set97OPuEAOyfbOBmc96UEi33VRZhdKf6bcEsYg+xDyngsxOxHigD6jZuucbw3OlXH/MyDmbhsA==
X-Received: by 2002:a05:600c:540e:b0:3dc:3b29:7a4 with SMTP id he14-20020a05600c540e00b003dc3b2907a4mr390184wmb.0.1675100386528; Mon, 30 Jan 2023 09:39:46 -0800 (PST)
Received: from smtpclient.apple ([2a01:e34:ec0d:ee60::5698:6711]) by smtp.gmail.com with ESMTPSA id bi5-20020a05600c3d8500b003db0bb81b6asm14023657wmb.1.2023.01.30.09.39.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2023 09:39:46 -0800 (PST)
From: Benjamin Beurdouche <ietf@beurdouche.com>
Message-Id: <EA74CFE4-3F1B-4512-BB42-9D86E76DF3F5@beurdouche.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_D4DBAA7F-AA83-48BE-AB6A-38E14E2DCF16"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Date: Mon, 30 Jan 2023 18:39:35 +0100
In-Reply-To: <167506120307.61575.12546953893984927280@ietfa.amsl.com>
Cc: int-dir@ietf.org, draft-ietf-mls-architecture.all@ietf.org, ML IETF Messaging Layer Security <mls@ietf.org>
To: Tatuya Jinmei <jinmei@wide.ad.jp>
References: <167506120307.61575.12546953893984927280@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3731.300.101.1.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/mls/TqOAgVRRhxX5L30HrqSNy_hHgWs>
Subject: Re: [MLS] Intdir telechat review of draft-ietf-mls-architecture-10
X-BeenThere: mls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Messaging Layer Security <mls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mls>, <mailto:mls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mls/>
List-Post: <mailto:mls@ietf.org>
List-Help: <mailto:mls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mls>, <mailto:mls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jan 2023 17:39:49 -0000

Hi Tatuya,

Thanks for the review !
I have opened the following issue to track your comments.

https://github.com/mlswg/mls-architecture/issues/177 

Best,
Benjamin


> On 30 Jan 2023, at 07:46, Tatuya Jinmei via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Tatuya Jinmei
> Review result: Ready with Nits
> 
> I am an assigned INT directorate reviewer for
> draft-ietf-mls-architecture-10.txt. These comments were written primarily for
> the benefit of the Internet Area Directors. Document editors and shepherd(s)
> should treat these comments just like they would treat comments from any other
> IETF contributors and resolve them along with any other Last Call comments that
> have been received. For more details on the INT Directorate, see
> https://datatracker.ietf.org/group/intdir/about/.
> 
> I've reviewed the draft in terms of issues or concerns for the Internet Area.
> I've not seen any such issues. And, overall, the document is well written and
> looks complete for publication.
> 
> The only possible nit I might note is that some technical terms such as
> "Proposal" or "Commit" messages are used without a reference or definition,
> which confused me while reviewing the draft. From a quick look at the protocol
> draft, these may be defined in that draft, but in any case, it would be more
> reader friendly if the architecture draft has a "terminology" section, listing
> some of those terms with a brief description and or a proper reference.
> 
> 
>