[MLS] Opsdir early review of draft-ietf-mls-protocol-16
Bo Wu via Datatracker <noreply@ietf.org> Thu, 29 September 2022 12:54 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: mls@ietf.org
Delivered-To: mls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 89EA7C152715; Thu, 29 Sep 2022 05:54:57 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Bo Wu via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-mls-protocol.all@ietf.org, mls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.17.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166445609755.17020.16407000581259689880@ietfa.amsl.com>
Reply-To: Bo Wu <lana.wubo@huawei.com>
Date: Thu, 29 Sep 2022 05:54:57 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mls/o-2RdSTL2VV-k0NQ_52Fg6A8zqo>
Subject: [MLS] Opsdir early review of draft-ietf-mls-protocol-16
X-BeenThere: mls@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Messaging Layer Security <mls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mls>, <mailto:mls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mls/>
List-Post: <mailto:mls@ietf.org>
List-Help: <mailto:mls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mls>, <mailto:mls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2022 12:54:57 -0000
Reviewer: Bo Wu Review result: Has Nits I have been assigned to review this document on behalf of the OPS DIR. This draft defines a key establishment protocol for the messaging application to protect group chat. Overall, the document is full of security technical details. Major Issue: 1. Introduction Perhaps highlighting the relationship between MLS Architecture in the introduction section can help to understand? I find the description of authentication and delivery service in MLS Architecture really helps. Nits: 4.2. Example Protocol Execution It's a more readable if the figure can be referenced in the text. E.g. figure 2 and figure 3, it is helpful to show which part of text corresponds to the figures. 6.1. Ciphersuites AEAD, ECDSA: Please expand on first use. 7. Message Framing enum { reserved(0), mls10(1), (255) } ProtocolVersion; Current protocol is defined as MLS 1.0, but maybe it's possible to explicitly describe the current protocol version and the negotiation mechanism?
- [MLS] Opsdir early review of draft-ietf-mls-proto… Bo Wu via Datatracker
- Re: [MLS] Opsdir early review of draft-ietf-mls-p… Richard Barnes