[MMUSIC] APPSDIR review of draft-ietf-mmusic-latching-05

"Vijay K. Gurbani" <vkg@bell-labs.com> Fri, 23 May 2014 13:48 UTC

Return-Path: <vkg@bell-labs.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A07011A04B8; Fri, 23 May 2014 06:48:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1sGHuDuu0PaU; Fri, 23 May 2014 06:48:15 -0700 (PDT)
Received: from ihemail4.lucent.com (ihemail4.lucent.com [135.245.0.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5580A1A04B7; Fri, 23 May 2014 06:48:12 -0700 (PDT)
Received: from usnavsmail4.ndc.alcatel-lucent.com (usnavsmail4.ndc.alcatel-lucent.com [135.3.39.12]) by ihemail4.lucent.com (8.13.8/IER-o) with ESMTP id s4NDlvLJ011180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 23 May 2014 08:47:58 -0500 (CDT)
Received: from umail.lucent.com (umail.ndc.lucent.com [135.3.40.61]) by usnavsmail4.ndc.alcatel-lucent.com (8.14.3/8.14.3/GMO) with ESMTP id s4NDlvBk020367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 23 May 2014 08:47:57 -0500
Received: from shoonya.ih.lucent.com (shoonya.ih.lucent.com [135.185.238.169]) by umail.lucent.com (8.13.8/TPES) with ESMTP id s4NDlv79013281; Fri, 23 May 2014 08:47:57 -0500 (CDT)
Message-ID: <537F520E.3060501@bell-labs.com>
Date: Fri, 23 May 2014 08:50:06 -0500
From: "Vijay K. Gurbani" <vkg@bell-labs.com>
Organization: Bell Laboratories, Alcatel-Lucent
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: "apps-discuss@ietf.org" <apps-discuss@ietf.org>, draft-ietf-mmusic-latching@tools.ietf.org
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.64 on 135.3.39.12
Archived-At: http://mailarchive.ietf.org/arch/msg/mmusic/-OshYijb1tCnxPE_LwJKWsUGgJg
X-Mailman-Approved-At: Fri, 23 May 2014 06:49:54 -0700
Cc: IESG IESG <iesg@ietf.org>, mmusic <mmusic@ietf.org>
Subject: [MMUSIC] APPSDIR review of draft-ietf-mmusic-latching-05
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 23 May 2014 13:48:20 -0000

I have been selected as the Applications Area Directorate reviewer for
this draft (for background on appsdir, please see ​
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate).

Please resolve these comments along with any other Last Call comments
you may receive. Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-mmusic-latching-05
Title: Latching: Hosted NAT Traversal (HNT) for Media in Real-Time
Communication
Reviewer: Vijay K. Gurbani
Review Date: May 23-2014
IETF Last Call Date: May-28-2014
IESG Telechat Date: May-29-2014

Summary: This draft is almost ready for publication as an Informational
RFC but has a few issues that should be fixed before publication.

The draft captures excellent discussions on latching and provides a
great overview on what it is, how it works, and despite its simplicity,
why not to use it.  However, the tone of the draft should change from
colloquial to something more objective (various examples of this in
the Nits section).

Major: 0
Minor: numerous (see below)
Nits:  numerous (see below)

Minor:

- S1, second to last paragraph: Not sure I understand what you mean by

    The SIP signaling-layer component of HNT is typically more
    implementation-specific and deployment-specific than the SDP and
    media components.

  SDP is as much of a standard as SIP is, no?  Maybe you mean to say that
  because of the complexity of representing SIP messages, the SIP portion
  of a RTC component's stack may vary between implementations and deploy-
  ments.  SDP, being a simpler protocol (at least syntactically), is not
  exposed to such vagaries.  Yes?

- S3, second paragraph: "newly introduced media relay" --- newly
  introduced to who?  Perhaps you mean "a media relay incorporated into
  session establishment"?  Is this paragraph saying that the SBC and
  media relay may be co-located on the same host?

- S4, the descriptional steps below the text "The latching mechanism
  works as follows:" will be improved if you used "UAC" or "UAS" instead
  of "UA" (I recognize that in SIP it is not necessary that the UAC
  make the first offer, but these steps are for illustrative purposes
  and it helps to be as clear as we can for neophyte readers).  Even
  much better if you could cast the actors in terms of the principals
  Alice and Bob that appear in Figures 2.  So, something like "After
  receving an offer from Alice (UAC) who is behind a NAT" is preferable
  (I think) to "After receiving an offer from a NATed UA".

- S4, the numbered steps in Figure 2: change UAC to Alice in all of
  the steps, and change UAS to Bob in all of the steps.  Easier for
  neophyte readers to follow.  Alternatively, you may put "(UAC)"
  above Alice and "(UAS)" above Bob to impart the same semantics.

- S4, Figure 2: the text between step 12 and step 13 ("(SBC latches
  to source IP address and port seen in (10))" --- what is this
  referring to?  Is it referring to the latching created by Alice?
  or Bob?  It is not clear, specially since I am not sure if the
  "(10)" in the text I quote is a typo or not.  Maybe you meant
  "(7)" or maybe "(2)"?

- S4, Figure 2, step 13: Much as you do in step 11, you should
  spell out the "dest" field here as well.  So,
  s/RTP/RTP, dest=198.51.100.2:22007/

- S5, first paragraph, line 12: s/onto packets/onto media packets/

- S5, first paragraph, line 14: "... a range of IP addresses belonging
  to the same network..."  Here, "same" as which one?  I suspect you
  mean the attacker's network.  But being explicit is better here.

- S5, first paragraph, towards the end: "widen the gap for potential
  attackers..." Here, I suspect you mean that it provides the attackers
  more IP address from which to mount attacks, i.e., advantage:
  attackers.  Yes?

- S5, second paragraph: s/In all/All/

- S5, second paragraph: s/disturb media/impact media/

- S5, third paragraph:
  s/since the SBC will not latch onto the attacker's packets./since the
  SBC will not latch onto the attacker's media packets, not having
  seen the corresponding signaling packets first./

- S5, third paragraph: I am not sure I understand case (2).  Why would
  an SBC latch on to an attacker if it is using restricted latching?
  Teasing this case further, if the legitimate user hangs up the call
  because it is not getting any media packets, then a BYE should go
  through the SBC causing it to discard latched states, thereby
  preventing any more media packets from going to the attacker.

  Assuming that the attacker had inserted itself as a man-in-the-middle
  and was relaying packets to the UA, then sure, the legitimate user
  will not hang up and continue conversing.

  The case of a non-human user (answering machine) is redundant since
  the behaviour of the user (non-human or otherwise) is essentially
  the same.

- S5, fourth paragraph: "For example, in cases where end-to-end
  encryption is used it would still be possible for an attacker to
  hijack a session despite the use of SRTP and perform a denial of
  service attack.  However, media integrity would not be compromised."

  Can you explain more broadly how the above would work?  If we assume
  that the endpoints exchange keys end-to-end and create secure channels
  end-to-end, how would the attacker hijack a session?  (Heartbleed and
  all such mechanisms aside, of course.  If we assume keys are derived
  end-to-end and don't follow the hop-by-hop model, how would the
  attacker prevail?)

Nits:

- Abstract, 3rd paragraph:
  s/components of the HNT components/components of HNT/

  In fact, the entire 3rd paragraph could be written more succinctly as
  follows:

    Latching, one of the components of HNT, has a number of security
    issues detailed in this document.  Based on the known threats, the
    IETF advises against use of this mechanism on the Internet and
    recommends other solutions, such as the Interactive Connectivity
    Establishment (ICE) protocol.

- S1, second paragraph: s/They use IP/These protocols use IP/

- S1, second paragraph: s/as, in the/as, and in the/

- S1, fourth paragraph:
  s/some manufacturers sometimes/a number of manufacturers sometimes/

- S1, fifth paragraph: s/creation time/publication/

- S1, fifth paragraph: s/in the foreseeable/for the foreseeable/

- S1, sixth paragraph:
  s/are not novel to experts/are well known in the community/

- S1, seventh paragraph:
  s/In no way does this document/This document does not/

- S4, first paragraph: s/couple/tuple/

- S4, Figure 3: why not use the principals Alice and Bob here as
  well instead of "XMPP Client 1" and "XMPP Client 2"?

- S5, last sentence of second-to-last paragraph:
  s/However it is sometimes argued that, neither S/MIME nor
  [RFC4474] are widely deployed and that this may not be
  a real concern./However, neither S/MIME or [RFC4474] are widely
  deployed, thus not being able to sign/verify requests appear not
  to be a concern at this time./

Thanks,

- vijay
-- 
Vijay K. Gurbani, Bell Laboratories, Alcatel-Lucent
1960 Lucent Lane, Rm. 9C-533, Naperville, Illinois 60563 (USA)
Email: vkg@{bell-labs.com,acm.org} / vijay.gurbani@alcatel-lucent.com
Web: http://ect.bell-labs.com/who/vkg/  | Calendar: http://goo.gl/x3Ogq